Support passing in fabric manager config #2249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Allows the ability to customize log file path, log rotation, and more Signed-off-by: Kathryn Baldauf <[email protected]>
katiewasnothere
force-pushed
the
kabaldau/fabric_manager_config
branch
from
94c16f4 to
512aaa2
Compare
helsaawy
approved these changes
Aug 28, 2024
msscotb
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for passing in a configuration file when running fabric manager in the init program. If this configuration file is not present on the machine, fabric manager will fall back to running with all default settings.
The config file can be customized to determine where the fabric manager's logs will be output, when to rotate the log files, fabric operation mode, and more. See fabric manager doc for more details on how fabric manager works and how it can be configured.