Remove load-kmods option to libnvidia-container #2181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kathryn Baldauf <[email protected]>
helsaawy
approved these changes
Jun 21, 2024
msscotb
approved these changes
Jun 21, 2024
princepereira
pushed a commit
to princepereira/hcsshim
that referenced
this pull request
Aug 29, 2024
…e_nvidia_load_kmods Remove load-kmods option to libnvidia-container
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the
load-kmodsoption was set for libnvidia-container because we were not loading the kernel modules at pod boot time. However, recent changes #2167 would allow for loading kernel modules at boot time. We need to removeload-kmodsso we don't attempt to load the modules twice.Note: this also requires that persistence mode has been set in the pod so that the GPUs stay initialized between pod boot and container start.