Add security policy enforcement of environment variables #1146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anmaxvl
approved these changes
Sep 7, 2021
dcantah
reviewed
Sep 8, 2021
dcantah
reviewed
Sep 8, 2021
| container.EnvRules = append(container.EnvRules, rule) | ||
| } | ||
|
|
||
| // cri adds TERM=xterm for all workload containers. we add to all containers |
There was a problem hiding this comment.
This kinda worries me if this is ever changed. I'm still not sure how this even always get's set from our investigation. For now, not sure what else you could do at the moment so not saying to change
There was a problem hiding this comment.
this tool is a convenience for developers working on gcs and policy, if it changes, it is easy enough to adjust. this merely saves having to put it in every toml for that someone has.
There was a problem hiding this comment.
I need to check where the code I'm reviewing lives before I type. This is fine then
dcantah
reviewed
Sep 8, 2021
dcantah
reviewed
Sep 8, 2021
dcantah
reviewed
Sep 8, 2021
Supports two different matching schemes: - string This is a direct string match. All characters must be equal. - re2 The rule is an re2 regular expression that will be matched against the environment variable. Environment variables are in the form "KEY=VALUE" as a single string. The securitypolicy tool has been updated to automatically include any environment variables defined in the image spec for an image to the allowed environment variables in the generated policy. Signed-off-by: Sean T. Allen <[email protected]>
anmaxvl
pushed a commit
to anmaxvl/hcsshim
that referenced
this pull request
Nov 17, 2021
Related work items: microsoft#1062, microsoft#1087, microsoft#1089, microsoft#1095, microsoft#1104, microsoft#1112, microsoft#1117, microsoft#1118, microsoft#1125, microsoft#1137, microsoft#1139, microsoft#1140, microsoft#1141, microsoft#1142, microsoft#1143, microsoft#1145, microsoft#1146, microsoft#1150, microsoft#1151, microsoft#1153, microsoft#1154, microsoft#1155, microsoft#1156, microsoft#1157, microsoft#1158, microsoft#1159, microsoft#1161, microsoft#1162, microsoft#1163, microsoft#1164, microsoft#1165, microsoft#1166, microsoft#1167, microsoft#1168, microsoft#1169, microsoft#1171, microsoft#1172, microsoft#1173, microsoft#1174, microsoft#1178
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports two different matching schemes:
This is a direct string match. All characters must be equal.
The rule is an re2 regular expression that will be matched against the environment variable.
Environment variables are in the form "KEY=VALUE" as a single string.
The securitypolicy tool has been updated to automatically include any environment variables defined
in the image spec for an image to the allowed environment variables in the generated policy.
Signed-off-by: Sean T. Allen [email protected]