Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Support for NestedIpSet type in SetPolicy and a new Network Policy called NetworkACL policy #1045

Merged
merged 1 commit into from
Jun 10, 2021
Merged

Added Support for NestedIpSet type in SetPolicy and a new Network Policy called NetworkACL policy #1045

merged 1 commit into from
Jun 10, 2021

Conversation

netal
Copy link
Contributor

@netal netal commented Jun 10, 2021

  1. Added Support for Network level ACL policy
  2. Added a new type of SetPolicyType in SetPolicy- NESETEDIPSET

@netal netal requested a review from a team as a code owner June 10, 2021 00:44
dcantah
dcantah reviewed Jun 10, 2021
View reviewed changes
hcn/hcnsupport.go Outdated Show resolved Hide resolved
@netal netal force-pushed the user/negup/networkLevelACLPolicy branch from 791d5fa to a0e93da Compare June 10, 2021 17:55
erfrimod
erfrimod reviewed Jun 10, 2021
View reviewed changes
Copy link

@erfrimod erfrimod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Also add a test for Nested IP Sets. Doesn't have to be this PR.
  2. I notice some formatting oddities. Extra space after '}' and blank extra line. gofmt should automatically remove them. VSCode will run gofmt when you save a file if you have the right extension(s).

Other than that, looks good.

@elweb9858
Copy link
Contributor

lgtm

@dcantah dcantah merged commit 62680e0 into microsoft:master Jun 10, 2021
anmaxvl pushed a commit to anmaxvl/hcsshim that referenced this pull request Nov 17, 2021
@ambarve
Merged PR 4988349: Update ADO to c7c44e1
ec06a48 
Related work items: microsoft#930, microsoft#962, microsoft#1004, microsoft#1008, microsoft#1039, microsoft#1045, microsoft#1046, microsoft#1047, microsoft#1052, microsoft#1053, microsoft#1054, microsoft#1057, microsoft#1058, microsoft#1060, microsoft#1061, microsoft#1063, microsoft#1064, microsoft#1068, microsoft#1069, microsoft#1070, microsoft#1071, microsoft#1074, microsoft#1078, microsoft#1079, microsoft#1081, microsoft#1082, microsoft#1083, microsoft#1084, microsoft#1088, microsoft#1090, microsoft#1091, microsoft#1093, microsoft#1094, microsoft#1096, microsoft#1098, microsoft#1099, microsoft#1102, microsoft#1103, microsoft#1105, microsoft#1106, microsoft#1108, microsoft#1109, microsoft#1115, microsoft#1116, microsoft#1122, microsoft#1123, microsoft#1126
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erfrimod erfrimod erfrimod left review comments

@dcantah dcantah dcantah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@netal @elweb9858 @erfrimod @dcantah