Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lf line endingify stray opengcs files #1032

Merged
merged 1 commit into from
May 21, 2021

Conversation

dcantah
Copy link
Contributor

@dcantah dcantah commented May 19, 2021

For some reason there's 4 opengcs files that are crlf, oddly 2 out of the 3 files in
vsockexec..

The opengcs/README will be going by the wayside soon but it was caught in the altering. I needed to reset my local repo for the gitattributes

Signed-off-by: Daniel Canter [email protected]

@dcantah dcantah requested a review from a team as a code owner May 19, 2021 00:34
@katiewasnothere
Copy link
Contributor

Can you run go mod vendor in test/ to make sure files are reflected there if necessary?

@dcantah
Copy link
Contributor Author

dcantah commented May 19, 2021

yes

For some reason there's 2 opengcs files that are crlf, 2 out of the 3 files in
vsockexec..

Run go mod vendor + tidy in test in case

Signed-off-by: Daniel Canter <[email protected]>
Copy link
Contributor

@katiewasnothere katiewasnothere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants