Skip to content

Commit

Permalink
Remove graceful removal of vpci devices
Browse files Browse the repository at this point in the history
Signed-off-by: Kathryn Baldauf <[email protected]>
  • Loading branch information
katiewasnothere committed Jul 16, 2024
1 parent d69c26d commit 8485232
Showing 1 changed file with 0 additions and 9 deletions.
9 changes: 0 additions & 9 deletions internal/uvm/create.go
Original file line number Diff line number Diff line change
Expand Up @@ -234,15 +234,6 @@ func (uvm *UtilityVM) CloseCtx(ctx context.Context) (err error) {
windows.Close(uvm.vmmemProcess)

if uvm.hcsSystem != nil {
for key, dev := range uvm.vpciDevices {
// Try to remove any devices that are still on the UVM, but do not
// fail the close if there is an error.
// This would be devices that were added on pod creation.
if err := dev.Release(ctx); err != nil {
log.G(ctx).Errorf("graceful removal of vpci device %v failed: %s", key, err)
}
}

_ = uvm.hcsSystem.Terminate(ctx)
// uvm.Wait() waits on <-uvm.outputProcessingDone, which may not be closed until below
// (for a Create -> Stop without a Start), or uvm.outputHandler may be blocked on IO and
Expand Down

0 comments on commit 8485232

Please sign in to comment.