Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Create Isomorphic stylesheet for style renderer #137

Merged
merged 25 commits into from
Jun 17, 2022
Merged

feat: Create Isomorphic stylesheet for style renderer #137

merged 25 commits into from
Jun 17, 2022

Conversation

ling1726
Copy link
Member

@ling1726 ling1726 commented Jun 16, 2022 •
edited
Loading

The isomorphic stylesheet is intended mainly for SSR to simplify
element rendering and make current and future (i.e. media queries) insertion more straightforward.

The SSR renderToStyleElement function no longer needs to know about insertion cache or specific buckets

ling1726 added 2 commits June 16, 2022 08:52
@ling1726
with isomorphic style element
5158b1d
@ling1726
feat: Create Isomorphic shim for style element
30fa145 
The isomorphic style element is intended mainly for SSR to simplify
element rendering and make future insertion more straightforward (i.e.
for media queries).
@ling1726 ling1726 changed the title Feat/isomorphic style element feat: Create Isomorphic shim for style element Jun 16, 2022
@ling1726 ling1726 marked this pull request as ready for review June 16, 2022 07:11
@ling1726 ling1726 requested a review from a team as a code owner June 16, 2022 07:11
@ling1726 ling1726 changed the title feat: Create Isomorphic shim for style element feat: Create Isomorphic stylesheet for style renderer Jun 16, 2022
@ling1726 ling1726 requested a review from layershifter June 16, 2022 14:29
@microsoft microsoft deleted a comment from github-actions bot Jun 16, 2022
@github-actions
Copy link

github-actions bot commented Jun 16, 2022 •
edited
Loading

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react
makeStaticStyles (runtime)		 8.247 kB
3.595 kB		 8.533 kB
3.706 kB		 286 B
111 B
react
makeStyles + mergeClasses (runtime)		 21.294 kB
7.98 kB		 21.586 kB
8.082 kB		 292 B
102 B
react
makeStyles + mergeClasses (build time)		 2.811 kB
1.275 kB		 3.095 kB
1.394 kB		 284 B
119 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
core
makeStyles + mergeClasses (build time)		 1.8 kB
861 B
core
makeStyles + mergeClasses (runtime)		 20.269 kB
7.549 kB
🤖 This report was generated against 7bf674dd9dd896fdfe8346e6a33c8866dbe78bf3

@ling1726 ling1726 merged commit 4e4c7c2 into main Jun 17, 2022
@ling1726 ling1726 deleted the feat/isomorphic-style-element branch June 17, 2022 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@layershifter layershifter layershifter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ling1726 @layershifter