Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vulnerabilities - node-forge (1.2.1) #344

Conversation

anatolybolshakov
Copy link
Contributor

@anatolybolshakov anatolybolshakov commented May 19, 2022

Task name: all tasks + root dependencies

Description: bumped google-apis and google-auth-library versions to resolve node-forge vulnerability.

Documentation changes required: N

Added unit tests: N

Attached related issue: #342

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected - in progress

@anatolybolshakov
Copy link
Contributor Author

@mmrazik could you please take a look?

@vmapetr
Copy link
Contributor

vmapetr commented May 30, 2022

@anatolybolshakov changes are validated - everything works as expected.

  • GooglePlayRelease :

        action: 'SingleApk'
        apkFile: '**/*.apk'
        track: 'internal'
    • Expected behavior: New app version should be released for internal track
    • Actual behavior: New app version is released for internal track
  • GooglePlayPromote:

        sourceTrack: 'internal'
        destinationTrack: 'alpha'
        сleanTheSourceTrack: false
    • Expected behavior: App should be promoted from internal to alpha track
    • Actual behavior: App is promoted from internal to alpha track
  • GooglePlayRolloutUpdate:

        userFraction: '0.5' # 0.0 to 1.0 (0% to 100%)
        track: 'production'
    • Expected behavior: Rollout percentage should change from 0.1 to 0.5
    • Actual behavior: Rollout percentage is changed from 0.1 to 0.5
  • GooglePlayStatusUpdate:

            status: 'inProgress'
            track: 'production'
    • Expected behavior: Production release status should update from halted to in progress
    • Actual behavior: Production release status is updated from halted to in progress

@vmapetr vmapetr merged commit 84fe86a into microsoft:master Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants