Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button: Perf improvements #9984

Merged
merged 2 commits into from
Aug 1, 2019
Merged

Button: Perf improvements #9984

merged 2 commits into from
Aug 1, 2019

Conversation

khmakoto
Copy link
Member

@khmakoto khmakoto commented Jul 30, 2019

…le, small perf improvements and perf scenario updates.

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ yarn change

Description of changes

This PR creates a separate Actionable view that speeds up the Actionable component because it gets rid of unused slots and spreads some small perf fixes that check for the existence of icon and content before rendering them (these are not reflected in the perf-test scenarios).

Finally, this PR updates perf-test scenarios for Actionable and PrimaryButton so that they are more consistent across the board.

Focus areas to test

(optional)

Microsoft Reviewers: Open in CodeFlow

@size-auditor
Copy link

size-auditor bot commented Jul 30, 2019

Bundle test Size (minified) Diff from master
experiments-Button 94.789 kB ExceedsBaseline     723 bytes

ExceedsTolerance  Exceeds Tolerance     ExceedsBaseline  Exceeds Baseline     BelowBaseline  Below Baseline     1 kB = 1000 bytes

@msft-github-bot
Copy link
Contributor

Component Perf Analysis:

Scenario Master Samples * PR Samples *
BaseButton 732 765
BaseButton (experiments) 1690 1074
DefaultButton 1020 1068
DefaultButton (experiments) 1919 1977
DetailsRow 4096 4205
DetailsRow without styles 3954 3940
DocumentCardTitle with truncation 30919 30343
MenuButton 1806 1829
MenuButton (experiments) 4237 4046
PrimaryButton 1152 1192
PrimaryButton (experiments) 2201 1937
SplitButton 3297 3284
SplitButton (experiments) 7783 7404
Stack 447 474
Stack with Intrinsic children 1046 1098
Stack with Text children 4183 4160
Text 358 342
Toggle 829 841
Toggle (experiments) 2149 2379
button 57 56
* Sample counts can vary by up to 30% and shouldn't be used solely for determining regression. For more information please see the Perf Testing wiki.

@micahgodbolt micahgodbolt mentioned this pull request Jul 30, 2019
37 tasks
@dzearing dzearing merged commit 5dd84ec into microsoft:master Aug 1, 2019
@khmakoto khmakoto deleted the buttonPerf branch August 1, 2019 21:05
@msft-github-bot
Copy link
Contributor

🎉@uifabric/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@microsoft microsoft locked as resolved and limited conversation to collaborators Sep 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants