Button: Conditionally rendering KeytipData #9276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JasonGore
reviewed
May 29, 2019
packages/office-ui-fabric-react/src/components/Button/BaseButton.tsx
Outdated
Show resolved
Hide resolved
|
Component perf results:
|
…g to oufr split buttons.
JasonGore
reviewed
Jun 3, 2019
JasonGore
approved these changes
Jun 3, 2019
|
Hello @khmakoto! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
Adding a conditional render of
KeytipDataonly ifkeytipPropsare present inButtonin bothoffice-ui-fabric-reactandexperiments.Focus areas to test
(optional)
Microsoft Reviewers: Open in CodeFlow