-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SplitButton: Fixing some styling bugs related to the divider #9246
SplitButton: Fixing some styling bugs related to the divider #9246
Conversation
Component perf results:
|
Hello @khmakoto! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that is not currently met. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
@msft-github-bot wait for 1 hour |
Hello @khmakoto! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
Pull request checklist
$ npm run change
Description of changes
While writing VR tests and testing
Button
perf I realized that the styling for theSplitButton
divider was wrong:However, this did not repro on the component example page. After investigating it became apparent that the use of
Stack
in the example code was masking this issue. This PR fixes that styling issue so that the divider now looks correctly both in the component example page and in its independent use:Once this PR merges, this will also serve to unblock #9159, which was not being merged because
SplitButton
vr tests didn't look right.Finally, this PR also adds
display: inline-flex
to theroot
of bothMenuButton
andSplitButton
, so that they renderinline
like HTMLbuttons
do (this issue was highlighted by perf-tests that rendered a large number of theseButtons
).Focus areas to test
(optional)
Microsoft Reviewers: Open in CodeFlow