Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SplitButton: Fixing some styling bugs related to the divider #9246

Merged
merged 2 commits into from
May 28, 2019

Conversation

khmakoto
Copy link
Member

@khmakoto khmakoto commented May 28, 2019

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ npm run change

Description of changes

While writing VR tests and testing Button perf I realized that the styling for the SplitButton divider was wrong:

image

However, this did not repro on the component example page. After investigating it became apparent that the use of Stack in the example code was masking this issue. This PR fixes that styling issue so that the divider now looks correctly both in the component example page and in its independent use:

image

Once this PR merges, this will also serve to unblock #9159, which was not being merged because SplitButton vr tests didn't look right.

Finally, this PR also adds display: inline-flex to the root of both MenuButton and SplitButton, so that they render inline like HTML buttons do (this issue was highlighted by perf-tests that rendered a large number of these Buttons).

Focus areas to test

(optional)

Microsoft Reviewers: Open in CodeFlow

@msft-github-bot
Copy link
Contributor

msft-github-bot commented May 28, 2019

Component perf results:

Scenario Target branch avg total (ms) PR avg total (ms) Target branch avg per item (ms) PR avg per item (ms) Is significant change Is regression
PrimaryButton 93.228 97.974 0.932 0.980 false false
BaseButton 36.997 38.420 0.370 0.384 false false
NewButton 66.961 84.906 0.670 0.849 true true
button 6.440 6.675 0.064 0.067 false false
DetailsRows without styles 197.389 195.046 1.974 1.950 false false
DetailsRows 192.727 194.772 1.927 1.948 false false
Toggles 42.330 42.600 0.423 0.426 false false
NewToggle 73.069 69.960 0.731 0.700 false false
DocumentCardTitle with truncation 25.894 25.386 0.259 0.254 false false

@msft-github-bot
Copy link
Contributor

Hello @khmakoto!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that is not currently met. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msft-github-bot) and give me an instruction to get started! Learn more here.

@khmakoto
Copy link
Member Author

@msft-github-bot wait for 1 hour

@msft-github-bot
Copy link
Contributor

Hello @khmakoto!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I won't merge this pull request until after the UTC date Tue, 28 May 2019 23:31:01 GMT, which is in 1 hour

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

@microsoft microsoft deleted a comment from msft-github-bot May 28, 2019
@msft-github-bot msft-github-bot merged commit 1b8b476 into microsoft:fabric-7 May 28, 2019
@khmakoto khmakoto deleted the splitButtonStyles branch May 28, 2019 23:47
@microsoft microsoft locked as resolved and limited conversation to collaborators Aug 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants