Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bootstrap react-table package #23876

Merged
merged 2 commits into from
Jul 12, 2022
Merged

chore: bootstrap react-table package #23876

merged 2 commits into from
Jul 12, 2022

Conversation

layershifter
Copy link
Member

New Behavior

@fluentui/react-table package is created.

@github-actions github-actions bot added this to the July Project Cycle Q3 2022 milestone Jul 12, 2022
@layershifter layershifter marked this pull request as ready for review July 12, 2022 15:58
@layershifter layershifter requested review from a team, JustSlone and jurokapsiar as code owners July 12, 2022 15:58
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 12, 2022 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1c5c8d9:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

fabricteam commented Jul 12, 2022 •
edited
Loading

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
global-context
createContext		 533 B
341 B
global-context
createContextSelector		 554 B
348 B
priority-overflow
createOverflowManager		 2.936 kB
1.212 kB
react-accordion
Accordion (including children components)		 77.879 kB
23.679 kB
react-alert
Alert		 80.938 kB
20.342 kB
react-avatar
Avatar		 47.36 kB
13.625 kB
react-avatar
AvatarGroup		 137.34 kB
40.837 kB
react-avatar
AvatarGroupItem		 67.075 kB
18.96 kB
react-badge
Badge		 22.494 kB
7.157 kB
react-badge
CounterBadge		 23.397 kB
7.449 kB
react-badge
PresenceBadge		 23.947 kB
7.022 kB
react-button
Button		 35.704 kB
9.499 kB
react-button
CompoundButton		 42.777 kB
10.733 kB
react-button
MenuButton		 38.322 kB
10.363 kB
react-button
SplitButton		 45.655 kB
11.71 kB
react-button
ToggleButton		 50.929 kB
10.919 kB
react-card
Card - All		 66.431 kB
19.01 kB
react-card
Card		 62.113 kB
17.911 kB
react-card
CardFooter		 8.461 kB
3.555 kB
react-card
CardHeader		 9.504 kB
3.896 kB
react-card
CardPreview		 8.562 kB
3.61 kB
react-combobox
Combobox (including child components)		 73.82 kB
23.907 kB
react-combobox
Dropdown (including child components)		 73.333 kB
23.901 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover		 189.197 kB
52.147 kB
react-components
react-components: FluentProvider & webLightTheme		 31.883 kB
10.516 kB
react-divider
Divider		 16.321 kB
5.837 kB
react-image
Image		 10.68 kB
4.215 kB
react-input
Input		 22.861 kB
7.512 kB
react-label
Label		 9.238 kB
3.815 kB
react-link
Link		 12.082 kB
4.88 kB
react-menu
Menu (including children components)		 116.818 kB
35.483 kB
react-menu
Menu (including selectable components)		 120.017 kB
35.967 kB
react-overflow
hooks only		 10.839 kB
4.146 kB
react-popover
Popover		 104.939 kB
31.97 kB
react-portal
Portal		 10.033 kB
3.753 kB
react-positioning
usePositioning		 23.854 kB
8.299 kB
react-provider
FluentProvider		 14.76 kB
5.596 kB
react-radio
Radio		 30.481 kB
10.406 kB
react-radio
RadioGroup		 14.319 kB
5.711 kB
react-select
Select		 20.045 kB
7.167 kB
react-slider
Slider		 26.136 kB
8.387 kB
react-spinbutton
SpinButton		 43.53 kB
12.346 kB
react-spinner
Spinner		 19.073 kB
6.308 kB
react-switch
Switch		 26.621 kB
8.596 kB
react-text
Text - Default		 11.572 kB
4.537 kB
react-text
Text - Wrappers		 14.882 kB
4.977 kB
react-textarea
Textarea		 22.228 kB
7.523 kB
react-theme
Single theme token import		 69 B
89 B
react-theme
Teams: all themes		 28.995 kB
6.215 kB
react-theme
Teams: Light theme		 16.973 kB
4.86 kB
react-tooltip
Tooltip		 44.565 kB
15.39 kB
react-utilities
SSRProvider		 189 B
161 B
🤖 This report was generated against db22700e846d3cdca5a10bf21b5a2800dc21c4c8

@fabricteam
Copy link
Collaborator

fabricteam commented Jul 12, 2022 •
edited
Loading

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1264 1254 5000
Button mount 879 883 5000
FluentProvider mount 1589 1598 5000
FluentProviderWithTheme mount 558 557 10
FluentProviderWithTheme virtual-rerender 534 530 10
FluentProviderWithTheme virtual-rerender-with-unmount 564 565 10
MakeStyles mount 1944 1973 50000
SpinButton mount 2388 2422 5000

@size-auditor
Copy link

size-auditor bot commented Jul 12, 2022 •
edited
Loading

Asset size changes

⚠️ Insufficient baseline data to detect size changes

Unable to find bundle size details for Baseline commit: db22700

Possible causes

  • The baseline build db22700 is broken
  • The Size Auditor run for the baseline build db22700 was not triggered

Recommendations

  • Please merge your branch for this Pull request with the latest master build and commit your changes once again

@fabricteam
Copy link
Collaborator

fabricteam commented Jul 12, 2022 •
edited
Loading

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
PortalMinimalPerf.default 179 164 1.09:1
AnimationMinimalPerf.default 561 524 1.07:1
ChatWithPopoverPerf.default 390 363 1.07:1
ListMinimalPerf.default 528 492 1.07:1
AlertMinimalPerf.default 276 260 1.06:1
CarouselMinimalPerf.default 487 459 1.06:1
LayoutMinimalPerf.default 367 351 1.05:1
LabelMinimalPerf.default 379 366 1.04:1
LoaderMinimalPerf.default 680 657 1.04:1
ReactionMinimalPerf.default 361 348 1.04:1
TableManyItemsPerf.default 1938 1867 1.04:1
ChatDuplicateMessagesPerf.default 285 278 1.03:1
ChatMinimalPerf.default 731 710 1.03:1
PopupMinimalPerf.default 636 616 1.03:1
BoxMinimalPerf.default 330 322 1.02:1
DatepickerMinimalPerf.default 5780 5650 1.02:1
DropdownManyItemsPerf.default 688 675 1.02:1
FlexMinimalPerf.default 272 266 1.02:1
GridMinimalPerf.default 323 317 1.02:1
HeaderMinimalPerf.default 340 334 1.02:1
InputMinimalPerf.default 1307 1280 1.02:1
ItemLayoutMinimalPerf.default 1189 1162 1.02:1
RadioGroupMinimalPerf.default 438 431 1.02:1
SegmentMinimalPerf.default 340 332 1.02:1
SplitButtonMinimalPerf.default 4422 4346 1.02:1
TextMinimalPerf.default 331 325 1.02:1
TreeMinimalPerf.default 833 815 1.02:1
CardMinimalPerf.default 557 551 1.01:1
DialogMinimalPerf.default 774 765 1.01:1
DropdownMinimalPerf.default 3136 3110 1.01:1
EmbedMinimalPerf.default 4144 4117 1.01:1
MenuMinimalPerf.default 846 838 1.01:1
RefMinimalPerf.default 233 231 1.01:1
SliderMinimalPerf.default 1700 1691 1.01:1
StatusMinimalPerf.default 675 668 1.01:1
TableMinimalPerf.default 384 380 1.01:1
CustomToolbarPrototype.default 2701 2686 1.01:1
FormMinimalPerf.default 403 403 1:1
ImageMinimalPerf.default 368 368 1:1
ListNestedPerf.default 528 528 1:1
RosterPerf.default 1087 1091 1:1
ProviderMergeThemesPerf.default 1244 1248 1:1
IconMinimalPerf.default 600 599 1:1
TextAreaMinimalPerf.default 474 473 1:1
VideoMinimalPerf.default 626 626 1:1
AvatarMinimalPerf.default 181 183 0.99:1
ButtonSlotsPerf.default 543 549 0.99:1
CheckboxMinimalPerf.default 2651 2686 0.99:1
DividerMinimalPerf.default 345 348 0.99:1
HeaderSlotsPerf.default 725 735 0.99:1
ListWith60ListItems.default 593 599 0.99:1
MenuButtonMinimalPerf.default 1677 1700 0.99:1
SkeletonMinimalPerf.default 338 340 0.99:1
ToolbarMinimalPerf.default 923 936 0.99:1
TooltipMinimalPerf.default 1096 1111 0.99:1
AttachmentSlotsPerf.default 1063 1088 0.98:1
ButtonOverridesMissPerf.default 1476 1501 0.98:1
ProviderMinimalPerf.default 392 399 0.98:1
ButtonMinimalPerf.default 152 158 0.96:1
ListCommonPerf.default 604 635 0.95:1
AttachmentMinimalPerf.default 144 153 0.94:1
TreeWith60ListItems.default 153 167 0.92:1
AccordionMinimalPerf.default 137 151 0.91:1

@fabricteam
Copy link
Collaborator

fabricteam commented Jul 12, 2022 •
edited
Loading

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 792 805 5000
Breadcrumb mount 2252 2272 1000
Checkbox mount 2228 2193 5000
CheckboxBase mount 1961 1923 5000
ChoiceGroup mount 3939 3965 5000
ComboBox mount 768 779 1000
CommandBar mount 8847 8897 1000
ContextualMenu mount 9230 9265 1000
DefaultButton mount 950 965 5000
DetailsRow mount 3078 3041 5000
DetailsRowFast mount 3051 3012 5000
DetailsRowNoStyles mount 2905 2890 5000
Dialog mount 2285 2306 1000
DocumentCardTitle mount 161 142 1000
Dropdown mount 2984 2821 5000
FocusTrapZone mount 1610 1603 5000
FocusZone mount 1552 1579 5000
IconButton mount 1393 1368 5000
Label mount 313 334 5000
Layer mount 2550 2523 5000
Link mount 438 443 5000
MenuButton mount 1206 1205 5000
MessageBar mount 1813 1868 5000
Nav mount 2622 2679 1000
OverflowSet mount 983 984 5000
Panel mount 1838 1789 1000
Persona mount 842 830 1000
Pivot mount 1126 1134 1000
PrimaryButton mount 1079 1090 5000
Rating mount 6701 6660 5000
SearchBox mount 1120 1106 5000
Shimmer mount 2232 2221 5000
Slider mount 1696 1684 5000
SpinButton mount 3974 3971 5000
Spinner mount 403 384 5000
SplitButton mount 2466 2469 5000
Stack mount 481 485 5000
StackWithIntrinsicChildren mount 1891 1861 5000
StackWithTextChildren mount 4652 4658 5000
SwatchColorPicker mount 9008 9085 5000
TagPicker mount 2035 2028 5000
TeachingBubble mount 69650 70741 5000
Text mount 405 403 5000
TextField mount 1132 1184 5000
ThemeProvider mount 942 938 5000
ThemeProvider virtual-rerender 579 595 5000
ThemeProvider virtual-rerender-with-unmount 1417 1436 5000
Toggle mount 707 717 5000
buttonNative mount 96 112 5000

@ling1726 ling1726 enabled auto-merge (squash) July 12, 2022 16:32
@ling1726 ling1726 merged commit 857e45b into microsoft:master Jul 12, 2022
@ling1726 ling1726 mentioned this pull request Jul 19, 2022
Closed
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ling1726 ling1726 ling1726 approved these changes

@spmonahan spmonahan spmonahan approved these changes

@JustSlone JustSlone Awaiting requested review from JustSlone JustSlone is a code owner

@jurokapsiar jurokapsiar Awaiting requested review from jurokapsiar jurokapsiar is a code owner

Assignees

@spmonahan spmonahan

Labels
None yet
Projects
None yet
Milestone
July Project Cycle Q3 2022
Development

Successfully merging this pull request may close these issues.
4 participants
@layershifter @fabricteam @ling1726 @spmonahan