Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image: update stories to import from @fluentui/react-components #23863

Merged

Conversation

TristanWatanabe
Copy link
Member

Changes

  • updates react-image stories to import from @fluentui/react-components package suite to demonstrate best practices to users.
  • Fixes automatically applied by new no-restricted-imports rule.

Part of #23846

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 11, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ab7e6a1:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

fabricteam commented Jul 11, 2022

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
189.182 kB
52.141 kB
react-components
react-components: FluentProvider & webLightTheme
31.883 kB
10.516 kB
react-image
Image
10.68 kB
4.215 kB
🤖 This report was generated against d1f223054dba804964e010518ec0d09dbca2c584

@fabricteam
Copy link
Collaborator

fabricteam commented Jul 11, 2022

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1567 1556 5000
Button mount 1073 1067 5000
FluentProvider mount 2089 2105 5000
FluentProviderWithTheme mount 726 723 10
FluentProviderWithTheme virtual-rerender 704 693 10
FluentProviderWithTheme virtual-rerender-with-unmount 756 747 10
MakeStyles mount 2281 2303 50000
SpinButton mount 3077 3107 5000

@size-auditor
Copy link

size-auditor bot commented Jul 11, 2022

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: d1f223054dba804964e010518ec0d09dbca2c584 (build)

@TristanWatanabe TristanWatanabe marked this pull request as ready for review July 11, 2022 19:32
@TristanWatanabe TristanWatanabe requested a review from a team as a code owner July 11, 2022 19:32
@TristanWatanabe TristanWatanabe merged commit a2c7f88 into microsoft:master Jul 12, 2022
@TristanWatanabe TristanWatanabe deleted the image-import-from-v9-suite branch July 12, 2022 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants