v9 Website: Organize left navigation, add theme entries #23742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 495b58a:
|
📊 Bundle size reportUnchanged fixtures
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 9d99c66f0a0fedc1757ea44accc09f9c07d5845a (build) |
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1296 | 1306 | 5000 | |
| Button | mount | 910 | 915 | 5000 | |
| FluentProvider | mount | 1771 | 2298 | 5000 | |
| FluentProviderWithTheme | mount | 609 | 606 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 584 | 588 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 627 | 622 | 10 | |
| MakeStyles | mount | 1930 | 1928 | 50000 | |
| SpinButton | mount | 2603 | 2681 | 5000 |
smhigley
approved these changes
Jun 28, 2022
behowell
approved these changes
Jun 29, 2022
khmakoto
approved these changes
Jun 29, 2022
| @@ -0,0 +1,7 @@ | |||
| { | |||
| "type": "none", | |||
| "comment": "Organize left navigation, add theme entries", | |||
There was a problem hiding this comment.
Suggested change
| "comment": "Organize left navigation, add theme entries", | |
| "comment": "docs: Organize left navigation, add theme entries.", |
| @@ -0,0 +1,7 @@ | |||
| { | |||
| "type": "none", | |||
| "comment": "Organize left navigation, add theme entries", | |||
There was a problem hiding this comment.
Suggested change
| "comment": "Organize left navigation, add theme entries", | |
| "comment": "docs: Organize left navigation, add theme entries.", |
| @@ -0,0 +1,7 @@ | |||
| { | |||
| "type": "none", | |||
| "comment": "Organize left navigation, add theme entries", | |||
There was a problem hiding this comment.
Suggested change
| "comment": "Organize left navigation, add theme entries", | |
| "comment": "docs: Organize left navigation, add theme entries.", |
ling1726
reviewed
Jul 1, 2022
| @@ -11,7 +11,7 @@ export { Color } from './BadgeColor.stories'; | |||
| export { Icon } from './BadgeIcon.stories'; | |||
|
|
|||
| export default { | |||
| title: 'Components/Badge', | |||
| title: 'Components/Badge/Badge', | |||
There was a problem hiding this comment.
is it possible to have these component folders expanded by default?
ling1726
approved these changes
Jul 1, 2022
github-actions
bot
modified the milestones:
June Project Cycle Q2 2022,
July Project Cycle Q3 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created component groups for related components that should live together (rather than relying on flaky relative links)
Created 3 different pages for theme content because it collapsed to one page with new index approach.
fixes #23264
Before:
After: