Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(v9): Bump all packages to beta #20106

Merged
merged 2 commits into from
Oct 6, 2021
Merged

feat(v9): Bump all packages to beta #20106

merged 2 commits into from
Oct 6, 2021

Conversation

ling1726
Copy link
Member

@ling1726 ling1726 commented Oct 5, 2021

Bumps all v9 packages to 9.0.0-beta.0

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ yarn change

Description of changes

(give an overview)

Focus areas to test

(optional)

@fabricteam
Copy link
Collaborator

fabricteam commented Oct 5, 2021 •
edited
Loading

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-accordion
Accordion (including children components)		 57.532 kB
18.112 kB
react-avatar
Avatar		 54.953 kB
15.667 kB
react-badge
Badge		 23.182 kB
6.986 kB
react-badge
CounterBadge		 25.642 kB
7.682 kB
react-badge
PresenseBadge		 237 B
177 B
react-button
Button		 25.501 kB
7.738 kB
react-button
CompoundButton		 30.758 kB
8.689 kB
react-button
MenuButton		 27.526 kB
8.413 kB
react-button
SplitButton		 33.637 kB
9.597 kB
react-button
ToggleButton		 34.727 kB
8.39 kB
react-card
Card - All		 13.471 kB
5.068 kB
react-card
Card		 9.317 kB
3.925 kB
react-card
CardFooter		 8.468 kB
3.557 kB
react-card
CardHeader		 9.695 kB
3.99 kB
react-card
CardPreview		 8.783 kB
3.741 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover		 169.173 kB
48.002 kB
react-components
react-components: FluentProvider & webLightTheme		 32.188 kB
10.658 kB
react-divider
Divider		 15.342 kB
5.585 kB
react-image
Image		 9.771 kB
3.975 kB
react-input
Input		 31.319 kB
11.305 kB
react-label
Label		 8.952 kB
3.708 kB
react-link
Link		 11.646 kB
4.699 kB
react-make-styles
makeStaticStyles (runtime)		 7.59 kB
3.321 kB
react-make-styles
makeStyles + mergeClasses (runtime)		 22.175 kB
8.366 kB
react-make-styles
makeStyles + mergeClasses (build time)		 2.558 kB
1.204 kB
react-menu
Menu (including children components)		 105.789 kB
32.202 kB
react-menu
Menu (including selectable components)		 108.065 kB
32.575 kB
react-popover
Popover		 101.153 kB
30.37 kB
react-portal
Portal		 6.725 kB
2.237 kB
react-positioning
usePopper		 23.145 kB
7.942 kB
react-provider
FluentProvider		 15.147 kB
5.573 kB
react-slider
RangedSlider		 41.41 kB
11.97 kB
react-slider
Slider		 34.788 kB
10.855 kB
react-switch
Switch		 26.606 kB
8.557 kB
react-text
Text - Default		 11.338 kB
4.418 kB
react-text
Text - Wrappers		 14.407 kB
4.724 kB
react-theme
Teams: all themes		 25.712 kB
6.17 kB
react-theme
Teams: Light theme		 17.215 kB
5.116 kB
react-tooltip
Tooltip		 45.543 kB
15.541 kB
react-utilities
SSRProvider		 213 B
170 B
🤖 This report was generated against 57d7a963289d7a8639b2c0c58065441599fdde1b

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 5, 2021 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6215c44:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Oct 5, 2021 •
edited
Loading

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 8df3ce7b4d72bc2a155b93a6a35c13d624432f7c (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Oct 5, 2021 •
edited
Loading

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 732 790 5000
BaseButton mount 770 692 5000
Breadcrumb mount 2248 2076 1000
ButtonNext mount 437 440 5000
Checkbox mount 1335 1283 5000
CheckboxBase mount 1008 1106 5000
ChoiceGroup mount 3867 3900 5000
ComboBox mount 793 779 1000
CommandBar mount 8590 8630 1000
ContextualMenu mount 5372 5379 1000
DefaultButton mount 999 987 5000
DetailsRow mount 2998 3200 5000
DetailsRowFast mount 3204 3146 5000
DetailsRowNoStyles mount 3031 2869 5000
Dialog mount 2136 1980 1000
DocumentCardTitle mount 135 141 1000
Dropdown mount 2743 2565 5000
FluentProviderNext mount 2765 2884 5000
FluentProviderWithTheme mount 177 179 10
FluentProviderWithTheme virtual-rerender 82 80 10
FluentProviderWithTheme virtual-rerender-with-unmount 182 215 10
FocusTrapZone mount 1407 1411 5000
FocusZone mount 1506 1441 5000
IconButton mount 1382 1348 5000
Label mount 298 309 5000
Layer mount 2447 2460 5000
Link mount 411 405 5000
MakeStyles mount 1510 1557 50000
MenuButton mount 1141 1242 5000
MessageBar mount 1590 1749 5000
Nav mount 2680 2753 1000
OverflowSet mount 950 967 5000
Panel mount 1967 1839 1000
Persona mount 669 706 1000
Pivot mount 1210 1142 1000
PrimaryButton mount 992 1002 5000
Rating mount 6323 6383 5000
SearchBox mount 1127 1130 5000
Shimmer mount 2087 2165 5000
Slider mount 1539 1542 5000
SpinButton mount 4009 4092 5000
Spinner mount 350 376 5000
SplitButton mount 2537 2699 5000
Stack mount 409 379 5000
StackWithIntrinsicChildren mount 1427 1420 5000
StackWithTextChildren mount 3973 3868 5000
SwatchColorPicker mount 8885 8835 5000
Tabs mount 1224 1153 1000
TagPicker mount 2211 2217 5000
TeachingBubble mount 10733 10901 5000
Text mount 339 336 5000
TextField mount 1157 1182 5000
ThemeProvider mount 1015 1018 5000
ThemeProvider virtual-rerender 473 538 5000
ThemeProvider virtual-rerender-with-unmount 1472 1495 5000
Toggle mount 715 654 5000
buttonNative mount 112 122 5000

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AttachmentMinimalPerf.default 146 121 1.21:1
RefMinimalPerf.default 208 175 1.19:1
TableMinimalPerf.default 355 298 1.19:1
ChatWithPopoverPerf.default 341 290 1.18:1
SegmentMinimalPerf.default 300 257 1.17:1
CardMinimalPerf.default 469 410 1.14:1
IconMinimalPerf.default 543 479 1.13:1
LoaderMinimalPerf.default 598 535 1.12:1
SkeletonMinimalPerf.default 297 268 1.11:1
BoxMinimalPerf.default 302 275 1.1:1
DropdownManyItemsPerf.default 573 519 1.1:1
TooltipMinimalPerf.default 878 796 1.1:1
ProviderMinimalPerf.default 944 867 1.09:1
DialogMinimalPerf.default 642 595 1.08:1
MenuMinimalPerf.default 711 660 1.08:1
AlertMinimalPerf.default 221 206 1.07:1
AnimationMinimalPerf.default 369 344 1.07:1
ToolbarMinimalPerf.default 795 741 1.07:1
ImageMinimalPerf.default 325 311 1.05:1
InputMinimalPerf.default 1153 1101 1.05:1
ListNestedPerf.default 460 439 1.05:1
AvatarMinimalPerf.default 170 163 1.04:1
DatepickerMinimalPerf.default 4679 4505 1.04:1
DropdownMinimalPerf.default 2745 2636 1.04:1
RadioGroupMinimalPerf.default 391 376 1.04:1
LabelMinimalPerf.default 329 320 1.03:1
MenuButtonMinimalPerf.default 1341 1306 1.03:1
PortalMinimalPerf.default 154 150 1.03:1
ChatMinimalPerf.default 556 543 1.02:1
DividerMinimalPerf.default 311 306 1.02:1
ListCommonPerf.default 538 526 1.02:1
ReactionMinimalPerf.default 326 319 1.02:1
StatusMinimalPerf.default 571 561 1.02:1
TextAreaMinimalPerf.default 418 409 1.02:1
ButtonSlotsPerf.default 475 468 1.01:1
FlexMinimalPerf.default 256 253 1.01:1
LayoutMinimalPerf.default 321 318 1.01:1
CustomToolbarPrototype.default 3422 3376 1.01:1
ItemLayoutMinimalPerf.default 1024 1029 1:1
HeaderMinimalPerf.default 304 308 0.99:1
CheckboxMinimalPerf.default 2292 2327 0.98:1
EmbedMinimalPerf.default 3527 3610 0.98:1
FormMinimalPerf.default 331 337 0.98:1
HeaderSlotsPerf.default 621 633 0.98:1
ListWith60ListItems.default 545 556 0.98:1
PopupMinimalPerf.default 492 503 0.98:1
AccordionMinimalPerf.default 128 132 0.97:1
TreeMinimalPerf.default 661 679 0.97:1
AttachmentSlotsPerf.default 830 867 0.96:1
ButtonOverridesMissPerf.default 1357 1413 0.96:1
CarouselMinimalPerf.default 369 386 0.96:1
RosterPerf.default 875 916 0.96:1
SplitButtonMinimalPerf.default 3454 3597 0.96:1
VideoMinimalPerf.default 488 508 0.96:1
ButtonMinimalPerf.default 139 147 0.95:1
ListMinimalPerf.default 399 421 0.95:1
ChatDuplicateMessagesPerf.default 231 247 0.94:1
ProviderMergeThemesPerf.default 1345 1464 0.92:1
TableManyItemsPerf.default 1462 1590 0.92:1
SliderMinimalPerf.default 1273 1418 0.9:1
GridMinimalPerf.default 256 288 0.89:1
TextMinimalPerf.default 259 295 0.88:1
TreeWith60ListItems.default 137 158 0.87:1

andrefcdias
andrefcdias reviewed Oct 5, 2021
View reviewed changes
Copy link
Contributor

@andrefcdias andrefcdias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should react-card be bumped to Beta? IMO we should keep this as alpha as there's still plenty of functionality missing as well as tests.

@ling1726
Copy link
Member Author

ling1726 commented Oct 5, 2021

Should react-card be bumped to Beta? IMO we should keep this as alpha as there's still plenty of functionality missing as well as tests.

@andrefcdias as mentioned in the RFC we cannot support both prerelease tags with fixed versions. Therefore the appropriate way to expose not-yet-ready components is to do so through the /unstable deep export

@ling1726 ling1726 marked this pull request as ready for review October 6, 2021 09:02
@layershifter layershifter merged commit 5553164 into microsoft:master Oct 6, 2021
@andrefcdias
Copy link
Contributor

As a user, that seems misleading to me but I understand. Any place we can make this clear for the public?

@khmakoto
Copy link
Member

khmakoto commented Oct 6, 2021

@andrefcdias maybe in the storybook docs or in the wiki?

@ecraig12345
Copy link
Member

I just realized, we should probably NOT have bumped the unreleased packages to beta. For example, react-slider probably ought to be alpha since it's not ready for beta.

@ecraig12345
Copy link
Member

Amending previous comment after reading the discussion (sorry): I had missed the part about having all the same versions when reviewing the RFC.

Even though all new package will have the beta prerelease tag, our recommendation to users should still be to use the @fluentui/react-components package uniquely. Then we should clearly document/explain for our partners that unstable components can be used through these deep imports. If new components are released to the same package, there is no obvious reason to consume components as separate packages and the solution to consuming a new component is to bump the suite package.

I'd probably still prefer to have the unstable components use -alpha.N if we can think of any way to do it, because that's much clearer in case someone does happen upon the package individually. Was going to say potentially we could have N match for alpha and beta (so -alpha.2 would match -beta.2) except that we already have a bunch of alpha versions of some packages, so we'd have to start N from 200 or something.

If we can't preserve alpha versions for packages that are in alpha, we should ensure that the individual package readmes or something clearly indicate that the component is still unstable. Another possibility is bringing back the badges idea from #16772 (the badges would link out to a wiki page).

@ecraig12345 ecraig12345 mentioned this pull request Oct 7, 2021
Merged
ling1726 added a commit to ling1726/fluentui-storybook-addons that referenced this pull request Oct 7, 2021
@ling1726
fix(version): Use 9.0.0-beta as version matcher for Fluent UI
1103913 
Follow up from microsoft/fluentui#20106
@ling1726 ling1726 mentioned this pull request Oct 7, 2021
Merged
layershifter pushed a commit to microsoft/fluentui-storybook-addons that referenced this pull request Oct 7, 2021
@ling1726
fix(version): Use 9.0.0-beta as version matcher for Fluent UI (#7)
b22cfd1 
* fix(version): Use `9.0.0-beta` as version matcher for Fluent UI

Follow up from microsoft/fluentui#20106

* update dep

* update versions
mlp73 pushed a commit to mlp73/fluentui that referenced this pull request Jan 17, 2022
@ling1726
feat(v9): Bump all packages to beta (microsoft#20106)
989c930 
* re-bump after merging master

* Change files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrefcdias andrefcdias andrefcdias left review comments

@khmakoto khmakoto khmakoto approved these changes

@miroslavstastny miroslavstastny miroslavstastny approved these changes

@layershifter layershifter layershifter approved these changes

@behowell behowell Awaiting requested review from behowell

@czearing czearing Awaiting requested review from czearing

@dzearing dzearing Awaiting requested review from dzearing

@ecraig12345 ecraig12345 Awaiting requested review from ecraig12345

@GeoffCoxMSFT GeoffCoxMSFT Awaiting requested review from GeoffCoxMSFT

Assignees

@bsunderhus bsunderhus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@ling1726 @fabricteam @andrefcdias @khmakoto @ecraig12345 @miroslavstastny @layershifter @bsunderhus