Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test out React 17 #16886

Closed
wants to merge 10 commits into from
Closed

Test out React 17 #16886

wants to merge 10 commits into from

Conversation

ecraig12345
Copy link
Member

Pull request checklist

Description of changes

Try out React 17 in tests.

This is NOT INTENDED FOR MERGE currently, just testing.

@DustyTheBot
Copy link

Fails
🚫

Non-approved dependencies were detected. It is necessary to obtain approvals and register them in the approvedPackages file before merge.

Non-approved dependencies are detected.

The following package version constraints are missing an approved candidate:

failed constraints approved candidates
[email protected] [email protected]
scheduler@^0.20.1 [email protected], [email protected]

Generated by 🚫 dangerJS against 8bcb138

@ecraig12345 ecraig12345 requested a review from xugao February 9, 2021 08:31
@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 9, 2021 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a9de72a:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration
codesandbox-react-northstar-template Configuration

@size-auditor
Copy link

size-auditor bot commented Feb 9, 2021 •
edited
Loading

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: e5800d7b3b471be19f448a7bfe3d9c7ca232dcf8 (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Feb 9, 2021 •
edited
Loading

Perf Analysis

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 964 1016 5000 Possible regression
BaseButton mount 1227 1077 5000 Possible regression
Breadcrumb mount 50476 54228 5000 Possible regression
ButtonNext mount 920 783 5000 Possible regression
Checkbox mount 1846 1838 5000 Possible regression
CheckboxBase mount 1536 2316 5000 Possible regression
ChoiceGroup mount 5768 5634 5000 Possible regression
ComboBox mount 1141 1075 1000 Possible regression
CommandBar mount 12288 11526 1000 Possible regression
ContextualMenu mount 8130 7811 1000 Possible regression
DefaultButton mount 1481 1422 5000 Possible regression
DetailsRow mount 4265 4086 5000 Possible regression
DetailsRowFast mount 4304 4032 5000 Possible regression
DetailsRowNoStyles mount 4241 4001 5000 Possible regression
Dialog mount 1725 2079 1000 Possible regression
DocumentCardTitle mount 2135 2232 1000 Possible regression
Dropdown mount 4163 3976 5000 Possible regression
FocusTrapZone mount 2205 2038 5000 Possible regression
FocusZone mount 2185 2139 5000 Possible regression
IconButton mount 2328 2112 5000 Possible regression
Label mount 380 403 5000 Possible regression
Layer mount 2355 3401 5000 Possible regression
Link mount 604 555 5000 Possible regression
MakeStyles mount 2248 2294 50000 Possible regression
MenuButton mount 1813 1735 5000 Possible regression
MessageBar mount 2428 2665 5000 Possible regression
Nav mount 4253 4275 1000 Possible regression
OverflowSet mount 1385 1238 5000 Possible regression
Panel mount 1833 2011 1000 Possible regression
Persona mount 1069 1048 1000 Possible regression
Pivot mount 1652 1731 1000 Possible regression
PrimaryButton mount 1527 1546 5000 Possible regression
Rating mount 9379 9252 5000 Possible regression
SearchBox mount 1606 1698 5000 Possible regression
Shimmer mount 3211 3641 5000 Possible regression
Slider mount 2446 2290 5000 Possible regression
SpinButton mount 6059 5944 5000 Possible regression
Spinner mount 495 484 5000 Possible regression
SplitButton mount 3732 3759 5000 Possible regression
Stack mount 574 580 5000 Possible regression
StackWithIntrinsicChildren mount 1734 1613 5000 Possible regression
StackWithTextChildren mount 5894 5107 5000 Possible regression
SwatchColorPicker mount 13279 12338 5000 Possible regression
Tabs mount 1790 1672 1000 Possible regression
TagPicker mount 3342 3328 5000 Possible regression
TeachingBubble mount 14578 67530 5000 Possible regression
Text mount 507 567 5000 Possible regression
TextField mount 2039 1904 5000 Possible regression
ThemeProvider mount 1795 1536 5000 Possible regression
ThemeProvider virtual-rerender 690 826 5000 Possible regression
ThemeProviderNext mount 2560 2317 5000 Possible regression
Toggle mount 998 968 5000 Possible regression
buttonNative mount 176 112 5000 Possible regression
All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 964 1016 5000 Possible regression
BaseButton mount 1227 1077 5000 Possible regression
Breadcrumb mount 50476 54228 5000 Possible regression
ButtonNext mount 920 783 5000 Possible regression
Checkbox mount 1846 1838 5000 Possible regression
CheckboxBase mount 1536 2316 5000 Possible regression
ChoiceGroup mount 5768 5634 5000 Possible regression
ComboBox mount 1141 1075 1000 Possible regression
CommandBar mount 12288 11526 1000 Possible regression
ContextualMenu mount 8130 7811 1000 Possible regression
DefaultButton mount 1481 1422 5000 Possible regression
DetailsRow mount 4265 4086 5000 Possible regression
DetailsRowFast mount 4304 4032 5000 Possible regression
DetailsRowNoStyles mount 4241 4001 5000 Possible regression
Dialog mount 1725 2079 1000 Possible regression
DocumentCardTitle mount 2135 2232 1000 Possible regression
Dropdown mount 4163 3976 5000 Possible regression
FocusTrapZone mount 2205 2038 5000 Possible regression
FocusZone mount 2185 2139 5000 Possible regression
IconButton mount 2328 2112 5000 Possible regression
Label mount 380 403 5000 Possible regression
Layer mount 2355 3401 5000 Possible regression
Link mount 604 555 5000 Possible regression
MakeStyles mount 2248 2294 50000 Possible regression
MenuButton mount 1813 1735 5000 Possible regression
MessageBar mount 2428 2665 5000 Possible regression
Nav mount 4253 4275 1000 Possible regression
OverflowSet mount 1385 1238 5000 Possible regression
Panel mount 1833 2011 1000 Possible regression
Persona mount 1069 1048 1000 Possible regression
Pivot mount 1652 1731 1000 Possible regression
PrimaryButton mount 1527 1546 5000 Possible regression
Rating mount 9379 9252 5000 Possible regression
SearchBox mount 1606 1698 5000 Possible regression
Shimmer mount 3211 3641 5000 Possible regression
Slider mount 2446 2290 5000 Possible regression
SpinButton mount 6059 5944 5000 Possible regression
Spinner mount 495 484 5000 Possible regression
SplitButton mount 3732 3759 5000 Possible regression
Stack mount 574 580 5000 Possible regression
StackWithIntrinsicChildren mount 1734 1613 5000 Possible regression
StackWithTextChildren mount 5894 5107 5000 Possible regression
SwatchColorPicker mount 13279 12338 5000 Possible regression
Tabs mount 1790 1672 1000 Possible regression
TagPicker mount 3342 3328 5000 Possible regression
TeachingBubble mount 14578 67530 5000 Possible regression
Text mount 507 567 5000 Possible regression
TextField mount 2039 1904 5000 Possible regression
ThemeProvider mount 1795 1536 5000 Possible regression
ThemeProvider virtual-rerender 690 826 5000 Possible regression
ThemeProviderNext mount 2560 2317 5000 Possible regression
Toggle mount 998 968 5000 Possible regression
buttonNative mount 176 112 5000 Possible regression

Perf Analysis (Fluent)

Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🦄 Avatar.Fluent 0.25 0.57 0.44:1 2000 492
🦄 Button.Fluent 0.14 0.23 0.61:1 5000 721
🔧 Checkbox.Fluent 0.73 0.47 1.55:1 1000 728
🦄 Dialog.Fluent 0.2 0.3 0.67:1 5000 1020
🔧 Dropdown.Fluent 3.4 0.7 4.86:1 1000 3396
🔧 Icon.Fluent 0.21 0.07 3:1 5000 1037
🦄 Image.Fluent 0.1 0.23 0.43:1 5000 523
🔧 Slider.Fluent 1.75 0.53 3.3:1 1000 1753
🔧 Text.Fluent 0.09 0.04 2.25:1 5000 463
🦄 Tooltip.Fluent 0.13 1.91 0.07:1 5000 660

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
RosterPerf.default 3545 1824 1.94:1
AttachmentMinimalPerf.default 292 187 1.56:1
VideoMinimalPerf.default 1059 828 1.28:1
Avatar.Fluent 492 400 1.23:1
LabelMinimalPerf.default 644 528 1.22:1
ButtonMinimalPerf.default 267 223 1.2:1
DividerMinimalPerf.default 569 479 1.19:1
Icon.Fluent 1037 891 1.16:1
ButtonOverridesMissPerf.default 2174 1911 1.14:1
ChatWithPopoverPerf.default 526 481 1.09:1
FlexMinimalPerf.default 404 370 1.09:1
StatusMinimalPerf.default 972 888 1.09:1
TableManyItemsPerf.default 2766 2529 1.09:1
ListWith60ListItems.default 805 747 1.08:1
SegmentMinimalPerf.default 478 442 1.08:1
ButtonSlotsPerf.default 758 711 1.07:1
TreeWith60ListItems.default 253 236 1.07:1
DropdownManyItemsPerf.default 898 851 1.06:1
GridMinimalPerf.default 453 428 1.06:1
PopupMinimalPerf.default 830 783 1.06:1
PortalMinimalPerf.default 191 180 1.06:1
Image.Fluent 523 496 1.05:1
CustomToolbarPrototype.default 4155 3982 1.04:1
Slider.Fluent 1753 1681 1.04:1
AccordionMinimalPerf.default 208 202 1.03:1
ImageMinimalPerf.default 581 564 1.03:1
Button.Fluent 721 697 1.03:1
DatepickerMinimalPerf.default 59157 57915 1.02:1
EmbedMinimalPerf.default 4939 4847 1.02:1
ProviderMinimalPerf.default 999 984 1.02:1
Tooltip.Fluent 660 648 1.02:1
ButtonUseCssNestingPerf.default 1269 1262 1.01:1
ChatMinimalPerf.default 792 784 1.01:1
LoaderMinimalPerf.default 927 915 1.01:1
BoxMinimalPerf.default 501 501 1:1
HeaderMinimalPerf.default 491 496 0.99:1
TableMinimalPerf.default 520 523 0.99:1
CheckboxMinimalPerf.default 3459 3532 0.98:1
HeaderSlotsPerf.default 1010 1027 0.98:1
SplitButtonMinimalPerf.default 4753 4859 0.98:1
IconMinimalPerf.default 886 901 0.98:1
Dialog.Fluent 1020 1040 0.98:1
Text.Fluent 463 471 0.98:1
InputMinimalPerf.default 1413 1453 0.97:1
ProviderMergeThemesPerf.default 1832 1891 0.97:1
RefMinimalPerf.default 276 285 0.97:1
DropdownMinimalPerf.default 3412 3571 0.96:1
ItemLayoutMinimalPerf.default 1578 1650 0.96:1
TextMinimalPerf.default 456 476 0.96:1
Dropdown.Fluent 3396 3531 0.96:1
CarouselMinimalPerf.default 618 653 0.95:1
TreeMinimalPerf.default 993 1048 0.95:1
LayoutMinimalPerf.default 523 556 0.94:1
ListMinimalPerf.default 642 682 0.94:1
MenuButtonMinimalPerf.default 1828 1945 0.94:1
Checkbox.Fluent 728 773 0.94:1
ToolbarMinimalPerf.default 1253 1343 0.93:1
TooltipMinimalPerf.default 1068 1151 0.93:1
AnimationMinimalPerf.default 489 531 0.92:1
ChatDuplicateMessagesPerf.default 423 461 0.92:1
SliderMinimalPerf.default 1749 1898 0.92:1
TextAreaMinimalPerf.default 670 725 0.92:1
CardMinimalPerf.default 665 731 0.91:1
AttachmentSlotsPerf.default 1427 1589 0.9:1
SkeletonMinimalPerf.default 504 558 0.9:1
DialogMinimalPerf.default 924 1033 0.89:1
RadioGroupMinimalPerf.default 534 600 0.89:1
ListCommonPerf.default 847 962 0.88:1
FormMinimalPerf.default 530 606 0.87:1
AvatarMinimalPerf.default 274 320 0.86:1
MenuMinimalPerf.default 1040 1286 0.81:1
ButtonUseCssPerf.default 1053 1337 0.79:1
ReactionMinimalPerf.default 501 674 0.74:1
AlertMinimalPerf.default 347 507 0.68:1
ListNestedPerf.default 740 1264 0.59:1

@ecraig12345 ecraig12345 force-pushed the react-17 branch 2 times, most recently from 3b34093 to cc95d6f Compare February 12, 2021 08:58
@ecraig12345 ecraig12345 requested a review from Hotell February 12, 2021 08:59
This was referenced Feb 18, 2021
Merged
Closed
Merged
@ecraig12345 ecraig12345 mentioned this pull request Mar 1, 2021
Closed
5 tasks
@msft-fluent-ui-bot
Copy link
Collaborator

Because this pull request has not had activity for over 150 days, we're automatically closing it for house-keeping purposes.

The pull request will still be available for reference. If it's still relevant to merge at some point, you can reopen or make a new version based on the latest code.

@msft-fluent-ui-bot msft-fluent-ui-bot added the Resolution: Soft Close Soft closing inactive issues over a certain period label Sep 28, 2021
@ecraig12345 ecraig12345 removed the Resolution: Soft Close Soft closing inactive issues over a certain period label Sep 28, 2021
@ecraig12345 ecraig12345 reopened this Sep 28, 2021
@ecraig12345 ecraig12345 mentioned this pull request Oct 15, 2021
Closed
@TristanWatanabe TristanWatanabe mentioned this pull request Nov 4, 2021
Closed
@ecraig12345 ecraig12345 closed this Dec 9, 2021
@ecraig12345 ecraig12345 mentioned this pull request Dec 14, 2021
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@layershifter layershifter Awaiting requested review from layershifter

@xugao xugao Awaiting requested review from xugao

@Hotell Hotell Awaiting requested review from Hotell

@dzearing dzearing Awaiting requested review from dzearing dzearing will be requested when the pull request is marked ready for review dzearing is a code owner

@behowell behowell Awaiting requested review from behowell behowell will be requested when the pull request is marked ready for review behowell is a code owner

@khmakoto khmakoto Awaiting requested review from khmakoto khmakoto will be requested when the pull request is marked ready for review khmakoto is a code owner

@spmonahan spmonahan Awaiting requested review from spmonahan spmonahan will be requested when the pull request is marked ready for review spmonahan is a code owner

@ThomasMichon ThomasMichon Awaiting requested review from ThomasMichon ThomasMichon will be requested when the pull request is marked ready for review ThomasMichon is a code owner

Assignees

@joschect joschect

Labels
React 17 Status: Do Not Merge 🚫
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ecraig12345 @DustyTheBot @fabricteam @msft-fluent-ui-bot @joschect @xugao