Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update filetype cdn version v8 #16539

Merged
merged 2 commits into from
Feb 19, 2021
Merged

update filetype cdn version v8 #16539

merged 2 commits into from
Feb 19, 2021

Conversation

bigbadcapers
Copy link
Contributor

Pull request checklist

@bigbadcapers bigbadcapers requested a review from Jahnp as a code owner January 19, 2021 20:08
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 62e657a:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration
codesandbox-react-northstar-template Configuration

@fabricteam
Copy link
Collaborator

Perf Analysis

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 863 871 5000
BaseButtonCompat mount 1017 952 5000
Breadcrumb mount 42603 42393 5000
Checkbox mount 1604 1587 5000
CheckboxBase mount 1329 1320 5000
ChoiceGroup mount 4915 4902 5000
ComboBox mount 975 957 1000
CommandBar mount 10116 10067 1000
ContextualMenu mount 6080 6124 1000
DefaultButtonCompat mount 1209 1228 5000
DetailsRow mount 3741 3768 5000
DetailsRowFast mount 3735 3767 5000
DetailsRowNoStyles mount 3568 3521 5000
Dialog mount 1515 1530 1000
DocumentCardTitle mount 1805 1806 1000
Dropdown mount 3390 3389 5000
FocusTrapZone mount 1807 1825 5000
FocusZone mount 1820 1812 5000
IconButtonCompat mount 1829 1863 5000
Label mount 339 360 5000
Layer mount 1824 1820 5000
Link mount 485 453 5000
MakeStyles mount 1933 1914 50000
MenuButtonCompat mount 1542 1561 5000
MessageBar mount 1935 2008 5000
Nav mount 3357 3283 1000
OverflowSet mount 1060 1019 5000
Panel mount 1487 1458 1000
Persona mount 883 885 1000
Pivot mount 1447 1395 1000
PrimaryButtonCompat mount 1293 1336 5000
Rating mount 7872 7897 5000
SearchBox mount 1356 1371 5000
Shimmer mount 2623 2652 5000
Slider mount 1943 1947 5000
SpinButton mount 5143 5091 5000
Spinner mount 434 447 5000
SplitButtonCompat mount 3318 3309 5000
Stack mount 506 528 5000
StackWithIntrinsicChildren mount 1621 1652 5000
StackWithTextChildren mount 4792 4796 5000
SwatchColorPicker mount 10725 10602 5000
Tabs mount 1421 1439 1000
TagPicker mount 2894 2893 5000
TeachingBubble mount 11789 11726 5000
Text mount 419 432 5000
TextField mount 1406 1423 5000
ThemeProvider mount 2166 2126 5000
ThemeProvider virtual-rerender 622 630 5000
Toggle mount 804 799 5000
button mount 698 684 5000
buttonNative mount 110 110 5000

Perf Analysis (Fluent)

Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🦄 Avatar.Fluent 0.19 0.51 0.37:1 2000 378
🦄 Button.Fluent 0.12 0.21 0.57:1 5000 614
🔧 Checkbox.Fluent 0.66 0.34 1.94:1 1000 662
🎯 Dialog.Fluent 0.17 0.23 0.74:1 5000 826
🔧 Dropdown.Fluent 3.06 0.45 6.8:1 1000 3061
🔧 Icon.Fluent 0.15 0.06 2.5:1 5000 746
🦄 Image.Fluent 0.09 0.13 0.69:1 5000 471
🔧 Slider.Fluent 1.63 0.46 3.54:1 1000 1629
🔧 Text.Fluent 0.08 0.03 2.67:1 5000 396
🦄 Tooltip.Fluent 0.12 0.9 0.13:1 5000 600

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AvatarMinimalPerf.default 230 213 1.08:1
Image.Fluent 471 437 1.08:1
ChatWithPopoverPerf.default 489 458 1.07:1
PortalMinimalPerf.default 172 161 1.07:1
ListMinimalPerf.default 550 519 1.06:1
Avatar.Fluent 378 356 1.06:1
CardMinimalPerf.default 620 588 1.05:1
ChatMinimalPerf.default 686 655 1.05:1
GridMinimalPerf.default 394 376 1.05:1
RadioGroupMinimalPerf.default 520 496 1.05:1
RefMinimalPerf.default 243 232 1.05:1
AnimationMinimalPerf.default 460 444 1.04:1
DialogMinimalPerf.default 859 829 1.04:1
DividerMinimalPerf.default 430 412 1.04:1
FlexMinimalPerf.default 340 328 1.04:1
LoaderMinimalPerf.default 778 746 1.04:1
SkeletonMinimalPerf.default 419 404 1.04:1
ToolbarMinimalPerf.default 1073 1033 1.04:1
TooltipMinimalPerf.default 902 870 1.04:1
ReactionMinimalPerf.default 466 452 1.03:1
StatusMinimalPerf.default 806 786 1.03:1
TextAreaMinimalPerf.default 561 547 1.03:1
Tooltip.Fluent 600 582 1.03:1
AttachmentMinimalPerf.default 186 182 1.02:1
DatepickerMinimalPerf.default 49753 48910 1.02:1
DropdownManyItemsPerf.default 784 766 1.02:1
LayoutMinimalPerf.default 457 448 1.02:1
MenuButtonMinimalPerf.default 1680 1653 1.02:1
PopupMinimalPerf.default 732 719 1.02:1
SegmentMinimalPerf.default 403 395 1.02:1
SliderMinimalPerf.default 1642 1612 1.02:1
SplitButtonMinimalPerf.default 4089 4025 1.02:1
IconMinimalPerf.default 720 704 1.02:1
Checkbox.Fluent 662 650 1.02:1
Dropdown.Fluent 3061 3012 1.02:1
CheckboxMinimalPerf.default 2953 2924 1.01:1
ListCommonPerf.default 718 712 1.01:1
ListWith60ListItems.default 678 669 1.01:1
TreeMinimalPerf.default 882 872 1.01:1
TreeWith60ListItems.default 189 187 1.01:1
Button.Fluent 614 610 1.01:1
ButtonUseCssPerf.default 884 888 1:1
FormMinimalPerf.default 486 485 1:1
HeaderSlotsPerf.default 896 894 1:1
InputMinimalPerf.default 1347 1345 1:1
LabelMinimalPerf.default 458 460 1:1
TextMinimalPerf.default 407 406 1:1
Dialog.Fluent 826 827 1:1
Text.Fluent 396 396 1:1
AttachmentSlotsPerf.default 1291 1304 0.99:1
ButtonMinimalPerf.default 195 197 0.99:1
CarouselMinimalPerf.default 507 514 0.99:1
DropdownMinimalPerf.default 2977 2993 0.99:1
EmbedMinimalPerf.default 4262 4285 0.99:1
ItemLayoutMinimalPerf.default 1334 1350 0.99:1
TableManyItemsPerf.default 2223 2254 0.99:1
Icon.Fluent 746 757 0.99:1
BoxMinimalPerf.default 416 425 0.98:1
ButtonOverridesMissPerf.default 1790 1821 0.98:1
ButtonSlotsPerf.default 620 634 0.98:1
ProviderMergeThemesPerf.default 1558 1588 0.98:1
TableMinimalPerf.default 449 460 0.98:1
CustomToolbarPrototype.default 3880 3960 0.98:1
VideoMinimalPerf.default 705 723 0.98:1
ButtonUseCssNestingPerf.default 1125 1157 0.97:1
ChatDuplicateMessagesPerf.default 385 396 0.97:1
HeaderMinimalPerf.default 425 439 0.97:1
ImageMinimalPerf.default 435 449 0.97:1
ProviderMinimalPerf.default 994 1025 0.97:1
Slider.Fluent 1629 1675 0.97:1
AlertMinimalPerf.default 317 329 0.96:1
RosterPerf.default 1290 1350 0.96:1
AccordionMinimalPerf.default 179 188 0.95:1
ListNestedPerf.default 611 642 0.95:1
MenuMinimalPerf.default 920 966 0.95:1

@size-auditor
Copy link

size-auditor bot commented Jan 19, 2021

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: dadc7e0e0bd43d27ced6a6c85a3e353eae686f42 (build)

@bigbadcapers bigbadcapers mentioned this pull request Jan 19, 2021
Merged
2 tasks
@ecraig12345 ecraig12345 merged commit 4011be1 into microsoft:master Feb 19, 2021
@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

joshualamusga1 pushed a commit to joshualamusga1/fluentui that referenced this pull request Feb 25, 2021
@bigbadcapers @joshualamusga1
update filetype cdn version v8 (microsoft#16539)
de2dc3e 
* Updating Fabric CDN url version to fetch latest filetype icons

* Change files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ecraig12345 ecraig12345 ecraig12345 approved these changes

@Jahnp Jahnp Awaiting requested review from Jahnp Jahnp is a code owner

Assignees

@layershifter layershifter

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bigbadcapers @fabricteam @msft-fluent-ui-bot @ecraig12345 @layershifter