fix(react-examples): Change item names to match icon in OverflowSet example #16494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xample (microsoftdesign/fluentui#10282)
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
Asset size changesUnable to find bundle size details for Baseline commit: d6adc18 Possible causes
Recommendations
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 0e8eb08:
|
khmakoto
approved these changes
Jan 19, 2021
|
Hello @khmakoto! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
andrefcdias
added a commit
that referenced
this pull request
Jan 26, 2021
) * fix(react-examples): Add title prop to icons in OverflowSet example (microsoftdesign/fluentui#10284) * Replace title prop for TooltipHost * fix(react-examples): Change item names to match icon in OverflowSet example (#16494) - [x] Addresses an existing issue: Fixes microsoftdesign/fluentui#10282 - [x] Include a change request file using `$ yarn change`: No change files are needed Add descriptive names for the icons used in the OverflowSet Vertical example. Removed unused `icon` props for the `overflowItems` * Update snapshots * revert snapshots * Update just one snapshot * Remove extraneous id on tooltips Add label to overflow button Co-authored-by: Elizabeth Craig <[email protected]>
10 tasks
msft-fluent-ui-bot
pushed a commit
that referenced
this pull request
Feb 2, 2021
#### Pull request checklist - [x] Include a change request file using `$ yarn change` #### Description of changes Aggregate cherry-picking for all my contributions for the `react-examples` package #### Focus areas to test - [x] #16497 - [x] #16496 - [x] #16494 - [x] #16479 - [x] #16430 - [x] #16475 - [x] #16463 - [x] #16495 - [x] #16481
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn change: No change files are neededDescription of changes
Add descriptive names for the icons used in the OverflowSet Vertical example.
Removed unused
iconprops for theoverflowItems