Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(Carousel): pass active index onActiveIndexChange #16118

Merged
merged 4 commits into from
Dec 2, 2020
Merged

chore(Carousel): pass active index onActiveIndexChange #16118

merged 4 commits into from
Dec 2, 2020

Conversation

assuncaocharles
Copy link
Contributor

Pull request checklist

Description of changes

Previously onActiveIndexChange didn't contained the updated activeIndex this PR fixes it.

Focus areas to test

(optional)

@msft-github-bot msft-github-bot added the Fluent UI react-northstar (v0) Work related to Fluent UI V0 label Dec 2, 2020
@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 2, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit bb477e8:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration
codesandbox-react-northstar-template Configuration

@msft-github-bot
Copy link
Contributor

Perf Analysis

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 851 802 5000
BaseButtonCompat mount 888 893 5000
Breadcrumb mount 43108 43285 5000
Checkbox mount 1531 1503 5000
CheckboxBase mount 1278 1251 5000
ChoiceGroup mount 4836 4698 5000
ComboBox mount 1009 971 1000
CommandBar mount 10274 10196 1000
ContextualMenu mount 6392 6281 1000
DefaultButtonCompat mount 1138 1130 5000
DetailsRow mount 3746 3626 5000
DetailsRowFast mount 3608 3725 5000
DetailsRowNoStyles mount 3440 3584 5000
Dialog mount 1485 1428 1000
DocumentCardTitle mount 1932 1796 1000
Dropdown mount 3263 3316 5000
FocusTrapZone mount 1821 1821 5000
FocusZone mount 1853 1841 5000
IconButtonCompat mount 1705 1769 5000
Label mount 337 338 5000
Layer mount 1776 1733 5000
Link mount 445 464 5000
MenuButtonCompat mount 1459 1493 5000
MessageBar mount 2060 1987 5000
Nav mount 3290 3269 1000
OverflowSet mount 1025 1082 5000
Panel mount 1405 1442 1000
Persona mount 874 864 1000
Pivot mount 1396 1443 1000
PrimaryButtonCompat mount 1340 1276 5000
Rating mount 7662 7574 5000
SearchBox mount 1294 1338 5000
Shimmer mount 2616 2577 5000
Slider mount 1912 1955 5000
SpinButton mount 4932 4987 5000
Spinner mount 435 407 5000
SplitButtonCompat mount 3216 3262 5000
Stack mount 486 499 5000
StackWithIntrinsicChildren mount 1525 1580 5000
StackWithTextChildren mount 4467 4507 5000
SwatchColorPicker mount 10279 10203 5000
Tabs mount 1385 1475 1000
TagPicker mount 2932 2814 5000
TeachingBubble mount 11818 11674 5000
Text mount 415 394 5000
TextField mount 1378 1387 5000
ThemeProvider mount 2158 2171 5000
ThemeProvider virtual-rerender 647 651 5000
Toggle mount 785 818 5000
button mount 693 679 5000
buttonNative mount 114 114 5000

Perf Analysis (Fluent)

Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🎯 Avatar.Fluent 0.44 0.51 0.86:1 2000 874
🦄 Button.Fluent 0.12 0.23 0.52:1 5000 585
🔧 Checkbox.Fluent 0.68 0.36 1.89:1 1000 679
🎯 Dialog.Fluent 0.17 0.22 0.77:1 5000 829
🔧 Dropdown.Fluent 3.08 0.42 7.33:1 1000 3076
🔧 Icon.Fluent 0.14 0.06 2.33:1 5000 714
🦄 Image.Fluent 0.08 0.13 0.62:1 5000 396
🔧 Slider.Fluent 1.61 0.43 3.74:1 1000 1613
🔧 Text.Fluent 0.07 0.04 1.75:1 5000 374
🦄 Tooltip.Fluent 0.12 0.91 0.13:1 5000 575

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
HeaderMinimalPerf.default 408 362 1.13:1
PortalMinimalPerf.default 183 164 1.12:1
RadioGroupMinimalPerf.default 485 445 1.09:1
TreeWith60ListItems.default 227 210 1.08:1
AvatarMinimalPerf.default 515 481 1.07:1
ProviderMinimalPerf.default 1123 1054 1.07:1
TextAreaMinimalPerf.default 532 496 1.07:1
SkeletonMinimalPerf.default 450 424 1.06:1
BoxMinimalPerf.default 394 376 1.05:1
ChatMinimalPerf.default 664 635 1.05:1
ImageMinimalPerf.default 411 393 1.05:1
ItemLayoutMinimalPerf.default 1322 1263 1.05:1
RefMinimalPerf.default 249 237 1.05:1
IconMinimalPerf.default 709 678 1.05:1
TextMinimalPerf.default 385 366 1.05:1
LayoutMinimalPerf.default 431 415 1.04:1
TableMinimalPerf.default 434 416 1.04:1
CardMinimalPerf.default 581 566 1.03:1
ChatWithPopoverPerf.default 486 471 1.03:1
ListNestedPerf.default 587 569 1.03:1
MenuButtonMinimalPerf.default 1604 1560 1.03:1
SegmentMinimalPerf.default 377 367 1.03:1
Text.Fluent 374 362 1.03:1
AlertMinimalPerf.default 312 305 1.02:1
DialogMinimalPerf.default 843 824 1.02:1
DropdownManyItemsPerf.default 770 758 1.02:1
EmbedMinimalPerf.default 4325 4223 1.02:1
TableManyItemsPerf.default 2215 2172 1.02:1
CustomToolbarPrototype.default 4026 3953 1.02:1
VideoMinimalPerf.default 674 660 1.02:1
Slider.Fluent 1613 1582 1.02:1
AnimationMinimalPerf.default 414 411 1.01:1
ButtonSlotsPerf.default 618 611 1.01:1
ButtonUseCssPerf.default 847 838 1.01:1
DividerMinimalPerf.default 399 397 1.01:1
InputMinimalPerf.default 1359 1348 1.01:1
ListWith60ListItems.default 975 964 1.01:1
PopupMinimalPerf.default 704 699 1.01:1
ProviderMergeThemesPerf.default 2181 2152 1.01:1
Checkbox.Fluent 679 673 1.01:1
Dropdown.Fluent 3076 3034 1.01:1
DropdownMinimalPerf.default 3101 3087 1:1
HeaderSlotsPerf.default 845 843 1:1
LabelMinimalPerf.default 436 435 1:1
LoaderMinimalPerf.default 741 743 1:1
ReactionMinimalPerf.default 419 420 1:1
SplitButtonMinimalPerf.default 3812 3802 1:1
ToolbarMinimalPerf.default 951 948 1:1
Button.Fluent 585 583 1:1
Dialog.Fluent 829 830 1:1
Tooltip.Fluent 575 573 1:1
AttachmentMinimalPerf.default 169 171 0.99:1
ButtonMinimalPerf.default 179 180 0.99:1
ButtonOverridesMissPerf.default 1764 1788 0.99:1
DatepickerMinimalPerf.default 47222 47837 0.99:1
ListMinimalPerf.default 502 505 0.99:1
StatusMinimalPerf.default 754 765 0.99:1
TooltipMinimalPerf.default 823 828 0.99:1
Icon.Fluent 714 719 0.99:1
AttachmentSlotsPerf.default 1145 1164 0.98:1
CheckboxMinimalPerf.default 2905 2951 0.98:1
MenuMinimalPerf.default 871 885 0.98:1
SliderMinimalPerf.default 1602 1632 0.98:1
TreeMinimalPerf.default 795 810 0.98:1
Image.Fluent 396 404 0.98:1
FormMinimalPerf.default 428 442 0.97:1
GridMinimalPerf.default 361 371 0.97:1
ListCommonPerf.default 650 668 0.97:1
FlexMinimalPerf.default 306 318 0.96:1
Avatar.Fluent 874 915 0.96:1
ButtonUseCssNestingPerf.default 1111 1172 0.95:1
ChatDuplicateMessagesPerf.default 422 447 0.94:1
AccordionMinimalPerf.default 150 162 0.93:1
CarouselMinimalPerf.default 465 500 0.93:1

@size-auditor
Copy link

size-auditor bot commented Dec 2, 2020

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: bc3349b4a83fe049c5eae7d29ce24663c890b1d9 (build)

@assuncaocharles assuncaocharles merged commit f4a9623 into microsoft:master Dec 2, 2020
@assuncaocharles assuncaocharles deleted the fix/carousel-active-index branch December 2, 2020 18:08
@assuncaocharles assuncaocharles mentioned this pull request Jan 27, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pompomon pompomon pompomon approved these changes

@dzearing dzearing Awaiting requested review from dzearing

@jurokapsiar jurokapsiar Awaiting requested review from jurokapsiar

@layershifter layershifter Awaiting requested review from layershifter

@ling1726 ling1726 Awaiting requested review from ling1726

@miroslavstastny miroslavstastny Awaiting requested review from miroslavstastny

Assignees

@ecraig12345 ecraig12345

Labels
Fluent UI react-northstar (v0) Work related to Fluent UI V0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Carousel: onActiveIndexChange callback does not provide current activeIndex
4 participants
@assuncaocharles @msft-github-bot @pompomon @ecraig12345