Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(carousel): fix variables propagation #16084

Merged

Conversation

assuncaocharles
Copy link
Contributor

Pull request checklist

Description of changes

variables weren't being passed down to paddles, this is fixed by passing it to overrideProps

Focus areas to test

(optional)

@msft-github-bot
Copy link
Contributor

msft-github-bot commented Nov 27, 2020

Perf Analysis

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 795 830 5000
BaseButtonCompat mount 859 886 5000
Breadcrumb mount 41942 42490 5000
Checkbox mount 1448 1481 5000
CheckboxBase mount 1180 1208 5000
ChoiceGroup mount 4560 4527 5000
ComboBox mount 918 930 1000
CommandBar mount 9827 9828 1000
ContextualMenu mount 5987 5924 1000
DefaultButtonCompat mount 1094 1108 5000
DetailsRow mount 3585 3549 5000
DetailsRowFast mount 3514 3535 5000
DetailsRowNoStyles mount 3462 3382 5000
Dialog mount 1398 1406 1000
DocumentCardTitle mount 1750 1811 1000
Dropdown mount 3211 3220 5000
FocusTrapZone mount 1805 1765 5000
FocusZone mount 1826 1803 5000
IconButtonCompat mount 1674 1676 5000
Label mount 328 329 5000
Layer mount 1749 1724 5000
Link mount 444 453 5000
MenuButtonCompat mount 1446 1428 5000
MessageBar mount 1934 1992 5000
Nav mount 3135 3109 1000
OverflowSet mount 1003 986 5000
Panel mount 1381 1369 1000
Persona mount 817 839 1000
Pivot mount 1361 1368 1000
PrimaryButtonCompat mount 1219 1244 5000
Rating mount 7230 7176 5000
SearchBox mount 1268 1268 5000
Shimmer mount 2427 2418 5000
Slider mount 1811 1828 5000
SpinButton mount 4811 4849 5000
Spinner mount 393 403 5000
SplitButtonCompat mount 3022 3055 5000
Stack mount 474 471 5000
StackWithIntrinsicChildren mount 1478 1470 5000
StackWithTextChildren mount 4384 4310 5000
SwatchColorPicker mount 9922 9896 5000
Tabs mount 1333 1394 1000
TagPicker mount 2730 2718 5000
TeachingBubble mount 11413 11292 5000
Text mount 404 400 5000
TextField mount 1334 1327 5000
ThemeProvider mount 2093 2097 5000
ThemeProvider virtual-rerender 612 653 5000
Toggle mount 770 757 5000
button mount 632 639 5000
buttonNative mount 107 109 5000

Perf Analysis (Fluent)

⚠️ 1 potential perf regressions detected

Potential regressions comparing to master

Scenario Current PR Ticks Baseline Ticks Ratio Regression Analysis
ButtonMinimalPerf.default 172 165 1.04:1 analysis
Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🎯 Avatar.Fluent 0.43 0.49 0.88:1 2000 865
🦄 Button.Fluent 0.11 0.22 0.5:1 5000 556
🔧 Checkbox.Fluent 0.65 0.32 2.03:1 1000 651
🎯 Dialog.Fluent 0.16 0.2 0.8:1 5000 780
🔧 Dropdown.Fluent 2.92 0.39 7.49:1 1000 2920
🔧 Icon.Fluent 0.14 0.06 2.33:1 5000 706
🦄 Image.Fluent 0.08 0.13 0.62:1 5000 397
🔧 Slider.Fluent 1.52 0.42 3.62:1 1000 1522
🔧 Text.Fluent 0.07 0.03 2.33:1 5000 369
🦄 Tooltip.Fluent 0.11 0.85 0.13:1 5000 552

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
SkeletonMinimalPerf.default 442 407 1.09:1
Text.Fluent 369 342 1.08:1
LabelMinimalPerf.default 438 408 1.07:1
Image.Fluent 397 376 1.06:1
AvatarMinimalPerf.default 477 453 1.05:1
Checkbox.Fluent 651 622 1.05:1
DividerMinimalPerf.default 376 362 1.04:1
HeaderMinimalPerf.default 378 362 1.04:1
HeaderSlotsPerf.default 784 752 1.04:1
LayoutMinimalPerf.default 413 402 1.03:1
SegmentMinimalPerf.default 376 364 1.03:1
TooltipMinimalPerf.default 802 780 1.03:1
TreeWith60ListItems.default 209 203 1.03:1
VideoMinimalPerf.default 635 619 1.03:1
AccordionMinimalPerf.default 167 164 1.02:1
ButtonUseCssPerf.default 803 786 1.02:1
CardMinimalPerf.default 562 549 1.02:1
ChatMinimalPerf.default 624 614 1.02:1
FlexMinimalPerf.default 303 298 1.02:1
ItemLayoutMinimalPerf.default 1293 1268 1.02:1
ListNestedPerf.default 577 568 1.02:1
IconMinimalPerf.default 668 656 1.02:1
TableManyItemsPerf.default 2139 2098 1.02:1
Dialog.Fluent 780 762 1.02:1
Icon.Fluent 706 689 1.02:1
Tooltip.Fluent 552 542 1.02:1
AnimationMinimalPerf.default 405 401 1.01:1
ButtonSlotsPerf.default 597 591 1.01:1
DialogMinimalPerf.default 786 776 1.01:1
DropdownMinimalPerf.default 2938 2913 1.01:1
EmbedMinimalPerf.default 4046 4021 1.01:1
FormMinimalPerf.default 427 424 1.01:1
ListWith60ListItems.default 925 913 1.01:1
LoaderMinimalPerf.default 720 716 1.01:1
MenuButtonMinimalPerf.default 1554 1537 1.01:1
ProviderMergeThemesPerf.default 2040 2028 1.01:1
SliderMinimalPerf.default 1562 1545 1.01:1
SplitButtonMinimalPerf.default 3654 3625 1.01:1
StatusMinimalPerf.default 715 708 1.01:1
TableMinimalPerf.default 417 414 1.01:1
TreeMinimalPerf.default 761 752 1.01:1
Avatar.Fluent 865 854 1.01:1
AttachmentSlotsPerf.default 1101 1106 1:1
ButtonOverridesMissPerf.default 1651 1651 1:1
CarouselMinimalPerf.default 444 443 1:1
ChatDuplicateMessagesPerf.default 406 405 1:1
DatepickerMinimalPerf.default 44748 44968 1:1
DropdownManyItemsPerf.default 738 741 1:1
ListCommonPerf.default 642 643 1:1
PopupMinimalPerf.default 699 702 1:1
PortalMinimalPerf.default 165 165 1:1
RadioGroupMinimalPerf.default 431 431 1:1
ReactionMinimalPerf.default 404 402 1:1
RefMinimalPerf.default 241 240 1:1
TextMinimalPerf.default 356 355 1:1
TextAreaMinimalPerf.default 476 475 1:1
ToolbarMinimalPerf.default 921 922 1:1
Dropdown.Fluent 2920 2933 1:1
AlertMinimalPerf.default 312 314 0.99:1
AttachmentMinimalPerf.default 158 160 0.99:1
ButtonUseCssNestingPerf.default 1062 1073 0.99:1
CheckboxMinimalPerf.default 2791 2813 0.99:1
ImageMinimalPerf.default 368 370 0.99:1
MenuMinimalPerf.default 842 849 0.99:1
ProviderMinimalPerf.default 987 996 0.99:1
CustomToolbarPrototype.default 3818 3855 0.99:1
Button.Fluent 556 562 0.99:1
InputMinimalPerf.default 1295 1317 0.98:1
GridMinimalPerf.default 331 341 0.97:1
ListMinimalPerf.default 470 483 0.97:1
Slider.Fluent 1522 1573 0.97:1
BoxMinimalPerf.default 353 370 0.95:1
ChatWithPopoverPerf.default 458 492 0.93:1

@size-auditor
Copy link

size-auditor bot commented Nov 27, 2020

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: bf33fbdc185d4f07f8b4bba815af218929366bf9 (build)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 27, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b4bb36f:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration
codesandbox-react-northstar-template Configuration
fluent-ui-example Issue #15992

Copy link
Member

@layershifter layershifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check a comment about variables

@msft-github-bot
Copy link
Contributor

Hello @assuncaocharles!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msft-github-bot) and give me an instruction to get started! Learn more here.

@msft-github-bot msft-github-bot merged commit bc3349b into microsoft:master Dec 2, 2020
@assuncaocharles assuncaocharles deleted the fix/carousel-variables branch December 2, 2020 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Carousel: Width variable not visible in docs site and not propagated to other slots
5 participants