-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(carousel): fix variables propagation #16084
fix(carousel): fix variables propagation #16084
Conversation
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Potential regressions comparing to master
Perf comparison
Perf tests with no regressions
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: bf33fbdc185d4f07f8b4bba815af218929366bf9 (build) |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b4bb36f:
|
packages/fluentui/react-northstar/src/components/Carousel/Carousel.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check a comment about variables
Hello @assuncaocharles! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
…usel.tsx Co-authored-by: Oleksandr Fediashov <[email protected]>
4593baa
to
b4bb36f
Compare
Pull request checklist
$ yarn change
Description of changes
variables
weren't being passed down to paddles, this is fixed by passing it tooverrideProps
Focus areas to test
(optional)