Rename @uifabric/example-data to @fluentui/example-data
#15618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomi-msft
requested review from
assuncaocharles,
behowell,
bigbadcapers,
dzearing,
evlevy,
hyoshis,
Jacqueline-ms,
Jahnp,
JasonGore,
joschect,
jurokapsiar,
khmakoto,
layershifter,
lorejoh12,
Markionium,
miroslavstastny,
mtennoe,
pompomon,
Raghurk,
wsmd,
xugao and
yiminwu
as code owners
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e5aac1f:
|
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 3545f576557f05a2d907eaf07a7ae56dd16ae925 (build) |
ecraig12345
reviewed
Oct 20, 2020
change/@fluentui-react-icons-2020-10-20-10-54-27-set-version-rename.json
Outdated
Show resolved
Hide resolved
change/@uifabric-icons-2020-10-20-10-54-27-set-version-rename.json
Outdated
Show resolved
Hide resolved
|
Looks like you need to manually update version.ts in font-icons-mdl2 and possibly also react-icons-mdl2. |
|
It's weird though that errors about version.ts would be showing up in this PR rather than the actual set-version one...? |
|
So what I think happened is I accidentally merged my master branch with set-version when I was trying to solve merge conflicts over there, and when I made this branch off of my master, it had the set-version rename already there. I think I will wait for build to pass for set-version PR, merge that, and then fix merge conflicts for this, to make things easier for myself |
tomi-msft
force-pushed
the
example-data-rename
branch
from
73fbc7a to
d6f4337
Compare
ecraig12345
approved these changes
Oct 21, 2020
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
SethDonohue
pushed a commit
to SethDonohue/fluentui
that referenced
this pull request
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
Rename
@uifabric/example-datato@fluentui/example-dataFocus areas to test
(optional)