Rename build-related packages #15615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecraig12345
requested review from
assuncaocharles,
atneik,
behowell,
bigbadcapers,
dzearing,
evlevy,
hyoshis,
Jacqueline-ms,
Jahnp,
JasonGore,
joschect,
jurokapsiar,
khmakoto,
kolaps33,
layershifter,
lorejoh12,
miroslavstastny,
pompomon,
Raghurk,
ThomasMichon,
Vitalius1,
wsmd and
xugao
as code owners
ecraig12345
force-pushed
the
rename-build
branch
from
790084d to
2951017
Compare
ecraig12345
force-pushed
the
rename-build
branch
2 times, most recently
from
befc84d to
85e745b
Compare
ecraig12345
force-pushed
the
rename-build
branch
2 times, most recently
from
60134f2 to
b84731a
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 60134f2:
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 9ca5b3a:
|
ecraig12345
force-pushed
the
rename-build
branch
from
b84731a to
3cd7cb0
Compare
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
xugao
approved these changes
Oct 22, 2020
| @@ -0,0 +1,4 @@ | |||
| { | |||
There was a problem hiding this comment.
what's this root tsconfig for?
There was a problem hiding this comment.
Better type resolution while editing just.config.ts throughout the repo
# Conflicts: # apps/a11y-tests/package.json # apps/dom-tests/package.json # apps/perf-test/package.json # apps/public-docsite/package.json # apps/ssr-tests/package.json # apps/test-bundles/package.json # apps/vr-tests/package.json # change/@uifabric-foundation-2020-10-11-10-30-57-keco-slots.json # packages/azure-themes/package.json # packages/common-styles/package.json # packages/date-time/package.json # packages/date-time/src/components/WeeklyDayPicker/WeeklyDayPicker.test.tsx # packages/example-data/package.json # packages/fluentui/e2e/package.json # packages/fluentui/state/package.json # packages/font-icons-mdl2/package.json # packages/foundation-legacy/package.json # packages/monaco-editor/package.json # packages/react-avatar/package.json # packages/react-cards/package.json # packages/react-charting/package.json # packages/react-examples/package.json # packages/react-experiments/package.json # packages/react-flex/package.json # packages/react-focus/package.json # packages/react-hooks/package.json # packages/react-image/package.json # packages/react-internal/package.json # packages/react-internal/src/compat/components/Button/Button.test.tsx # packages/react-internal/src/components/Shimmer/Shimmer.test.tsx # packages/react-link/package.json # packages/react-monaco-editor/scripts/copyTypes.ts # packages/react-next/package.json # packages/react-slider/package.json # packages/react-stylesheets/package.json # packages/react-theme-provider/package.json # packages/react-utilities/package.json # packages/react/package.json # packages/react/src/components/DetailsList/DetailsList.test.tsx # packages/scheme-utilities/package.json # packages/theme-samples/package.json # packages/utilities/package.json # scripts/package.json
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: c6ae2b350037deb4e0bea07cdbdfe2e93455f4b1 (build) |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
SethDonohue
pushed a commit
to SethDonohue/fluentui
that referenced
this pull request
Nov 2, 2020
- Rename @uifabric/build to @fluentui/scripts - Rename @uifabric/webpack-utils to @fluentui/webpack-utilities - Rename @uifabric/test-utilities to @fluentui/test-utilities - Rename @uifabric/jest-serializer-merge-styles to @fluentui/jest-serializer-merge-styles - Convert tasks to TS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #13384, moving things to fluentui scope:
@uifabric/buildto@fluentui/scripts(also matches the folder name)@uifabric/webpack-utilsto@fluentui/webpack-utilities@uifabric/test-utilitiesto@fluentui/test-utilities@uifabric/jest-serializer-merge-stylesto@fluentui/jest-serializer-merge-stylesAlso since I was already touching the entire world of just configs, I converted them to use actual TS import syntax and converted the task files to be TS not JS.