Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename @uifabric/icons to @fluentui/font-icons-mdl2 #15603

Merged
merged 8 commits into from
Oct 20, 2020
Merged

Rename @uifabric/icons to @fluentui/font-icons-mdl2 #15603

merged 8 commits into from
Oct 20, 2020

Conversation

tomi-msft
Copy link
Contributor

@tomi-msft tomi-msft commented Oct 20, 2020 •
edited
Loading

Pull request checklist

Description of changes

Rename @uifabric/icons to @fluentui/font-icons-mdl2

Focus areas to test

(optional)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 20, 2020 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4e83607:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration
codesandbox-react-northstar-template Configuration

ecraig12345
ecraig12345 reviewed Oct 20, 2020
View reviewed changes
change/@fluentui-react-checkbox-2020-10-19-17-41-22-icon-rename.json
@@ -0,0 +1,8 @@
{
"type": "minor",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of these should probably be patch, not minor (though I'm not sure it matters in this case since we may not end up using all these changelogs as-is)

@ecraig12345
Copy link
Member

Looks like you need an API update in react-internal.

@tomi-msft tomi-msft mentioned this pull request Oct 20, 2020
Closed
@msft-github-bot
Copy link
Contributor

Perf Analysis

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 938 941 5000
BaseButtonCompat mount 1020 1001 5000
Breadcrumb mount 165409 165879 5000
Checkbox mount 1679 1737 5000
CheckboxBase mount 1421 1420 5000
ChoiceGroup mount 5164 5173 5000
ComboBox mount 1053 1061 1000
CommandBar mount 22800 22836 1000
ContextualMenu mount 6482 6446 1000
DefaultButtonCompat mount 1246 1271 5000
DetailsRow mount 3947 4012 5000
DetailsRowFast mount 3943 3986 5000
DetailsRowNoStyles mount 3800 3715 5000
Dialog mount 1630 1627 1000
DocumentCardTitle mount 1871 1885 1000
Dropdown mount 4100 4105 5000
FocusTrapZone mount 1945 1955 5000
FocusZone mount 1927 1939 5000
IconButtonCompat mount 1988 1958 5000
Label mount 367 365 5000
Layer mount 1956 1982 5000
Link mount 527 511 5000
MenuButtonCompat mount 1641 1672 5000
MessageBar mount 2143 2173 5000
Nav mount 3571 3527 1000
OverflowSet mount 1137 1125 5000
Panel mount 1517 1582 1000
Persona mount 948 933 1000
Pivot mount 1555 1504 1000
PrimaryButtonCompat mount 1427 1404 5000
Rating mount 8340 8349 5000
SearchBox mount 1487 1461 5000
Shimmer mount 2935 2838 5000
Slider mount 2124 2079 5000
SpinButton mount 5497 5652 5000
Spinner mount 444 422 5000
SplitButtonCompat mount 3504 3451 5000
Stack mount 555 563 5000
StackWithIntrinsicChildren mount 1658 1697 5000
StackWithTextChildren mount 5202 5224 5000
SwatchColorPicker mount 11009 11208 5000
TagPicker mount 3003 2985 5000
TeachingBubble mount 12264 12202 5000
Text mount 484 480 5000
TextField mount 1501 1532 5000
ThemeProvider mount 2111 2112 5000
ThemeProvider virtual-rerender 673 671 5000
Toggle mount 882 910 5000
button mount 574 626 5000
buttonNative mount 116 113 5000

Perf Analysis (Fluent)

Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🎯 Avatar.Fluent 0.5 0.55 0.91:1 2000 1006
🦄 Button.Fluent 0.13 0.25 0.52:1 5000 659
🔧 Checkbox.Fluent 0.71 0.38 1.87:1 1000 706
🎯 Dialog.Fluent 0.18 0.25 0.72:1 5000 904
🔧 Dropdown.Fluent 3.11 0.5 6.22:1 1000 3109
🔧 Icon.Fluent 0.17 0.07 2.43:1 5000 832
🦄 Image.Fluent 0.09 0.14 0.64:1 5000 456
🔧 Slider.Fluent 1.68 0.48 3.5:1 1000 1683
🔧 Text.Fluent 0.09 0.03 3:1 5000 429
🦄 Tooltip.Fluent 0.13 0.95 0.14:1 5000 635

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
RefMinimalPerf.default 286 244 1.17:1
AttachmentMinimalPerf.default 195 183 1.07:1
ListMinimalPerf.default 577 540 1.07:1
TextAreaMinimalPerf.default 610 571 1.07:1
AnimationMinimalPerf.default 472 451 1.05:1
ButtonUseCssNestingPerf.default 1243 1183 1.05:1
ChatMinimalPerf.default 733 695 1.05:1
ChatWithPopoverPerf.default 534 511 1.05:1
TableMinimalPerf.default 488 463 1.05:1
TreeMinimalPerf.default 1053 1003 1.05:1
DividerMinimalPerf.default 463 444 1.04:1
GridMinimalPerf.default 404 390 1.04:1
HeaderMinimalPerf.default 451 432 1.04:1
HeaderSlotsPerf.default 932 894 1.04:1
ListNestedPerf.default 665 638 1.04:1
RadioGroupMinimalPerf.default 527 505 1.04:1
SegmentMinimalPerf.default 426 409 1.04:1
SplitButtonMinimalPerf.default 4295 4137 1.04:1
TreeWith60ListItems.default 230 222 1.04:1
Text.Fluent 429 412 1.04:1
BoxMinimalPerf.default 433 420 1.03:1
ButtonUseCssPerf.default 931 908 1.03:1
IconMinimalPerf.default 784 759 1.03:1
CustomToolbarPrototype.default 4248 4112 1.03:1
Icon.Fluent 832 809 1.03:1
CheckboxMinimalPerf.default 3144 3078 1.02:1
DialogMinimalPerf.default 908 888 1.02:1
DropdownManyItemsPerf.default 871 851 1.02:1
PopupMinimalPerf.default 762 747 1.02:1
TextMinimalPerf.default 427 417 1.02:1
Dialog.Fluent 904 882 1.02:1
AttachmentSlotsPerf.default 1279 1272 1.01:1
ButtonOverridesMissPerf.default 1875 1862 1.01:1
DropdownMinimalPerf.default 3118 3095 1.01:1
EmbedMinimalPerf.default 2234 2205 1.01:1
ItemLayoutMinimalPerf.default 1461 1453 1.01:1
MenuButtonMinimalPerf.default 1785 1762 1.01:1
PortalMinimalPerf.default 168 166 1.01:1
ToolbarMinimalPerf.default 1078 1072 1.01:1
VideoMinimalPerf.default 748 744 1.01:1
Checkbox.Fluent 706 698 1.01:1
Tooltip.Fluent 635 628 1.01:1
ButtonMinimalPerf.default 201 202 1:1
InputMinimalPerf.default 1421 1421 1:1
LabelMinimalPerf.default 486 486 1:1
LayoutMinimalPerf.default 466 465 1:1
ListWith60ListItems.default 1025 1030 1:1
ReactionMinimalPerf.default 488 488 1:1
SkeletonMinimalPerf.default 503 502 1:1
TooltipMinimalPerf.default 893 893 1:1
Avatar.Fluent 1006 1002 1:1
Button.Fluent 659 656 1:1
Dropdown.Fluent 3109 3113 1:1
Slider.Fluent 1683 1676 1:1
AvatarMinimalPerf.default 539 543 0.99:1
ButtonSlotsPerf.default 670 676 0.99:1
ListCommonPerf.default 748 755 0.99:1
MenuMinimalPerf.default 974 984 0.99:1
ProviderMergeThemesPerf.default 2161 2178 0.99:1
SliderMinimalPerf.default 1690 1701 0.99:1
TableManyItemsPerf.default 2497 2520 0.99:1
Image.Fluent 456 461 0.99:1
CarouselMinimalPerf.default 501 512 0.98:1
FormMinimalPerf.default 489 499 0.98:1
StatusMinimalPerf.default 831 848 0.98:1
ImageMinimalPerf.default 451 464 0.97:1
ProviderMinimalPerf.default 1084 1121 0.97:1
LoaderMinimalPerf.default 793 828 0.96:1
CardMinimalPerf.default 645 677 0.95:1
ChatDuplicateMessagesPerf.default 455 481 0.95:1
AccordionMinimalPerf.default 172 183 0.94:1
AlertMinimalPerf.default 338 364 0.93:1
FlexMinimalPerf.default 344 373 0.92:1

@size-auditor
Copy link

size-auditor bot commented Oct 20, 2020

Asset size changes

Project Bundle Baseline Size New Size Difference
office-ui-fabric-react fluentui-react-Icons 63.93 kB 63.94 kB ExceedsBaseline     10 bytes

ExceedsTolerance Over Tolerance (1024 B) ExceedsBaseline Over Baseline BelowBaseline Below Baseline New New Deleted  Removed 1 kB = 1000 B

Baseline commit: ddb628724b27b6be3d430ea0a7b728ac9adfb8ec (build)

@ecraig12345 ecraig12345 merged commit d3bafa5 into microsoft:master Oct 20, 2020
@msft-github-bot
Copy link
Contributor

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ecraig12345 ecraig12345 ecraig12345 approved these changes

@behowell behowell Awaiting requested review from behowell

@dzearing dzearing Awaiting requested review from dzearing

@Jahnp Jahnp Awaiting requested review from Jahnp

@khmakoto khmakoto Awaiting requested review from khmakoto

@xugao xugao Awaiting requested review from xugao

Assignees

@tomi-msft tomi-msft

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tomi-msft @ecraig12345 @msft-github-bot