Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename @uifabric/foundation to @fluentui/foundation-legacy #15595

Merged
merged 6 commits into from
Oct 20, 2020
Merged

Rename @uifabric/foundation to @fluentui/foundation-legacy #15595

merged 6 commits into from
Oct 20, 2020

Conversation

xugao
Copy link
Contributor

@xugao xugao commented Oct 19, 2020

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ yarn change

Description of changes

Rename @uifabric/foundation to @fluentui/foundation-legacy

Related issue: #13384

Focus areas to test

(optional)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 19, 2020 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 122686b:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration
codesandbox-react-northstar-template Configuration

@xugao xugao force-pushed the xgao/rename-legacy-packages branch from 74b20b6 to 128972c Compare October 19, 2020 22:50
ecraig12345
ecraig12345 approved these changes Oct 19, 2020
View reviewed changes
Copy link
Member

@ecraig12345 ecraig12345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor suggestion, otherwise looks good

@msft-github-bot
Copy link
Contributor

msft-github-bot commented Oct 19, 2020 •
edited
Loading

Perf Analysis

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 826 855 5000
BaseButtonCompat mount 900 874 5000
Breadcrumb mount 161577 162278 5000
Checkbox mount 1500 1514 5000
CheckboxBase mount 1221 1252 5000
ChoiceGroup mount 4673 4711 5000
ComboBox mount 961 982 1000
CommandBar mount 21889 21908 1000
ContextualMenu mount 6120 6140 1000
DefaultButtonCompat mount 1114 1154 5000
DetailsRow mount 3591 3609 5000
DetailsRowFast mount 3587 3641 5000
DetailsRowNoStyles mount 3504 3471 5000
Dialog mount 1485 1513 1000
DocumentCardTitle mount 1818 1856 1000
Dropdown mount 3700 3735 5000
FocusTrapZone mount 1856 1856 5000
FocusZone mount 1834 1862 5000
IconButtonCompat mount 1715 1767 5000
Label mount 336 347 5000
Layer mount 1768 1826 5000
Link mount 461 462 5000
MenuButtonCompat mount 1469 1470 5000
MessageBar mount 2113 2133 5000
Nav mount 3278 3312 1000
OverflowSet mount 1037 1025 5000
Panel mount 1434 1456 1000
Persona mount 866 863 1000
Pivot mount 1397 1373 1000
PrimaryButtonCompat mount 1265 1263 5000
Rating mount 7480 7438 5000
SearchBox mount 1315 1310 5000
Shimmer mount 2591 2493 5000
Slider mount 1892 1895 5000
SpinButton mount 5136 5202 5000
Spinner mount 427 444 5000
SplitButtonCompat mount 3165 3124 5000
Stack mount 513 498 5000
StackWithIntrinsicChildren mount 1529 1555 5000
StackWithTextChildren mount 4633 4680 5000
SwatchColorPicker mount 10168 10228 5000
TagPicker mount 2766 2730 5000
TeachingBubble mount 11658 11677 5000
Text mount 423 429 5000
TextField mount 1368 1373 5000
ThemeProvider mount 2024 2011 5000
ThemeProvider virtual-rerender 643 643 5000
Toggle mount 792 805 5000
button mount 551 560 5000
buttonNative mount 111 121 5000

Perf Analysis (Fluent)

Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🎯 Avatar.Fluent 0.44 0.5 0.88:1 2000 889
🦄 Button.Fluent 0.12 0.22 0.55:1 5000 591
🔧 Checkbox.Fluent 0.67 0.35 1.91:1 1000 673
🎯 Dialog.Fluent 0.16 0.23 0.7:1 5000 812
🔧 Dropdown.Fluent 3.14 0.43 7.3:1 1000 3142
🔧 Icon.Fluent 0.14 0.06 2.33:1 5000 725
🦄 Image.Fluent 0.08 0.13 0.62:1 5000 403
🔧 Slider.Fluent 1.63 0.43 3.79:1 1000 1632
🔧 Text.Fluent 0.08 0.03 2.67:1 5000 376
🦄 Tooltip.Fluent 0.12 0.92 0.13:1 5000 579

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AttachmentMinimalPerf.default 179 156 1.15:1
DropdownManyItemsPerf.default 811 748 1.08:1
PortalMinimalPerf.default 174 163 1.07:1
SegmentMinimalPerf.default 393 371 1.06:1
Dropdown.Fluent 3142 2993 1.05:1
AccordionMinimalPerf.default 170 163 1.04:1
DividerMinimalPerf.default 402 388 1.04:1
VideoMinimalPerf.default 653 627 1.04:1
Button.Fluent 591 569 1.04:1
AnimationMinimalPerf.default 422 410 1.03:1
EmbedMinimalPerf.default 1984 1925 1.03:1
MenuMinimalPerf.default 892 870 1.03:1
ReactionMinimalPerf.default 437 425 1.03:1
IconMinimalPerf.default 705 685 1.03:1
TextAreaMinimalPerf.default 526 513 1.03:1
AvatarMinimalPerf.default 479 468 1.02:1
BoxMinimalPerf.default 387 378 1.02:1
ListCommonPerf.default 684 672 1.02:1
ListWith60ListItems.default 973 954 1.02:1
ToolbarMinimalPerf.default 976 955 1.02:1
TreeMinimalPerf.default 902 885 1.02:1
Checkbox.Fluent 673 661 1.02:1
AttachmentSlotsPerf.default 1155 1149 1.01:1
ChatWithPopoverPerf.default 486 481 1.01:1
FlexMinimalPerf.default 314 311 1.01:1
FormMinimalPerf.default 439 435 1.01:1
GridMinimalPerf.default 366 363 1.01:1
InputMinimalPerf.default 1355 1336 1.01:1
LayoutMinimalPerf.default 438 433 1.01:1
ListNestedPerf.default 595 592 1.01:1
LoaderMinimalPerf.default 745 737 1.01:1
MenuButtonMinimalPerf.default 1606 1595 1.01:1
StatusMinimalPerf.default 751 741 1.01:1
CustomToolbarPrototype.default 4034 3983 1.01:1
Dialog.Fluent 812 801 1.01:1
Slider.Fluent 1632 1612 1.01:1
Text.Fluent 376 372 1.01:1
AlertMinimalPerf.default 332 333 1:1
ButtonOverridesMissPerf.default 1723 1720 1:1
ChatDuplicateMessagesPerf.default 435 434 1:1
CheckboxMinimalPerf.default 2905 2916 1:1
DialogMinimalPerf.default 808 810 1:1
HeaderMinimalPerf.default 397 397 1:1
ListMinimalPerf.default 511 509 1:1
PopupMinimalPerf.default 728 727 1:1
ProviderMergeThemesPerf.default 2128 2123 1:1
ProviderMinimalPerf.default 1077 1072 1:1
RefMinimalPerf.default 250 249 1:1
SplitButtonMinimalPerf.default 3826 3819 1:1
TooltipMinimalPerf.default 843 840 1:1
Avatar.Fluent 889 886 1:1
Tooltip.Fluent 579 578 1:1
ButtonUseCssPerf.default 825 833 0.99:1
ButtonUseCssNestingPerf.default 1096 1105 0.99:1
DropdownMinimalPerf.default 2958 3000 0.99:1
SkeletonMinimalPerf.default 436 439 0.99:1
SliderMinimalPerf.default 1612 1630 0.99:1
TableManyItemsPerf.default 2199 2213 0.99:1
Image.Fluent 403 406 0.99:1
ButtonMinimalPerf.default 187 190 0.98:1
CardMinimalPerf.default 574 585 0.98:1
ChatMinimalPerf.default 627 641 0.98:1
ItemLayoutMinimalPerf.default 1307 1327 0.98:1
LabelMinimalPerf.default 433 440 0.98:1
TextMinimalPerf.default 383 392 0.98:1
HeaderSlotsPerf.default 796 823 0.97:1
RadioGroupMinimalPerf.default 447 459 0.97:1
TreeWith60ListItems.default 201 207 0.97:1
ImageMinimalPerf.default 396 414 0.96:1
Icon.Fluent 725 754 0.96:1
CarouselMinimalPerf.default 451 480 0.94:1
TableMinimalPerf.default 427 453 0.94:1
ButtonSlotsPerf.default 600 643 0.93:1

@size-auditor
Copy link

size-auditor bot commented Oct 19, 2020 •
edited
Loading

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: b74646e44c00e602f441841b3339f86a679d5af7 (build)

@xugao xugao requested a review from khmakoto October 20, 2020 00:24
@xugao xugao force-pushed the xgao/rename-legacy-packages branch from 15e973c to 122686b Compare October 20, 2020 00:52
@ecraig12345 ecraig12345 merged commit ddb6287 into microsoft:master Oct 20, 2020
@xugao xugao mentioned this pull request Oct 20, 2020
Closed
@msft-github-bot
Copy link
Contributor

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ecraig12345 ecraig12345 ecraig12345 approved these changes

@khmakoto khmakoto khmakoto approved these changes

@dzearing dzearing Awaiting requested review from dzearing

@natalieethell natalieethell Awaiting requested review from natalieethell

Assignees

@tomi-msft tomi-msft

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@xugao @msft-github-bot @ecraig12345 @khmakoto @tomi-msft