Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename @uifabric/react-cards to @fluentui/react-cards #15586

Merged
merged 2 commits into from
Oct 19, 2020

Conversation

ecraig12345
Copy link
Member

Pull request checklist

@ecraig12345 ecraig12345 changed the title Rename @uifabric/cards to @fluentui/react-cards Rename @uifabric/react-cards to @fluentui/react-cards Oct 19, 2020
@msft-github-bot
Copy link
Contributor

Perf Analysis

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 814 811 5000
BaseButtonCompat mount 888 909 5000
Breadcrumb mount 161855 161901 5000
Checkbox mount 1519 1512 5000
CheckboxBase mount 1223 1253 5000
ChoiceGroup mount 4632 4731 5000
ComboBox mount 967 956 1000
CommandBar mount 21823 21956 1000
ContextualMenu mount 6119 6157 1000
DefaultButtonCompat mount 1132 1116 5000
DetailsRow mount 3586 3590 5000
DetailsRowFast mount 3555 3576 5000
DetailsRowNoStyles mount 3380 3439 5000
Dialog mount 1484 1501 1000
DocumentCardTitle mount 1829 1826 1000
Dropdown mount 3742 3721 5000
FocusTrapZone mount 1792 1782 5000
FocusZone mount 1804 1823 5000
IconButtonCompat mount 1766 1718 5000
Label mount 331 335 5000
Layer mount 1801 1767 5000
Link mount 455 464 5000
MenuButtonCompat mount 1444 1455 5000
MessageBar mount 2083 2075 5000
Nav mount 3243 3215 1000
OverflowSet mount 1013 1038 5000
Panel mount 1430 1444 1000
Persona mount 855 844 1000
Pivot mount 1395 1397 1000
PrimaryButtonCompat mount 1267 1302 5000
Rating mount 7399 7375 5000
SearchBox mount 1323 1308 5000
Shimmer mount 2492 2492 5000
Slider mount 1849 1855 5000
SpinButton mount 5001 5098 5000
Spinner mount 423 426 5000
SplitButtonCompat mount 3161 3096 5000
Stack mount 502 516 5000
StackWithIntrinsicChildren mount 1901 1914 5000
StackWithTextChildren mount 4922 4895 5000
SwatchColorPicker mount 10102 10050 5000
TagPicker mount 2662 2664 5000
TeachingBubble mount 11388 11376 5000
Text mount 419 419 5000
TextField mount 1357 1382 5000
ThemeProvider mount 1946 1953 5000
ThemeProvider virtual-rerender 653 657 5000
Toggle mount 802 792 5000
button mount 540 563 5000
buttonNative mount 107 102 5000

Perf Analysis (Fluent)

Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🎯 Avatar.Fluent 0.44 0.5 0.88:1 2000 888
🦄 Button.Fluent 0.11 0.2 0.55:1 5000 571
🔧 Checkbox.Fluent 0.64 0.33 1.94:1 1000 640
🎯 Dialog.Fluent 0.16 0.22 0.73:1 5000 797
🔧 Dropdown.Fluent 3 0.44 6.82:1 1000 3003
🔧 Icon.Fluent 0.14 0.06 2.33:1 5000 709
🦄 Image.Fluent 0.08 0.13 0.62:1 5000 391
🔧 Slider.Fluent 1.64 0.43 3.81:1 1000 1643
🔧 Text.Fluent 0.08 0.03 2.67:1 5000 385
🦄 Tooltip.Fluent 0.12 0.89 0.13:1 5000 587

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
ButtonMinimalPerf.default 193 170 1.14:1
AttachmentMinimalPerf.default 177 161 1.1:1
FormMinimalPerf.default 441 415 1.06:1
MenuMinimalPerf.default 909 861 1.06:1
BoxMinimalPerf.default 387 370 1.05:1
ChatWithPopoverPerf.default 486 465 1.05:1
DialogMinimalPerf.default 825 782 1.05:1
GridMinimalPerf.default 376 360 1.04:1
LabelMinimalPerf.default 443 426 1.04:1
LayoutMinimalPerf.default 442 425 1.04:1
ListCommonPerf.default 668 640 1.04:1
Text.Fluent 385 369 1.04:1
AnimationMinimalPerf.default 432 418 1.03:1
ButtonSlotsPerf.default 619 603 1.03:1
ButtonUseCssPerf.default 851 825 1.03:1
CardMinimalPerf.default 595 579 1.03:1
ReactionMinimalPerf.default 421 409 1.03:1
AccordionMinimalPerf.default 168 165 1.02:1
ButtonUseCssNestingPerf.default 1111 1091 1.02:1
DropdownManyItemsPerf.default 754 741 1.02:1
PopupMinimalPerf.default 722 711 1.02:1
ProviderMergeThemesPerf.default 2143 2110 1.02:1
SkeletonMinimalPerf.default 436 429 1.02:1
SliderMinimalPerf.default 1636 1602 1.02:1
TableManyItemsPerf.default 2216 2177 1.02:1
TableMinimalPerf.default 427 418 1.02:1
ToolbarMinimalPerf.default 975 954 1.02:1
Button.Fluent 571 561 1.02:1
Slider.Fluent 1643 1618 1.02:1
Tooltip.Fluent 587 575 1.02:1
ChatDuplicateMessagesPerf.default 439 436 1.01:1
DividerMinimalPerf.default 387 385 1.01:1
DropdownMinimalPerf.default 3002 2960 1.01:1
HeaderMinimalPerf.default 380 378 1.01:1
HeaderSlotsPerf.default 810 801 1.01:1
ListWith60ListItems.default 950 939 1.01:1
LoaderMinimalPerf.default 749 738 1.01:1
PortalMinimalPerf.default 176 174 1.01:1
ProviderMinimalPerf.default 1058 1049 1.01:1
StatusMinimalPerf.default 738 733 1.01:1
IconMinimalPerf.default 681 673 1.01:1
TreeWith60ListItems.default 216 214 1.01:1
Dialog.Fluent 797 786 1.01:1
ButtonOverridesMissPerf.default 1719 1717 1:1
CheckboxMinimalPerf.default 2876 2879 1:1
ImageMinimalPerf.default 389 390 1:1
ItemLayoutMinimalPerf.default 1300 1298 1:1
ListNestedPerf.default 585 584 1:1
SplitButtonMinimalPerf.default 3791 3790 1:1
CustomToolbarPrototype.default 3986 3986 1:1
Avatar.Fluent 888 885 1:1
Dropdown.Fluent 3003 2993 1:1
Image.Fluent 391 392 1:1
AlertMinimalPerf.default 312 315 0.99:1
AttachmentSlotsPerf.default 1135 1143 0.99:1
EmbedMinimalPerf.default 1897 1918 0.99:1
InputMinimalPerf.default 1332 1348 0.99:1
ListMinimalPerf.default 497 503 0.99:1
MenuButtonMinimalPerf.default 1593 1603 0.99:1
RadioGroupMinimalPerf.default 451 455 0.99:1
RefMinimalPerf.default 240 243 0.99:1
Checkbox.Fluent 640 646 0.99:1
ChatMinimalPerf.default 629 640 0.98:1
SegmentMinimalPerf.default 365 373 0.98:1
TextMinimalPerf.default 369 377 0.98:1
VideoMinimalPerf.default 645 655 0.98:1
AvatarMinimalPerf.default 484 500 0.97:1
CarouselMinimalPerf.default 454 470 0.97:1
TextAreaMinimalPerf.default 478 495 0.97:1
TooltipMinimalPerf.default 811 835 0.97:1
TreeMinimalPerf.default 883 906 0.97:1
FlexMinimalPerf.default 304 318 0.96:1
Icon.Fluent 709 741 0.96:1

@size-auditor
Copy link

size-auditor bot commented Oct 19, 2020

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 3346b09e82b41f6b5b96fe1a94c8d122b3a4625b (build)

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9759a08:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration
codesandbox-react-northstar-template Configuration

@ecraig12345 ecraig12345 merged commit 671b625 into microsoft:master Oct 19, 2020
@ecraig12345 ecraig12345 deleted the rename-cards branch October 19, 2020 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants