Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cherrypick of variants pr #15375

Merged
merged 4 commits into from
Oct 6, 2020
Merged

cherrypick of variants pr #15375

merged 4 commits into from
Oct 6, 2020

Conversation

dzearing
Copy link
Member

@dzearing dzearing commented Oct 6, 2020

Cherrypicking variants into 7.0 branch.

@dzearing dzearing requested a review from khmakoto as a code owner October 6, 2020 00:53
@msft-github-bot msft-github-bot added the needs cherry-pick Temporary label for PRs which may need to be cherry-picked to master label Oct 6, 2020
@ecraig12345
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 6, 2020 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit cdb42e7:

Sandbox Source
Fluent UI Button Configuration
microsoft/fluentui: codesandbox-react-template Configuration
microsoft/fluentui: codesandbox-react-next-template Configuration
microsoft/fluentui: codesandbox-react-northstar-template Configuration

@msft-github-bot
Copy link
Contributor

msft-github-bot commented Oct 6, 2020 •
edited
Loading

Perf Analysis

Scenario Render type 7.0 Ticks PR Ticks Iterations Status
ThemeProvider mount 3113 1653 5000 Possible regression
All results

Scenario Render type 7.0 Ticks PR Ticks Iterations Status
Avatar mount 820 810 5000
BaseButton mount 955 898 5000
Breadcrumb mount 39142 39098 5000
ButtonNext mount 576 573 5000
Checkbox mount 1596 1652 5000
CheckboxBase mount 1354 1332 5000
ChoiceGroup mount 5155 5067 5000
ComboBox mount 975 935 1000
CommandBar mount 7406 7399 1000
ContextualMenu mount 12556 12517 1000
DefaultButton mount 1159 1114 5000
DetailsRow mount 3625 3707 5000
DetailsRowFast mount 3663 3661 5000
DetailsRowNoStyles mount 3524 3440 5000
Dialog mount 1500 1495 1000
DocumentCardTitle mount 1743 1703 1000
Dropdown mount 2650 2633 5000
FocusTrapZone mount 1695 1658 5000
FocusZone mount 1780 1765 5000
IconButton mount 1835 1798 5000
Label mount 342 343 5000
Layer mount 1973 1955 5000
Link mount 456 480 5000
MenuButton mount 1521 1524 5000
MessageBar mount 2001 1977 5000
Nav mount 3272 3295 1000
OverflowSet mount 1382 1398 5000
Panel mount 1424 1453 1000
Persona mount 840 799 1000
Pivot mount 1424 1418 1000
PrimaryButton mount 1305 1312 5000
Rating mount 7924 7726 5000
SearchBox mount 1321 1315 5000
Shimmer mount 2615 2634 5000
Slider mount 1511 1489 5000
SpinButton mount 5036 5033 5000
Spinner mount 425 407 5000
SplitButton mount 3233 3216 5000
Stack mount 529 517 5000
StackWithIntrinsicChildren mount 1870 1878 5000
StackWithTextChildren mount 5073 5015 5000
SwatchColorPicker mount 10285 10254 5000
TagPicker mount 2807 2793 5000
TeachingBubble mount 51081 47635 5000
Text mount 487 462 5000
TextField mount 1436 1450 5000
ThemeProvider mount 3113 1653 5000 Possible regression
ThemeProvider virtual-rerender 615 627 5000
Toggle mount 843 846 5000
button mount 114 122 5000

Perf Analysis (Fluent)

Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🎯 Avatar.Fluent 0.47 0.48 0.98:1 2000 934
🦄 Button.Fluent 0.12 0.2 0.6:1 5000 617
🔧 Checkbox.Fluent 0.63 0.36 1.75:1 1000 634
🎯 Dialog.Fluent 0.16 0.22 0.73:1 5000 810
🔧 Dropdown.Fluent 2.83 0.47 6.02:1 1000 2826
🔧 Icon.Fluent 0.16 0.06 2.67:1 5000 784
🎯 Image.Fluent 0.09 0.12 0.75:1 5000 427
🔧 Slider.Fluent 1.54 0.36 4.28:1 1000 1543
🔧 Text.Fluent 0.08 0.03 2.67:1 5000 394
🦄 Tooltip.Fluent 0.12 14.82 0.01:1 5000 590

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AccordionMinimalPerf.default 166 0 Infinity:1
AlertMinimalPerf.default 331 0 Infinity:1
AnimationMinimalPerf.default 433 0 Infinity:1
AttachmentMinimalPerf.default 176 0 Infinity:1
AttachmentSlotsPerf.default 1139 0 Infinity:1
AvatarMinimalPerf.default 503 0 Infinity:1
BoxMinimalPerf.default 407 0 Infinity:1
ButtonMinimalPerf.default 190 0 Infinity:1
ButtonOverridesMissPerf.default 1675 0 Infinity:1
ButtonSlotsPerf.default 639 0 Infinity:1
ButtonUseCssPerf.default 838 0 Infinity:1
ButtonUseCssNestingPerf.default 1090 0 Infinity:1
CardMinimalPerf.default 594 0 Infinity:1
CarouselMinimalPerf.default 471 0 Infinity:1
ChatDuplicateMessagesPerf.default 434 0 Infinity:1
ChatMinimalPerf.default 651 0 Infinity:1
ChatWithPopoverPerf.default 464 0 Infinity:1
CheckboxMinimalPerf.default 2847 0 Infinity:1
DialogMinimalPerf.default 820 0 Infinity:1
DividerMinimalPerf.default 417 0 Infinity:1
DropdownMinimalPerf.default 2866 0 Infinity:1
FlexMinimalPerf.default 333 0 Infinity:1
FormMinimalPerf.default 480 0 Infinity:1
GridMinimalPerf.default 391 0 Infinity:1
HeaderMinimalPerf.default 431 0 Infinity:1
HeaderSlotsPerf.default 848 0 Infinity:1
ImageMinimalPerf.default 418 0 Infinity:1
InputMinimalPerf.default 1298 0 Infinity:1
LayoutMinimalPerf.default 457 0 Infinity:1
ListMinimalPerf.default 538 0 Infinity:1
ListNestedPerf.default 610 0 Infinity:1
LoaderMinimalPerf.default 747 0 Infinity:1
MenuMinimalPerf.default 931 0 Infinity:1
MenuButtonMinimalPerf.default 1646 0 Infinity:1
PopupMinimalPerf.default 717 0 Infinity:1
PortalMinimalPerf.default 163 0 Infinity:1
ProviderMergeThemesPerf.default 1963 0 Infinity:1
ProviderMinimalPerf.default 970 0 Infinity:1
RadioGroupMinimalPerf.default 474 0 Infinity:1
ReactionMinimalPerf.default 455 0 Infinity:1
RefMinimalPerf.default 225 0 Infinity:1
SegmentMinimalPerf.default 403 0 Infinity:1
SkeletonMinimalPerf.default 473 0 Infinity:1
SliderMinimalPerf.default 1507 0 Infinity:1
SplitButtonMinimalPerf.default 3869 0 Infinity:1
IconMinimalPerf.default 737 0 Infinity:1
TableManyItemsPerf.default 2351 0 Infinity:1
TableMinimalPerf.default 438 0 Infinity:1
TextMinimalPerf.default 406 0 Infinity:1
CustomToolbarPrototype.default 3752 0 Infinity:1
ToolbarMinimalPerf.default 1017 0 Infinity:1
TooltipMinimalPerf.default 830 0 Infinity:1
TreeMinimalPerf.default 942 0 Infinity:1
TreeWith60ListItems.default 211 0 Infinity:1
VideoMinimalPerf.default 693 0 Infinity:1
Avatar.Fluent 934 0 Infinity:1
Button.Fluent 617 0 Infinity:1
Checkbox.Fluent 634 0 Infinity:1
Dropdown.Fluent 2826 0 Infinity:1
Icon.Fluent 784 0 Infinity:1
Image.Fluent 427 0 Infinity:1
Slider.Fluent 1543 0 Infinity:1
Text.Fluent 394 0 Infinity:1
Tooltip.Fluent 590 0 Infinity:1
EmbedMinimalPerf.default 1986 1 1986:1
ItemLayoutMinimalPerf.default 1393 1 1393:1
ListWith60ListItems.default 950 1 950:1
DropdownManyItemsPerf.default 810 1 810:1
Dialog.Fluent 810 1 810:1
StatusMinimalPerf.default 789 1 789:1
ListCommonPerf.default 691 1 691:1
TextAreaMinimalPerf.default 541 1 541:1
LabelMinimalPerf.default 454 1 454:1

@size-auditor
Copy link

size-auditor bot commented Oct 6, 2020 •
edited
Loading

Asset size changes

⚠️ Insufficient baseline data to detect size changes

Unable to find bundle size details for Baseline commit: ccc3a5a

Possible causes

  • The baseline build ccc3a5a is broken
  • The Size Auditor run for the baseline build ccc3a5a was not triggered

Recommendations

  • Please merge your branch for this Pull request with the latest master build and commit your changes once again

@dzearing dzearing merged commit ad2fdb0 into microsoft:7.0 Oct 6, 2020
@dzearing dzearing deleted the feat/variants-cherrypick branch October 6, 2020 16:56
@msft-github-bot
Copy link
Contributor

🎉[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉@uifabric/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@ecraig12345 ecraig12345 removed the needs cherry-pick Temporary label for PRs which may need to be cherry-picked to master label Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xugao xugao xugao approved these changes

@khmakoto khmakoto Awaiting requested review from khmakoto khmakoto is a code owner

Assignees

@tomi-msft tomi-msft

Labels
PR: Possible Perf Regression 🐌
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dzearing @ecraig12345 @msft-github-bot @xugao @tomi-msft