Avatar tests #15084
Merged
Avatar tests #15084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he Avatar stories
…, and add examples of badge icons.
…setting css values.
…an falling back to tokens
* Add a "customSize" prop for cases where the size doesn't match a design spec'ed size * Use "sizeClass" to determine the font and icon sizes for the avatar: if the avatar has a standard size, then the sizeClass is just the size; but if it's a custom size, then the sizeClass is the next-smaller standard size. * Use design tokens in Avatar styles * Update Avatar.stories to display every standard size for all display types * Add demo images pulled from the fluentui docs pages for the avatar instead of the fillmurray image
…der. Also add support for border tokens, for badges that want to add a border inside the glow.
…into avatar-visuals
ecraig12345
approved these changes
Sep 22, 2020
khmakoto
approved these changes
Sep 23, 2020
xugao
approved these changes
Sep 24, 2020
ecraig12345
reviewed
Sep 24, 2020
|
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
Add
screener,perf, snapshot, and unit tests for the Avatar component.Refactor some Avatar functionality for testability, and fix a few styling bugs in edge cases found through testing.