Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating react-next release notes for Button. #15055

Merged
merged 5 commits into from
Sep 17, 2020
Merged

Updating react-next release notes for Button. #15055

merged 5 commits into from
Sep 17, 2020

Conversation

dzearing
Copy link
Member

Just an initial set of updates for release notes.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 15, 2020 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@msft-github-bot
Copy link
Contributor

Perf Analysis

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 882 893 5000
ButtonNext mount 586 574 5000
Checkbox mount 1536 1546 5000
CheckboxBase mount 1287 1301 5000
CheckboxNext mount 1478 1500 5000
ChoiceGroup mount 4895 4872 5000
ChoiceGroupNext mount 4948 4924 5000
ComboBox mount 923 918 1000
CommandBar mount 7630 7667 1000
ContextualMenu mount 13200 13368 1000
DefaultButton mount 1093 1090 5000
DetailsRow mount 3522 3487 5000
DetailsRowFast mount 3539 3554 5000
DetailsRowNoStyles mount 3289 3339 5000
Dialog mount 1475 1472 1000
DocumentCardTitle mount 1867 1845 1000
Dropdown mount 2566 2555 5000
FocusZone mount 1836 1822 5000
IconButton mount 1733 1704 5000
Label mount 346 357 5000
Link mount 437 451 5000
LinkNext mount 464 460 5000
MenuButton mount 1442 1422 5000
MessageBar mount 2065 2075 5000
MessageBarNext mount 2017 2030 5000
Nav mount 3207 3205 1000
OverflowSet mount 1399 1384 5000
OverflowSetNext mount 1050 1055 5000
Panel mount 1423 1406 1000
Persona mount 826 823 1000
Pivot mount 1410 1421 1000
PivotNext mount 1384 1388 1000
PrimaryButton mount 1226 1252 5000
Rating mount 7432 7498 5000
RatingNext mount 7515 7383 5000
SearchBox mount 1236 1266 5000
SearchBoxNext mount 1300 1315 5000
Shimmer mount 2572 2557 5000
ShimmerNext mount 2522 2511 5000
Slider mount 1481 1471 5000
SliderNext mount 1911 1901 5000
SpinButton mount 4912 4939 5000
SpinButtonNext mount 5033 4950 5000
Spinner mount 415 428 5000
SplitButton mount 3117 3047 5000
Stack mount 523 517 5000
StackWithIntrinsicChildren mount 1950 1912 5000
StackWithTextChildren mount 4963 4914 5000
SwatchColorPicker mount 10074 10043 5000
SwatchColorPickerNext mount 9983 9987 5000
TagPicker mount 2751 2712 5000
TeachingBubble mount 50717 51256 5000
TeachingBubbleNext mount 48782 49105 5000
Text mount 407 403 5000
TextField mount 1289 1302 5000
ThemeProvider mount 4653 4672 5000
ThemeProvider virtual-rerender 497 482 5000
Toggle mount 780 791 5000
ToggleNext mount 750 767 5000
button mount 108 107 5000

Perf Analysis (Fluent)

⚠️ 5 potential perf regressions detected

Potential regressions comparing to master

Scenario Current PR Ticks Baseline Ticks Ratio Regression Analysis
ButtonOverridesMissPerf.default 1692 43 39.35:1 analysis
ButtonUseCssNestingPerf.default 1090 43 25.35:1 analysis
ButtonUseCssPerf.default 812 43 18.88:1 analysis
ChatWithPopoverPerf.default 473 453 1.04:1 analysis
ListCommonPerf.default 675 925 0.73:1 analysis
Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🎯 Avatar.Fluent 0.44 0.48 0.92:1 2000 885
🦄 Button.Fluent 0.12 0.19 0.63:1 5000 592
🔧 Checkbox.Fluent 0.64 0.36 1.78:1 1000 643
🎯 Dialog.Fluent 0.16 0.22 0.73:1 5000 795
🔧 Dropdown.Fluent 2.95 0.48 6.15:1 1000 2946
🔧 Icon.Fluent 0.14 0.06 2.33:1 5000 725
🦄 Image.Fluent 0.08 0.12 0.67:1 5000 397
🔧 Slider.Fluent 1.61 0.35 4.6:1 1000 1610
🔧 Text.Fluent 0.08 0.04 2:1 5000 381
🦄 Tooltip.Fluent 0.11 16.03 0.01:1 5000 567

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
PortalMinimalPerf.default 176 120 1.47:1
RefMinimalPerf.default 266 198 1.34:1
FlexMinimalPerf.default 320 265 1.21:1
AccordionMinimalPerf.default 166 139 1.19:1
HeaderMinimalPerf.default 400 335 1.19:1
AttachmentMinimalPerf.default 172 147 1.17:1
BoxMinimalPerf.default 387 331 1.17:1
DividerMinimalPerf.default 397 339 1.17:1
ImageMinimalPerf.default 416 355 1.17:1
TextMinimalPerf.default 377 323 1.17:1
Image.Fluent 397 340 1.17:1
GridMinimalPerf.default 357 308 1.16:1
LayoutMinimalPerf.default 446 383 1.16:1
RadioGroupMinimalPerf.default 454 392 1.16:1
ButtonMinimalPerf.default 186 162 1.15:1
ChatMinimalPerf.default 661 573 1.15:1
FormMinimalPerf.default 434 376 1.15:1
LabelMinimalPerf.default 445 386 1.15:1
StatusMinimalPerf.default 733 639 1.15:1
TableMinimalPerf.default 443 385 1.15:1
Button.Fluent 592 515 1.15:1
Text.Fluent 381 331 1.15:1
SegmentMinimalPerf.default 379 333 1.14:1
SkeletonMinimalPerf.default 433 381 1.14:1
AnimationMinimalPerf.default 431 384 1.12:1
Tooltip.Fluent 567 505 1.12:1
CardMinimalPerf.default 586 527 1.11:1
ReactionMinimalPerf.default 426 383 1.11:1
PopupMinimalPerf.default 720 652 1.1:1
ProviderMinimalPerf.default 997 912 1.09:1
IconMinimalPerf.default 697 639 1.09:1
ButtonSlotsPerf.default 618 574 1.08:1
CarouselMinimalPerf.default 467 432 1.08:1
MenuMinimalPerf.default 879 814 1.08:1
TextAreaMinimalPerf.default 484 447 1.08:1
TooltipMinimalPerf.default 830 766 1.08:1
Icon.Fluent 725 674 1.08:1
HeaderSlotsPerf.default 798 746 1.07:1
ListMinimalPerf.default 511 478 1.07:1
ProviderMergeThemesPerf.default 2065 1927 1.07:1
TreeMinimalPerf.default 892 831 1.07:1
ItemLayoutMinimalPerf.default 1310 1231 1.06:1
MenuButtonMinimalPerf.default 1591 1497 1.06:1
ToolbarMinimalPerf.default 962 911 1.06:1
Dialog.Fluent 795 751 1.06:1
Avatar.Fluent 885 846 1.05:1
Checkbox.Fluent 643 611 1.05:1
AttachmentSlotsPerf.default 1180 1133 1.04:1
DialogMinimalPerf.default 783 753 1.04:1
CustomToolbarPrototype.default 3872 3710 1.04:1
AvatarMinimalPerf.default 477 464 1.03:1
CheckboxMinimalPerf.default 2881 2798 1.03:1
EmbedMinimalPerf.default 1897 1846 1.03:1
InputMinimalPerf.default 1332 1291 1.03:1
LoaderMinimalPerf.default 758 738 1.03:1
AlertMinimalPerf.default 291 286 1.02:1
DropdownManyItemsPerf.default 759 743 1.02:1
DropdownMinimalPerf.default 2999 2936 1.02:1
TableManyItemsPerf.default 2162 2112 1.02:1
ChatDuplicateMessagesPerf.default 417 412 1.01:1
SplitButtonMinimalPerf.default 3741 3720 1.01:1
TreeWith60ListItems.default 211 209 1.01:1
VideoMinimalPerf.default 612 605 1.01:1
Slider.Fluent 1610 1588 1.01:1
SliderMinimalPerf.default 1598 1607 0.99:1
Dropdown.Fluent 2946 2963 0.99:1
ListWith60ListItems.default 967 1077 0.9:1
ListNestedPerf.default 583 858 0.68:1

@size-auditor
Copy link

size-auditor bot commented Sep 15, 2020

Asset size changes

⚠️ Insufficient baseline data to detect size changes

Unable to find bundle size details for Baseline commit: a17c428

Possible causes

  • The baseline build a17c428 is broken
  • The Size Auditor run for the baseline build a17c428 was not triggered

Recommendations

  • Please merge your branch for this Pull request with the latest master build and commit your changes once again

khmakoto
khmakoto approved these changes Sep 15, 2020
View reviewed changes
@dzearing dzearing merged commit 4993219 into microsoft:master Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khmakoto khmakoto khmakoto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dzearing @msft-github-bot @khmakoto