Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use gzip for screener task #15051

Merged
merged 3 commits into from
Sep 16, 2020
Merged

chore: use gzip for screener task #15051

merged 3 commits into from
Sep 16, 2020

Conversation

layershifter
Copy link
Member

@layershifter layershifter commented Sep 15, 2020 •
edited
Loading

Adds GZIP compression and cache headers for artifacts deployed for Screener.

Before

image

After

image

image

@layershifter layershifter reopened this Sep 15, 2020
@layershifter layershifter reopened this Sep 15, 2020
@layershifter layershifter reopened this Sep 15, 2020
@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 15, 2020 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4238fec:

Sandbox Source
Fluent UI Button Configuration
microsoft/fluentui: codesandbox-react-template Configuration
microsoft/fluentui: codesandbox-react-next-template Configuration
microsoft/fluentui: codesandbox-react-northstar-template Configuration

@msft-github-bot
Copy link
Contributor

msft-github-bot commented Sep 15, 2020 •
edited
Loading

Perf Analysis

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 871 876 5000
ButtonNext mount 622 589 5000
Checkbox mount 1558 1567 5000
CheckboxBase mount 1330 1280 5000
CheckboxNext mount 1553 1529 5000
ChoiceGroup mount 5010 5006 5000
ChoiceGroupNext mount 4928 4916 5000
ComboBox mount 918 925 1000
CommandBar mount 7684 7665 1000
ContextualMenu mount 14197 13905 1000
DefaultButton mount 1128 1137 5000
DetailsRow mount 3544 3551 5000
DetailsRowFast mount 3570 3483 5000
DetailsRowNoStyles mount 3403 3297 5000
Dialog mount 1498 1471 1000
DocumentCardTitle mount 1857 1841 1000
Dropdown mount 2569 2568 5000
FocusZone mount 1837 1817 5000
IconButton mount 1720 1722 5000
Label mount 356 353 5000
Link mount 451 451 5000
LinkNext mount 470 475 5000
MenuButton mount 1457 1474 5000
MessageBar mount 2085 2073 5000
MessageBarNext mount 2113 2121 5000
Nav mount 3219 3292 1000
OverflowSet mount 1423 1416 5000
OverflowSetNext mount 1055 1065 5000
Panel mount 1447 1470 1000
Persona mount 830 843 1000
Pivot mount 1432 1457 1000
PivotNext mount 1423 1380 1000
PrimaryButton mount 1272 1289 5000
Rating mount 7625 7671 5000
RatingNext mount 7528 7546 5000
SearchBox mount 1325 1276 5000
SearchBoxNext mount 1327 1315 5000
Shimmer mount 2573 2600 5000
ShimmerNext mount 2463 2526 5000
Slider mount 1492 1534 5000
SliderNext mount 1934 1888 5000
SpinButton mount 4960 4948 5000
SpinButtonNext mount 5080 5135 5000
Spinner mount 417 437 5000
SplitButton mount 3149 3143 5000
Stack mount 555 523 5000
StackWithIntrinsicChildren mount 1995 1940 5000
StackWithTextChildren mount 4999 4976 5000
SwatchColorPicker mount 10351 10311 5000
SwatchColorPickerNext mount 10236 10274 5000
TagPicker mount 2794 2848 5000
TeachingBubble mount 51311 51603 5000
TeachingBubbleNext mount 51229 51365 5000
Text mount 439 418 5000
TextField mount 1380 1402 5000
ThemeProvider mount 4952 4965 5000
ThemeProvider virtual-rerender 504 523 5000
Toggle mount 848 853 5000
ToggleNext mount 823 791 5000
button mount 115 111 5000

Perf Analysis (Fluent)

⚠️ 5 potential perf regressions detected

Potential regressions comparing to master

Scenario Current PR Ticks Baseline Ticks Ratio Regression Analysis
ButtonOverridesMissPerf.default 1721 37 46.51:1 analysis
ButtonUseCssNestingPerf.default 1131 44 25.7:1 analysis
ButtonUseCssPerf.default 848 44 19.27:1 analysis
ChatWithPopoverPerf.default 480 464 1.03:1 analysis
ListCommonPerf.default 666 902 0.74:1 analysis
Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🎯 Avatar.Fluent 0.44 0.49 0.9:1 2000 880
🦄 Button.Fluent 0.11 0.19 0.58:1 5000 564
🔧 Checkbox.Fluent 0.65 0.36 1.81:1 1000 649
🎯 Dialog.Fluent 0.16 0.23 0.7:1 5000 807
🔧 Dropdown.Fluent 2.98 0.46 6.48:1 1000 2977
🔧 Icon.Fluent 0.15 0.06 2.5:1 5000 734
🎯 Image.Fluent 0.08 0.11 0.73:1 5000 417
🔧 Slider.Fluent 1.61 0.37 4.35:1 1000 1614
🔧 Text.Fluent 0.08 0.03 2.67:1 5000 377
🦄 Tooltip.Fluent 0.12 18.22 0.01:1 5000 598

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
PortalMinimalPerf.default 166 122 1.36:1
Image.Fluent 417 340 1.23:1
RefMinimalPerf.default 251 208 1.21:1
BoxMinimalPerf.default 398 332 1.2:1
HeaderMinimalPerf.default 388 324 1.2:1
FlexMinimalPerf.default 310 262 1.18:1
Text.Fluent 377 320 1.18:1
Tooltip.Fluent 598 513 1.17:1
GridMinimalPerf.default 372 321 1.16:1
SegmentMinimalPerf.default 391 339 1.15:1
StatusMinimalPerf.default 755 655 1.15:1
TextMinimalPerf.default 371 323 1.15:1
AccordionMinimalPerf.default 165 145 1.14:1
ButtonMinimalPerf.default 191 167 1.14:1
ChatMinimalPerf.default 652 573 1.14:1
ListMinimalPerf.default 497 437 1.14:1
SkeletonMinimalPerf.default 453 398 1.14:1
AnimationMinimalPerf.default 433 382 1.13:1
LayoutMinimalPerf.default 430 380 1.13:1
RadioGroupMinimalPerf.default 440 390 1.13:1
TextAreaMinimalPerf.default 505 445 1.13:1
IconMinimalPerf.default 706 628 1.12:1
Icon.Fluent 734 658 1.12:1
AlertMinimalPerf.default 309 278 1.11:1
AttachmentMinimalPerf.default 166 149 1.11:1
CarouselMinimalPerf.default 472 429 1.1:1
ReactionMinimalPerf.default 423 386 1.1:1
DividerMinimalPerf.default 379 349 1.09:1
TableMinimalPerf.default 427 393 1.09:1
CardMinimalPerf.default 585 540 1.08:1
FormMinimalPerf.default 416 385 1.08:1
PopupMinimalPerf.default 725 671 1.08:1
ProviderMinimalPerf.default 998 920 1.08:1
ToolbarMinimalPerf.default 997 919 1.08:1
Button.Fluent 564 520 1.08:1
Dialog.Fluent 807 749 1.08:1
DialogMinimalPerf.default 811 761 1.07:1
TooltipMinimalPerf.default 839 784 1.07:1
HeaderSlotsPerf.default 808 763 1.06:1
MenuMinimalPerf.default 883 832 1.06:1
ProviderMergeThemesPerf.default 2019 1909 1.06:1
TreeMinimalPerf.default 896 843 1.06:1
VideoMinimalPerf.default 654 615 1.06:1
ImageMinimalPerf.default 391 371 1.05:1
InputMinimalPerf.default 1362 1298 1.05:1
LabelMinimalPerf.default 427 405 1.05:1
MenuButtonMinimalPerf.default 1578 1507 1.05:1
AvatarMinimalPerf.default 483 465 1.04:1
DropdownManyItemsPerf.default 779 747 1.04:1
ItemLayoutMinimalPerf.default 1285 1234 1.04:1
CheckboxMinimalPerf.default 2922 2828 1.03:1
EmbedMinimalPerf.default 1952 1892 1.03:1
Avatar.Fluent 880 853 1.03:1
AttachmentSlotsPerf.default 1161 1140 1.02:1
SplitButtonMinimalPerf.default 3773 3714 1.02:1
ButtonSlotsPerf.default 605 597 1.01:1
ChatDuplicateMessagesPerf.default 416 417 1:1
DropdownMinimalPerf.default 3013 3015 1:1
CustomToolbarPrototype.default 3803 3819 1:1
Dropdown.Fluent 2977 2980 1:1
LoaderMinimalPerf.default 743 747 0.99:1
TableManyItemsPerf.default 2156 2170 0.99:1
TreeWith60ListItems.default 203 206 0.99:1
Slider.Fluent 1614 1626 0.99:1
SliderMinimalPerf.default 1615 1655 0.98:1
Checkbox.Fluent 649 659 0.98:1
ListWith60ListItems.default 939 1069 0.88:1
ListNestedPerf.default 588 838 0.7:1

@size-auditor
Copy link

size-auditor bot commented Sep 15, 2020 •
edited
Loading

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 006119f081a05d4d4dcb65014aef043874992f87 (build)

@layershifter layershifter reopened this Sep 16, 2020
@layershifter layershifter merged commit 9fc6345 into master Sep 16, 2020
@layershifter layershifter deleted the chore/gzip branch September 16, 2020 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ecraig12345 ecraig12345 ecraig12345 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@layershifter @msft-github-bot @ecraig12345