-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge branch 'chore/react-18-support' into bsunderhus/react-utilities…
…/chore--slot-API-react-v17/18-support * chore/react-18-support: (516 commits) update some deps to React 18 test(react-color-picker): Added cy and a11y tests for sliders (#33609) fix(react-charting): Centre align Gauge chart (#33710) fix(vr-tests): set a fixed value for culture prop in charts (#33690) release: applying package updates - react v8 feat(react-charting): Heatmap text color based on Contrast Ratio (#33659) test(color-picker): Added VR tests for ColorSlider and AlphaSlider (#33672) fix: remove forced synchronous layout in Drawer (#33665) feat(declarative-chart): Support for Dashed and Dotted lines (#33694) release: applying package updates - react-components feat: add vite sandbox template (#33631) ci: trigger VRT PR workflow only against testing branch (#33701) chore(deps-dev): bump vite from 6.0.7 to 6.0.9 (#33698) release: applying package updates - react v8 BaseFloatingPicker - Release references held by Async (#33685) feature(react-tag-picker): single line layout (#32247) feature(react-tree): introduces navigationMode property (#33658) bugfix: secondaryContent not displaying properly (#33689) release: applying package updates - react v8 fix(react-charting): resolve overlapping bars issue in histogram (#33695) ...
- Loading branch information
Showing
3,749 changed files
with
293,006 additions
and
96,917 deletions.
The diff you're trying to view is too large. We only load the first 3000 changed files.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
parameters: | ||
- name: version | ||
type: string | ||
default: 8 | ||
|
||
steps: | ||
- task: AzureCLI@2 | ||
displayName: 'Copy website drop to Azure' | ||
inputs: | ||
azureSubscription: 'Azure - fabricweb storage - NEW' | ||
scriptType: 'bash' | ||
scriptLocation: inlineScript | ||
inlineScript: | | ||
az storage blob upload-batch \ | ||
--destination 'fabric-website' \ | ||
--source $(System.DefaultWorkingDirectory)/apps/public-docsite/dist \ | ||
--account-name fabricweb \ | ||
--destination-path v${{ parameters.version }}/$(Build.BuildNumber)/ \ | ||
--auth-mode login \ | ||
--overwrite | ||
- task: AzureCLI@2 | ||
displayName: 'Update dogfood manifest in Azure blob' | ||
inputs: | ||
azureSubscription: 'Azure - fabricweb storage - NEW' | ||
scriptType: 'bash' | ||
scriptLocation: inlineScript | ||
inlineScript: | | ||
az storage blob upload \ | ||
--account-name fabricweb \ | ||
--container-name fabric-website \ | ||
--name manifests/v${{ parameters.version }}-df.js \ | ||
--file $(System.DefaultWorkingDirectory)/site-manifests/v${{ parameters.version }}-df.js \ | ||
--auth-mode login \ | ||
--overwrite | ||
- task: AzureCLI@2 | ||
displayName: 'Update prod manifest in Azure blob' | ||
inputs: | ||
azureSubscription: 'Azure - fabricweb storage - NEW' | ||
scriptType: 'bash' | ||
scriptLocation: inlineScript | ||
inlineScript: | | ||
az storage blob upload \ | ||
--account-name fabricweb \ | ||
--container-name fabric-website \ | ||
--name manifests/v${{ parameters.version }}-prod.js \ | ||
--file $(System.DefaultWorkingDirectory)/site-manifests/v${{ parameters.version }}-prod.js \ | ||
--auth-mode login \ | ||
--overwrite |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -67,7 +67,7 @@ steps: | |
|
||
- bash: | | ||
set -exuo pipefail | ||
npx [email protected].5 create-policy --nonBlockingPipelines '{"$(pipelineId)":{"pipelineStatus": "PENDING","pipelineName": "$(pipelineName)"}}' --clientType 'FLUENTUI' | ||
npx [email protected].11 create-policy --nonBlockingPipelines '{"$(pipelineId)":{"pipelineStatus": "PENDING","pipelineName": "$(pipelineName)"}}' --clientType 'FLUENTUI' | ||
displayName: VR App - Create Policy | ||
env: | ||
VR_APP_API_URL: $(VR_APP_API_URL) | ||
|
@@ -94,5 +94,5 @@ steps: | |
scriptLocation: 'inlineScript' | ||
# ciDefinitionId is set to 205 because that is the ID of the baseline pipeline (https://uifabric.visualstudio.com/fabricpublic/_build?definitionId=205) used by the master branch | ||
inlineScript: | | ||
npx [email protected].5 run-diff --screenshotsDirectory ./screenshots --buildType pr --clientType "FLUENTUI" --ciDefinitionId 205 --groupName $(pipelineName) --locationPrefix ${{ parameters.locationPrefix }} --locationPostfix ${{ parameters.locationPostfix }} --pipelineId $(pipelineId) --clientName ${{ parameters.clientName }} --threshold '0.04' --cumThreshold '1' | ||
npx [email protected].11 run-diff --screenshotsDirectory ./screenshots --buildType pr --clientType "FLUENTUI" --ciDefinitionId 205 --groupName $(pipelineName) --locationPrefix ${{ parameters.locationPrefix }} --locationPostfix ${{ parameters.locationPostfix }} --pipelineId $(pipelineId) --clientName ${{ parameters.clientName }} --threshold '0.04' --cumThreshold '1' | ||
condition: and(eq(variables.isPR, true), eq(variables['vrTestSkip'], 'no')) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
#!/bin/sh | ||
|
||
changedFiles="$(git diff-tree -r --name-only --no-commit-id $1 $2)" | ||
node ./scripts/package-manager/src/notify-lockfile-changes.js $changedFiles | ||
node ./scripts/package-manager/src/notify-on-file-changes.js $changedFiles |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
#!/bin/sh | ||
|
||
changedFiles="$(git diff-tree -r --name-only --no-commit-id ORIG_HEAD HEAD)" | ||
node ./scripts/package-manager/src/notify-lockfile-changes.js $changedFiles | ||
node ./scripts/package-manager/src/notify-on-file-changes.js $changedFiles |
Large diffs are not rendered by default.
Oops, something went wrong.
239 changes: 239 additions & 0 deletions
239
.github/ISSUE_TEMPLATE/01-react-components-bug-report.yml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,239 @@ | ||
name: '⚛️ React Components (v9) - 🐞 Bug Report' | ||
description: File a bug report. | ||
title: '[Bug]: ' | ||
labels: ['Type: Bug :bug:', 'Needs: Triage :mag:', 'Fluent UI react-components (v9)'] | ||
projects: ['microsoft/395'] | ||
assignees: [] | ||
body: | ||
- type: markdown | ||
attributes: | ||
value: | | ||
Thanks for taking the time to fill out this bug report! | ||
- type: dropdown | ||
id: component-id | ||
attributes: | ||
label: Component | ||
description: | | ||
Which Component/Utility is affected | ||
> 💡 available options align with our docs menu https://react.fluentui.dev/ | ||
options: | ||
- Accordion | ||
- Avatar | ||
- AvatarGroup | ||
- Badge | ||
- Breadcrumb | ||
- Button | ||
- Card | ||
- CardFooter | ||
- CardHeader | ||
- CardPreview | ||
- Carousel | ||
- CarouselNav | ||
- Checkbox | ||
- Combobox | ||
- CompoundButton | ||
- Counter Badge | ||
- DataGrid | ||
- Dialog | ||
- Divider | ||
- Drawer | ||
- Dropdown | ||
- Field | ||
- FluentProvider | ||
- Image | ||
- InfoLabel | ||
- Input | ||
- InteractionTag | ||
- Label | ||
- Link | ||
- List | ||
- Menu | ||
- MenuButton | ||
- MenuList | ||
- MessageBar | ||
- Overflow | ||
- Persona | ||
- Popover | ||
- Portal | ||
- PresenceBadge | ||
- ProgressBar | ||
- RadioGroup | ||
- Rating | ||
- RatingDisplay | ||
- SearchBox | ||
- Select | ||
- Skeleton | ||
- Slider | ||
- SpinButton | ||
- Spinner | ||
- SplitButton | ||
- SwatchPicker | ||
- Switch | ||
- TabList | ||
- Table | ||
- Tag | ||
- TagGroup | ||
- TagPicker | ||
- TeachingPopover | ||
- Text | ||
- Textarea | ||
- Toast | ||
- ToggleButton | ||
- Toolbar | ||
- Tooltip | ||
- Tree | ||
- ColorPicker (Preview) | ||
- Nav (Preview) | ||
- Virtualizer (Preview) | ||
- VirtualizerScrollView (Preview) | ||
- VirtualizerScrollViewDynamic (Preview) | ||
- Calendar (Compat) | ||
- DatePicker (Compat) | ||
- TimePicker (Compat) | ||
- Icons | ||
- Migration Shims V0 | ||
- Migration Shims V8 | ||
- Motion | ||
- Theme | ||
- Tokens | ||
- Utilities | ||
- Other... | ||
validations: | ||
required: true | ||
|
||
- type: input | ||
id: pkg-version | ||
attributes: | ||
label: Package version | ||
description: | | ||
Which version of react-components are you using? | ||
placeholder: e.g. 9.42.0 | ||
validations: | ||
required: true | ||
|
||
- type: input | ||
id: react-version | ||
attributes: | ||
label: React version | ||
description: | | ||
Which version of React are you using? | ||
placeholder: e.g. 17.0.2 | ||
validations: | ||
required: true | ||
|
||
- type: textarea | ||
id: env-info | ||
attributes: | ||
label: Environment | ||
description: | | ||
Output of `npx envinfo@latest --system --browsers --npmPackages '{@fluentui/*,react,react-dom,@types/react{,-dom}}'` | ||
NOTE 💡: This will be automatically formatted as a code block, so no need for backticks. | ||
render: shell | ||
validations: | ||
required: true | ||
|
||
- type: textarea | ||
id: current-behavior | ||
attributes: | ||
label: Current Behavior | ||
description: | | ||
What is the current behavior that you are experiencing? | ||
validations: | ||
required: true | ||
|
||
- type: textarea | ||
id: expected-behavior | ||
attributes: | ||
label: Expected Behavior | ||
description: | | ||
What is the behavior that you expect to happen? | ||
validations: | ||
required: true | ||
|
||
- type: input | ||
id: reproduction-link | ||
attributes: | ||
label: Reproduction | ||
description: | | ||
A link to a Stackblitz reproduction which demonstrates the bug - https://stackblitz.com/ | ||
> 💡 You can export to Stackblitz any example from docs (https://react.fluentui.dev/) with "Open In StackBlitz" button and update it to reproduce an issue. | ||
**NOTE:** | ||
A [minimal reproduction](https://stackoverflow.com/help/minimal-reproducible-example) is required. | ||
If a report is vague (e.g. just a generic error message) and has no reproduction, it will receive a "need reproduction" label. | ||
‼️ If no reproduction is provided after 3 days, it will be auto-closed. ‼️ | ||
validations: | ||
required: true | ||
|
||
- type: textarea | ||
id: reproduction-steps | ||
attributes: | ||
label: Steps to reproduce | ||
description: Explain how to cause the issue in the provided reproduction. | ||
placeholder: | | ||
1. Go to '...' | ||
2. Click on '...' | ||
3. Scroll down to '...' | ||
4. See error | ||
validations: | ||
required: true | ||
|
||
- type: dropdown | ||
id: a11y-bug | ||
attributes: | ||
label: Are you reporting an Accessibility issue? | ||
description: | | ||
**PLEASE NOTE:** | ||
1. Do not link to, screenshot, or reference a Microsoft product in this description. | ||
2. Please check ARIA component examples to ensure it is not a screen reader or browser issue. If the issue concerns screen reader behavior that reproduces on HTML elements or ARIA Practices examples (https://w3c.github.io/aria-practices/), it should be filed with the respective browser or screen reading software and not the Fluent UI repo. | ||
3. There is documentation or best practice info to support your expected behavior (review https://w3c.github.io/aria/ for accessibility guidance.) | ||
**Additional note for Microsoft employees:** | ||
Please file accessibility issues in our internal tracker (http://aka.ms/fluentui-a11y). This helps with tracking accessibility progress within the company. | ||
options: | ||
- 'yes' | ||
- 'no' | ||
|
||
- type: dropdown | ||
id: request-priority | ||
attributes: | ||
label: Suggested severity | ||
options: | ||
- Urgent - No workaround and Products/sites are affected | ||
- High - No workaround | ||
- Medium - Has workaround | ||
- Low - Has or doesn't need a workaround | ||
validations: | ||
required: true | ||
|
||
- type: input | ||
id: products-affected | ||
attributes: | ||
label: Products/sites affected | ||
placeholder: (provide if applicable) | ||
|
||
- type: dropdown | ||
id: open-to-contribute | ||
attributes: | ||
label: Are you willing to submit a PR to fix? | ||
options: | ||
- 'yes' | ||
- 'no' | ||
validations: | ||
required: true | ||
|
||
- type: checkboxes | ||
id: checkboxes | ||
attributes: | ||
label: Validations | ||
description: Before submitting the issue, please make sure you do the following | ||
options: | ||
- label: Check that there isn't already an issue that reports the same bug to avoid creating a duplicate. | ||
required: true | ||
- label: The provided reproduction is a minimal reproducible example of the bug. | ||
required: true |
Oops, something went wrong.