-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SQL search renaming/refactoring #1569
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ivanidzo4ka
reviewed
Jan 6, 2021
Ivanidzo4ka
reviewed
Jan 7, 2021
src/Microsoft.Health.Fhir.SqlServer/Features/Search/SearchParameterColumnLocation.cs
Outdated
Show resolved
Hide resolved
Ivanidzo4ka
reviewed
Jan 7, 2021
src/Microsoft.Health.Fhir.SqlServer/Features/Search/Expressions/SqlRootExpression.cs
Outdated
Show resolved
Hide resolved
Ivanidzo4ka
reviewed
Jan 7, 2021
...rosoft.Health.Fhir.SqlServer/Features/Search/Expressions/Visitors/ChainFlatteningRewriter.cs
Outdated
Show resolved
Hide resolved
…ParamTableExpressions and SqlRootExpression.ResourceExpressions -> SqlRootExpression.ResourceTableExpressions
Ivanidzo4ka
reviewed
Jan 11, 2021
...Server/Features/Search/Expressions/Visitors/QueryGenerators/SearchParameterQueryGenerator.cs
Show resolved
Hide resolved
Ivanidzo4ka
reviewed
Jan 11, 2021
{ | ||
// if only Include expressions, the case is handled in IncludeMatchSeedRewriter | ||
return expression; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: maybe it's worth to push that check directly into IncludeMatchSeedRewriter
as a static method?
Ivanidzo4ka
reviewed
Jan 11, 2021
...osoft.Health.Fhir.SqlServer/Features/Search/Expressions/Visitors/IncludeMatchSeedRewriter.cs
Show resolved
Hide resolved
Ivanidzo4ka
approved these changes
Jan 12, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR intends to simplify the code for SQL search by eliminating "Normalized" and "Denormalized" concepts. These were meant to represent columns that were on the search parameter tables and the Resource table, respectively, but created confusion because some (but not all) denormalized columns were also on the search parameter tables.
SearchParameterColumnLocation
enum to identify where the columns for a search parameter reside.SqlRootExpression
has propertiesTableExpressions
andResourceExpressions
instead ofTableExpressions
andDenormalizedExpressions
.TableExpression
consolidatesNormalizedPredicate
andDenormalizedPredicate
properties into a singlePredicate
property.SqlChainLinkExpression
, which is created fromChainExpressions
but includes aExpressionOnSource
property. This means we can get rid ofTableExpression.DenormalizedPredicateOnChainRoot
, which polluted theTableExpression
class with a concept that only applies to chaining.There should not be any functional changes with in this PR. It is strictly a refactoring (well, mostly a renaming).