Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[users/chhol/convert-karma-tests-to-web-test-runner] Upgrade Playwright to ^1.39.0 #6863

Closed
wants to merge 17 commits into from
Closed

[users/chhol/convert-karma-tests-to-web-test-runner] Upgrade Playwright to ^1.39.0 #6863

wants to merge 17 commits into from

Conversation

radium-v
Copy link
Collaborator

Pull Request

📖 Description

Upgrades @playwright/test to ^1.39.0 on branch users/chhol/convert-karma-tests-to-web-test-runner.

🎫 Issues

Merges into #6847.

👩‍💻 Reviewer Notes

@microsoft/fast-ssr throws an error when buidling with any version of tslib that isn't 2.4.0. This PR also locks [email protected] in that package.

radium-v and others added 17 commits November 10, 2023 15:28
@radium-v
fix: rtl scroll converter test asserting incorrect values (#6859)
fd65254 
* Revert "fix: RtlScrollConverter test on high dpi systems in fast-web-utilities (#6857)"

This reverts commit a7a3c89.

* force 1x display scale factor in karma

* fix RtlScrollConverter test

- Chromium reports 0.5
- Webkit and Firefox both report 0

* Change files
@chrisdholt @radium-v
initial update to use web-test-runner
b9d98fa
@chrisdholt @radium-v
update fast-element to use sinon spies
2ac173d
@chrisdholt @radium-v
update fast-foundation deps
d45a712
@chrisdholt @radium-v
update web utilities
afd8166
@chrisdholt @radium-v
setup tests for react-wrapper
5cb2608
@chrisdholt @radium-v
update router testing
838533d
@chrisdholt @radium-v
update fast-colors tests
e61a09f
@chrisdholt @radium-v
cleanup
33cb7b0
@chrisdholt @radium-v
Change files
feb0b1a
@chrisdholt @radium-v
workflow updates for playwright
c6daee1
@chrisdholt @radium-v
update playwright version
e147850
@chrisdholt @radium-v
fixup playwright tests based on latest assertions
9367c55
@chrisdholt @radium-v
Change files
3af8f08
@chrisdholt @radium-v
run chromium only for everything but foundation
261acfc
@chrisdholt @radium-v
await repeat tests, fix incorrect import in router, attempt longer ti…
7645b84 
…meout in router tests
@radium-v
upgrade playwright, dedupe lockfile
3c3cdb5 
- fast-ssr will throw an error with any other version of tslib, so it gets locked to 2.4.0
@radium-v radium-v closed this Feb 13, 2024
@radium-v radium-v deleted the users/jokreitl/convert-karma-tests-to-web-test-runner branch February 13, 2024 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisdholt chrisdholt chrisdholt approved these changes

@janechu janechu Awaiting requested review from janechu janechu will be requested when the pull request is marked ready for review janechu is a code owner

@awentzel awentzel Awaiting requested review from awentzel awentzel will be requested when the pull request is marked ready for review awentzel is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@radium-v @chrisdholt