Include <chrono>
for system_clock
#1811
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've merged microsoft/STL#5105, which revealed a conformance issue in cpprestsdk.
Compiler error with this STL change:
Affected cpprestsdk code:
cpprestsdk/Release/tests/common/UnitTestpp/src/TestRunner.cpp
Lines 173 to 175 in 411a109
The problem is that cpprestsdk was assuming that including
<future>
makeschrono::system_clock
available, which is not guaranteed by the C++ Standard. This file needs to explicitly include<chrono>
.