-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Register VS Code built-in packages as skipped #1348
Register VS Code built-in packages as skipped #1348
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1348 +/- ##
=======================================
- Coverage 89.6% 89.3% -0.4%
=======================================
Files 384 384
Lines 29963 30156 +193
Branches 1835 1841 +6
=======================================
+ Hits 26875 26951 +76
- Misses 2698 2812 +114
- Partials 390 393 +3 ☔ View full report in Codecov by Sentry. |
src/Microsoft.ComponentDetection.Detectors/npm/NpmComponentDetector.cs
Outdated
Show resolved
Hide resolved
👋 Hi! It looks like you modified some files in the
If none of the above scenarios apply, feel free to ignore this comment 🙂 |
This PR modifies the existing NPM component detector to skip components corresponding to VS Code built-in extensions in order to reduce false positives while scanning the VS Code repository.
Example component that should not be flagged: https://github.com/microsoft/vscode/blob/main/extensions/handlebars/package.json
New Detector Checklist
IDefaultOffComponentDetector