Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register VS Code built-in packages as skipped #1348

Merged
merged 3 commits into from
Feb 4, 2025

Conversation

rzhao271
Copy link
Contributor

@rzhao271 rzhao271 commented Jan 22, 2025

This PR modifies the existing NPM component detector to skip components corresponding to VS Code built-in extensions in order to reduce false positives while scanning the VS Code repository.

Example component that should not be flagged: https://github.com/microsoft/vscode/blob/main/extensions/handlebars/package.json

New Detector Checklist

  • I have gone through the docs for creating a new detector here
  • My new detector implements IDefaultOffComponentDetector
  • I have created a PR to the verification repo with components that my new detector can find
  • (If necessary) I have updated the Feature Overview table in the README

@rzhao271 rzhao271 requested a review from a team as a code owner January 22, 2025 23:04
@rzhao271 rzhao271 requested a review from melotic January 22, 2025 23:04
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.3%. Comparing base (269fb53) to head (fa24d37).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1348     +/-   ##
=======================================
- Coverage   89.6%   89.3%   -0.4%     
=======================================
  Files        384     384             
  Lines      29963   30156    +193     
  Branches    1835    1841      +6     
=======================================
+ Hits       26875   26951     +76     
- Misses      2698    2812    +114     
- Partials     390     393      +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rzhao271 rzhao271 requested a review from grvillic January 24, 2025 18:27
@grvillic grvillic self-requested a review January 29, 2025 06:54
@grvillic grvillic merged commit a209393 into microsoft:main Feb 4, 2025
20 of 23 checks passed
Copy link

github-actions bot commented Feb 4, 2025

👋 Hi! It looks like you modified some files in the Detectors folder.
You may need to bump the detector versions if any of the following scenarios apply:

  • The detector detects more or fewer components than before
  • The detector generates different parent/child graph relationships than before
  • The detector generates different devDependencies values than before

If none of the above scenarios apply, feel free to ignore this comment 🙂

@rzhao271 rzhao271 deleted the rzhao271/skip-engines-vscode branch February 4, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants