Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix usage of temporary string #185

Merged
merged 3 commits into from
Mar 8, 2019
Merged

Fix usage of temporary string #185

merged 3 commits into from
Mar 8, 2019

Conversation

janisozaur
Copy link
Contributor

@janisozaur janisozaur commented Mar 7, 2019 •
edited by danbelcher-MSFT
Loading

Fixes #173

@janisozaur
Copy link
Contributor Author

janisozaur commented Mar 7, 2019 •
edited
Loading

It reads Build #0.1903.767.0 has failed, but I can see no error. Can someone please provide information on where it failed? The failing job is supposed to be here: https://dev.azure.com/ms/23383dcd-16bf-49fc-9556-1cb151958a4c/_build/results?buildId=4867

@janisozaur
Copy link
Contributor Author

Clicking around the linked page revealed it might be the infamous

The agent: essential000002 lost communication with the server. Verify the machine is running and has a healthy network connection. For more information, see: https://go.microsoft.com/fwlink/?linkid=846610

I will rebase this commit to re-trigger the CI.

@mcooley
Copy link
Member

mcooley commented Mar 7, 2019

We're still tweaking the settings on the pool of machines which run unit tests (essential##). Please run the tests locally to make sure they pass--we'll take care of re-queuing the CI tests on your behalf.

jlaanstra
jlaanstra reviewed Mar 8, 2019
View reviewed changes
src/CalcViewModel/StandardCalculatorViewModel.cpp
@@ -488,7 +488,7 @@ void StandardCalculatorViewModel::HandleUpdatedOperandData(Command cmdenum)
m_selectedExpressionLastData = L"";
if (ch == 'x')
{
temp = L'\0';
temp[0] = L'\0';
Copy link
Contributor

@jlaanstra jlaanstra Mar 8, 2019 •
edited by danbelcher-MSFT
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you're changing this, let's remove the new and replace it with something better.

@danbelcher-MSFT danbelcher-MSFT mentioned this pull request Mar 8, 2019
Closed
@bwaldbaum bwaldbaum merged commit c6b770e into microsoft:master Mar 8, 2019
@janisozaur janisozaur deleted the patch-4 branch March 8, 2019 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlaanstra jlaanstra jlaanstra left review comments

@bwaldbaum bwaldbaum bwaldbaum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@janisozaur @mcooley @jlaanstra @bwaldbaum