Code cleanup: Use number formatting utilities from the standard library #1743
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should avoid using the
NumberFormattingUtils
class in CalcManager. The standard libraries in both C# and C++ offer number-formatting functionality, and we should use that where possible.This PR removes all use of NumberFormattingUtils from Graphing Calculator code, so the only remaining code that uses it is in unit converter. Unit converter has many other problems (see #379), so I didn't attempt to refactor it in this PR.
There are three areas that changed:
double.ToString()
, which defaults to the general ("G") format. The notable change in behavior vs. the previous behavior is that scientific notation might be used if it enables a shorter output, although this should be rare since numbers of this magnitude are hard to input in the UI.