Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Mica Material #1611

Closed
sumeshir26 opened this issue Jul 16, 2021 · 3 comments
Closed

Add Mica Material #1611

sumeshir26 opened this issue Jul 16, 2021 · 3 comments
Labels
duplicate Issue identified as a duplicate of another issue(s) Enhancement Pri: 2

Comments

@sumeshir26
Copy link

sumeshir26 commented Jul 16, 2021 •
edited
Loading

Problem Statement

Mica would look nicer in the app than acrylic
Evidence or User Insights

Microsoft is adding Mica to apps instead of Acrylic like File Explorer and Settings in Windows 11
Proposal

Mica Material

Goals

Better performance compared to Acrylic.

Non-Goals

Low-Fidelity Concept

Requested Assignment

If possible, I would like to implement this.
@MicrosoftIssueBot
Copy link
Collaborator

This is your friendly Microsoft Issue Bot. I've seen this issue come in and have gone to tell a human about it.

@mdtauk
Copy link

mdtauk commented Jul 17, 2021

At the moment, Mica when used on Windows 10, is a solid neutral colour - so it would be better for now to either keep the Acrylic, or swap which material is used based on the OS.

guominrui added a commit that referenced this issue Jul 21, 2021
@guominrui
Update to WinUI 2.6
7cdc247 
Co-authored-by: Han Zhang <[email protected]>
Co-authored-by: Kenny Guo <[email protected]>

**Description of the changes:**
1. Update to WinUI 2.6 styles and controls #1606.
2. Add Mica Material #1611.
3. Add Settings page #596.
4. Fix Ctrl+E shortcuts in AoT mode #1590.

**How changes were validated:**
Passed build, UT/UI test and manually tested.
@grochocki
Copy link
Contributor

This should be covered by #1606, so going to close this as a dupe of that issue.

@grochocki grochocki added the duplicate Issue identified as a duplicate of another issue(s) label Jul 22, 2021
@hanzhang54 hanzhang54 mentioned this issue Jul 26, 2021
Merged
hanzhang54 added a commit that referenced this issue Jul 27, 2021
@hanzhang54
Update to WinUI 2.6 (#1618)
e06355c 
* Update to WinUI 2.6

Co-authored-by: Han Zhang <[email protected]>
Co-authored-by: Kenny Guo <[email protected]>

**Description of the changes:**
1. Update to WinUI 2.6 styles and controls #1606.
2. Add Mica Material #1611.
3. Add Settings page #596.
4. Fix Ctrl+E shortcuts in AoT mode #1590.

**How changes were validated:**
Passed build, UT/UI test and manually tested.

* Fixed the display issue in AOT mode (#1615)

* Fixed the display issue in AOT mode

* Get the OpenPaneLength from the resource

* Fix CalendarView style in DateCalculation of dark mode (#1616)

* Fix a style problem of Date Calculator, and clean some unused codes

* Remove some unused codes

* Disable Mica before close the window to resolve a crash (#1619)

* Bump internal package build number (#1621)
@ghost ghost locked as resolved and limited conversation to collaborators Aug 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
duplicate Issue identified as a duplicate of another issue(s) Enhancement Pri: 2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@grochocki @mdtauk @MicrosoftIssueBot @sumeshir26