This repository has been archived by the owner on Jun 30, 2022. It is now read-only.
fix for invariant/empty culture #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lzc850612
approved these changes
Dec 13, 2018
|
Even with the above change, the CalendarSkill throws an exception in MainDialog.cs line 233. "Skill Error: The given key 'iv' was not present in the dictionary. | at System.Collections.Generic.Dictionary`2.get_Item(TKey key)\r\n at CalendarSkill.MainDialog.OnInterruptDialogAsync(DialogContext dc, CancellationToken cancellationToken) in D:\assist-modify\new\AI\solutions\Virtual-Assistant\src\csharp\skills\calendarskill\Dialogs\Main\MainDialog.cs:line 233\r\n |
|
@kendomen I added a change. Please try it and let me know! |
|
lauren-mills
added a commit
that referenced
this pull request
Apr 18, 2019
* fix for invariant/empty culture * updated setlocalemiddleware
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix to use defaultLocale when CultureInfo is "iv".
Related Issue
fixes #442
Testing Steps