Skip to content
This repository has been archived by the owner on Jun 30, 2022. It is now read-only.

[Botskill] Add validation for .lu and .dispatch file's path #1321

Merged
merged 1 commit into from
May 9, 2019

Conversation

dfavretto
Copy link
Contributor

Description

Related issue #1246

  • Add validation for .lu file, throw Error if file does not exist, stop command execution.
  • Add validation for .dispatch file, throw Error if file does not exist, stop command execution.'

Testing Steps

  1. Go to AI\lib\typescript\botskills\.
  2. Open a terminal in that location.
  3. Run the command npm install to install dependencies.
  4. Run the command npm run build to build the project.
  5. Run the command npm link to symlink the package folder.
  6. Run the command botskills connect with the proper arguments, but leading to a nonexistent .lu file.
  7. Check the error thrown for the nonexistent .lu file, and the execution of the command is stopped.
  8. Repeat the execution of the command botskills connect but this time with a misleading .dispatch path.
  9. Check the error thrown for the nonexistent .dispatch file, and the execution of the command is stopped.

Checklist

  • I have commented my code, particularly in hard-to-understand areas

@darrenj darrenj merged commit ffc9344 into master May 9, 2019
@darrenj darrenj deleted the southworks/botskills/handle-missing-files branch May 9, 2019 00:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants