This repository has been archived by the owner on Jun 30, 2022. It is now read-only.
[Botskills] Fix authentication issue and other minor ones #1293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfavretto
requested review from
darrenj,
lauren-mills,
lzc850612 and
ryanisgrig
as code owners
|
Are these package references OK in packages lock? https://www.myget.org/F/project-kobuk/npm/asynckit/-/asynckit-0.4.0.tgz |
enzocano
force-pushed
the
southworks/botskills/fix-issue-connect
branch
from
92e8a3d to
7e89a22
Compare
|
Hey @darrenj, we fixed the merge conflicts. In this PR, the dependencies are referencing our registry; we'll change that when the aitemplates registry contains the |
10 tasks
lzc850612
pushed a commit
that referenced
this pull request
Jul 31, 2019
* Fix issue with auth connect * Update packages * Fix issue with disconnect (luisgen) * Add messages for assistantSkillsFile.skills * Add validation for assistantSkillsFile.skills * Update package version
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #1230
az ad app showwhich lacked an space when concatenating args.lgLanguageoption to disconnect for LUISGen command.Testing Steps
AI\lib\typescript\botskills\.npm installto install dependencies.npm run buildto build the project.npm linkto symlink the package folder.botskills connectwith the proper arguments for testing the authentication process.botskills listwith the proper arguments and an improperskills.jsonto test the warning messages.botskills disconnectwith the proper arguments to test the LUISGen to generate the correct file.