Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add patch to limit pytest-mypy-plugins version for python-attrs test #8244

Merged
merged 2 commits into from
Mar 5, 2024

Conversation

sameluch
Copy link
Contributor

@sameluch sameluch commented Mar 5, 2024

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

What does the PR accomplish, why was it needed?
Fix package test failures by limiting the version of pytest-mypy-plugins

Change Log
  • Add patch to limit version of pytest-mypy-plugins for package tests
Does this affect the toolchain?

NO

Test Methodology

@sameluch sameluch requested a review from a team as a code owner March 5, 2024 05:20
@microsoft-github-policy-service microsoft-github-policy-service bot added main PR Destined for main labels Mar 5, 2024
SPECS/python-attrs/python-attrs.spec Outdated Show resolved Hide resolved
@sameluch sameluch merged commit 51b6b44 into main Mar 5, 2024
10 checks passed
@sameluch sameluch deleted the sammeluch/python-attrs-test-fix branch March 5, 2024 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
main PR Destined for main
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants