[SQL Migration] Update mssql contracts to support XEvents assessment #21577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 3898348226
💛 - Coveralls |
siyangMicrosoft
approved these changes
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a previous PR (microsoft/sqltoolsservice#1734), the assessments NuGet was updated to support XEvents assessments, and in the backend sqltoolsservice the appropriate contracts were updated. However, on the ADS side, these corresponding contracts in mssql were not updated, which made us unable to consume these changes.
This PR updates those contracts. Currently there is no user-facing change, but this will unblock us and allow us to build the UI (currently in progress) for this feature as long as these contracts are available in the version of mssql being shipped with the next release of ADS.