Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qiskit qir by default #630

Merged
merged 30 commits into from
Aug 30, 2024
Merged

qiskit qir by default #630

merged 30 commits into from
Aug 30, 2024

Conversation

LawsonGraham
Copy link
Contributor

@LawsonGraham LawsonGraham commented Jul 29, 2024 •
edited
Loading

migrate our SDK to use QIR backends by default for Qiskit backends

@LawsonGraham LawsonGraham requested a review from a team as a code owner July 29, 2024 18:33
@LawsonGraham LawsonGraham force-pushed the t-lgraham/qiskit-qir-by-default branch from 6254e50 to 4612b30 Compare August 2, 2024 00:12
@LawsonGraham LawsonGraham force-pushed the t-lgraham/qiskit-qir-by-default branch 2 times, most recently from 0170530 to ae44795 Compare August 6, 2024 18:59
kikomiss
kikomiss reviewed Aug 7, 2024
View reviewed changes
azure-quantum/azure/quantum/qiskit/job.py Outdated Show resolved Hide resolved
azure-quantum/azure/quantum/qiskit/job.py Outdated Show resolved Hide resolved
azure-quantum/azure/quantum/qiskit/provider.py Outdated Show resolved Hide resolved
azure-quantum/tests/unit/test_qiskit.py Outdated Show resolved Hide resolved
@LawsonGraham LawsonGraham force-pushed the t-lgraham/qiskit-qir-by-default branch 2 times, most recently from 079026d to 8cc4382 Compare August 7, 2024 01:38
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 8, 2024
View reviewed changes
azure-quantum/tests/unit/recordings/test_plugins_retrieve_job.yaml Fixed Show fixed Hide fixed
azure-quantum/tests/unit/recordings/test_plugins_retrieve_job.yaml Fixed Show fixed Hide fixed
azure-quantum/tests/unit/recordings/test_plugins_submit_qiskit_circuit_as_list_to_ionq.yaml Fixed Show fixed Hide fixed
azure-quantum/tests/unit/recordings/test_plugins_submit_qiskit_circuit_as_list_to_ionq.yaml Fixed Show fixed Hide fixed
...-quantum/tests/unit/recordings/test_plugins_submit_qiskit_circuit_as_list_to_quantinuum.yaml Fixed Show fixed Hide fixed
azure-quantum/tests/unit/recordings/test_plugins_submit_qiskit_to_ionq.yaml Fixed Show fixed Hide fixed
azure-quantum/tests/unit/recordings/test_plugins_submit_qiskit_to_ionq.yaml Fixed Show fixed Hide fixed
azure-quantum/tests/unit/recordings/test_plugins_submit_qiskit_to_quantinuum.yaml Fixed Show fixed Hide fixed
kikomiss
kikomiss reviewed Aug 9, 2024
View reviewed changes
azure-quantum/tests/unit/test_qiskit.py Outdated Show resolved Hide resolved
azure-quantum/tests/unit/test_qiskit.py Outdated Show resolved Hide resolved
azure-quantum/tests/unit/test_qiskit.py Outdated Show resolved Hide resolved
@LawsonGraham LawsonGraham force-pushed the t-lgraham/qiskit-qir-by-default branch from 0d179fd to 82557ed Compare August 14, 2024 21:39
@cesarzc
Copy link

cesarzc commented Aug 15, 2024 •
edited
Loading

@LawsonGraham, could you please update your development branch with the latest changes from main? There is one change that was recently merge that will probably have a conflict with your changes.

@kikomiss, could you please take a look at the recording files to check that they are correct? Also, I believe the security alerts can be dismissed given that they're just triggering because the recordings we get back contain the word "md5", but I wanted to double check with you in case I'm missing something.

github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 15, 2024
View reviewed changes
azure-quantum/tests/unit/recordings/test_plugins_retrieve_job.yaml Fixed Show fixed Hide fixed
azure-quantum/tests/unit/recordings/test_plugins_retrieve_job.yaml Fixed Show fixed Hide fixed
azure-quantum/tests/unit/recordings/test_plugins_submit_qiskit_circuit_as_list_to_ionq.yaml Fixed Show fixed Hide fixed
azure-quantum/tests/unit/recordings/test_plugins_submit_qiskit_circuit_as_list_to_ionq.yaml Fixed Show fixed Hide fixed
...ts/unit/recordings/test_plugins_submit_qiskit_circuit_as_list_to_quantinuum_passthrough.yaml Fixed Show fixed Hide fixed
azure-quantum/tests/unit/recordings/test_plugins_submit_qiskit_to_ionq.yaml Fixed Show fixed Hide fixed
azure-quantum/tests/unit/recordings/test_plugins_submit_qiskit_to_ionq.yaml Fixed Show fixed Hide fixed
@cesarzc
Copy link

cesarzc commented Aug 16, 2024

@LawsonGraham, the logic looks good!

Once the CI pipeline errors are addressed and @kikomiss confirms whether the changes to recordings are correct, I'll approve.

@kikomiss kikomiss merged commit a4873e0 into microsoft:main Aug 30, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idavis idavis idavis left review comments

@kikomiss kikomiss kikomiss approved these changes

@cesarzc cesarzc cesarzc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@LawsonGraham @cesarzc @idavis @kikomiss @masenol