Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix expired sas token on getting job result #593

Merged
merged 6 commits into from
Apr 16, 2024
Merged

Fix expired sas token on getting job result #593

merged 6 commits into from
Apr 16, 2024

Conversation

ArthurKamalov
Copy link
Contributor

@ArthurKamalov ArthurKamalov commented Mar 27, 2024

This PR adds verification of the sas token's expiration time, to refresh it, if necessary.
fixes #553

@ArthurKamalov ArthurKamalov requested a review from kikomiss March 27, 2024 20:38
@vxfield
Copy link
Member

vxfield commented Mar 28, 2024

@ArthurKamalov, can you try to merge the xfield/enable-disable-scrubbing into your branch and use the new ability to disable the scrubbing of se= (example in #595).
@kikomiss: FYI

@kikomiss kikomiss marked this pull request as ready for review April 12, 2024 01:20
@kikomiss kikomiss requested a review from a team as a code owner April 12, 2024 01:20
@vxfield vxfield enabled auto-merge (squash) April 16, 2024 01:52
@vxfield
Copy link
Member

vxfield commented Apr 16, 2024

@kikomiss, I've made the following changes that were causing non-deterministic behavior in the test case:

  1. Submit a job to the echo-output target instead of using the latest submitted job in the workspace.
    This guarantees deterministic behavior in terms of the job's output_data_uri and we can actually test the blob being downloaded (an unknown job may no longer have its output data).

  2. Using the same Regular Expression that we use to sanitize test recordings to replace the se= query string parameter with a value formatted in the same way.

I tested in two different machines that both recording mode and playback mode are working.

@vxfield vxfield merged commit 01c2dd0 into main Apr 16, 2024
7 checks passed
@vxfield vxfield deleted the fix-sas-token branch April 16, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

job.get_results fail with expired token
3 participants