Implementing KeyValueCoding dictionaryWithValuesForKeys functionality. #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -30,10 +30,10 @@ | |||
|
|
|||
| #import <unicode/utf8.h> | |||
|
|
|||
| #include <stdio.h> | |||
| #include <stdlib.h> | |||
| #include <functional> | |||
There was a problem hiding this comment.
auto formatted is reordering the import order.
|
Overall, I approve of this. I won't withhold my approval for my comments :) |
|
|
|
🕐 |
|
comments addressed |
| [results setValue:(retValue ?: [NSNull null]) forKey:key]; | ||
| } | ||
|
|
||
| return [[results copy] autorelease]; |
There was a problem hiding this comment.
this seems like it may be better served by a vector or something local so that you can just make the final dictionary without doing potentially expensive grows and copies on the mutable guy.
|
|
1 similar comment
|
|
rajsesh
pushed a commit
that referenced
this pull request
May 31, 2016
shahmeeresmail
pushed a commit
to shahmeeresmail/WinObjC
that referenced
this pull request
Jun 10, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.