February 2018 Release #2845
Merged
February 2018 Release #2845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a workaround to an issue where the projects are expecting net40 to be a package dependency.
…er in it (cherry picked from commit 5668733b77961d72b23d277463f1d2d815529718)
This change moves the generation of the objc_2stage_init.cpp ClCompile item to ComputeCompileInputsTargets. BeforeClCompileTargets targets are only triggered for ClCompile, which doesn't happen on every Link.
This commit also stops us from compiling temporary regexes every time we parse a layout constraint. By trading a little memory (only exacted when we first parse a constraint) we get a little time in return.
|
please remove we can't have gitversion freaking out again |
|
I'm alarmed that there are two ❌ in the commit history this merge covers. |
|
Not sure why those ❌'s are there. One particular build failed due to an issue recently fixed, but that shouldn't have affected these older commits. |
|
I think that when you kick off the build for this, you have to set |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge develop into master.
Updates:
This change is