Add Kali to modern distributions

[Gamb1ts]

No description provided.

[github-actions]

Thank you for your contribution to WSL.
The following fatal errors have been found in this pull request:

• kali/None: Found no default distribution

The following suggestions have been found in this pull request:

• kali/kali-linux: Found discouraged system unit: /usr/lib/systemd/system/local-fs.target.wants/tmp.mount
• kali/kali-linux: Found discouraged system unit: /usr/lib/systemd/system/sysinit.target.wants/systemd-tmpfiles-setup-dev-early.service
• kali/kali-linux: Found discouraged system unit: /usr/lib/systemd/system/sysinit.target.wants/systemd-tmpfiles-setup-dev.service
• kali/kali-linux: Found discouraged system unit: /usr/lib/systemd/system/sysinit.target.wants/systemd-tmpfiles-setup.service
• kali/kali-linux: Found discouraged system unit: /etc/systemd/system/network-online.target.wants/networking.service
• kali/kali-linux: Found discouraged system unit: /usr/lib/systemd/system/local-fs.target.wants/tmp.mount
• kali/kali-linux: Found discouraged system unit: /usr/lib/systemd/system/sysinit.target.wants/systemd-tmpfiles-setup.service
• kali/kali-linux: Found discouraged system unit: /usr/lib/systemd/system/sysinit.target.wants/systemd-tmpfiles-setup-dev.service
• kali/kali-linux: Found discouraged system unit: /usr/lib/systemd/system/sysinit.target.wants/systemd-tmpfiles-setup-dev-early.service
• kali/kali-linux: Found discouraged system unit: /etc/systemd/system/network-online.target.wants/networking.service

[Gamb1ts]

@Gamb1ts please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

• (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.

@microsoft-github-policy-service agree

• (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.

@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree company="OffSec"

[github-actions]

Thank you for your contribution to WSL.
No fatal errors have been found.
The following suggestions have been found in this pull request:

• kali/kali-linux: Found discouraged system unit: /usr/lib/systemd/system/local-fs.target.wants/tmp.mount
• kali/kali-linux: Found discouraged system unit: /usr/lib/systemd/system/sysinit.target.wants/systemd-tmpfiles-setup-dev-early.service
• kali/kali-linux: Found discouraged system unit: /usr/lib/systemd/system/sysinit.target.wants/systemd-tmpfiles-setup-dev.service
• kali/kali-linux: Found discouraged system unit: /usr/lib/systemd/system/sysinit.target.wants/systemd-tmpfiles-setup.service
• kali/kali-linux: Found discouraged system unit: /etc/systemd/system/network-online.target.wants/networking.service
• kali/kali-linux: Found discouraged system unit: /usr/lib/systemd/system/local-fs.target.wants/tmp.mount
• kali/kali-linux: Found discouraged system unit: /usr/lib/systemd/system/sysinit.target.wants/systemd-tmpfiles-setup.service
• kali/kali-linux: Found discouraged system unit: /usr/lib/systemd/system/sysinit.target.wants/systemd-tmpfiles-setup-dev.service
• kali/kali-linux: Found discouraged system unit: /usr/lib/systemd/system/sysinit.target.wants/systemd-tmpfiles-setup-dev-early.service
• kali/kali-linux: Found discouraged system unit: /etc/systemd/system/network-online.target.wants/networking.service

[OneBlue]

Thank you @Gamb1ts !

Feel free to ignore the bot's warnings on the masked systemd units, I need to go fix that !

The tar & manifest look great ! One small suggestion that I have would to use systemctl is-system-running in /usr/lib/wsl/wsl-oobe so we could get remove the sleep 25 and make the distribution start a bit faster.

Something like this should do the trick:

timeout 25 bash -c 'while ! systemctl is-system-running | grep -E "running|degraded" ; do sleep 1; done'  || echo "warning: timed out waiting for systemd to start"

[benhillis]

What's the goal of sleeping to wait for systemd in the oobe script? If you want to make sure that no user processes are launched before systemd is up, that should already be guaranteed as part of WSL. Is that not the behavior you are seeing?

[Gamb1ts]

Early in my testing I found that the system setup was too quick which led to issues using certain commands. However, this was prior to masking the recommended systemd units. I will re-visit this and see if in its current state the wait is necessary.

Unfortunately I will have to mark this as WIP until next week, we will need to change where we host the image. Next week I will supply the new URL and checksums.

[github-actions]

Thank you for your contribution to WSL.
No fatal errors have been found.
The following suggestions have been found in this pull request:

• kali/kali-linux: Found discouraged system unit: /usr/lib/systemd/system/sysinit.target.wants/systemd-tmpfiles-setup.service
• kali/kali-linux: Found discouraged system unit: /usr/lib/systemd/system/sysinit.target.wants/systemd-tmpfiles-setup-dev.service
• kali/kali-linux: Found discouraged system unit: /usr/lib/systemd/system/sysinit.target.wants/systemd-tmpfiles-setup-dev-early.service
• kali/kali-linux: Found discouraged system unit: /usr/lib/systemd/system/local-fs.target.wants/tmp.mount
• kali/kali-linux: Found discouraged system unit: /etc/systemd/system/network-online.target.wants/networking.service
• kali/kali-linux: Found discouraged system unit: /usr/lib/systemd/system/sysinit.target.wants/systemd-tmpfiles-setup.service
• kali/kali-linux: Found discouraged system unit: /usr/lib/systemd/system/sysinit.target.wants/systemd-tmpfiles-setup-dev.service
• kali/kali-linux: Found discouraged system unit: /usr/lib/systemd/system/sysinit.target.wants/systemd-tmpfiles-setup-dev-early.service
• kali/kali-linux: Found discouraged system unit: /usr/lib/systemd/system/local-fs.target.wants/tmp.mount
• kali/kali-linux: Found discouraged system unit: /etc/systemd/system/network-online.target.wants/networking.service

[Gamb1ts]

I have disabled the wait on systemd, I was able to confirm that it is not needed. I have also updated the URL to utilize our mirror kali.download. Unless there is any other feedback, the Kali team is good with the PR at this stage.

[OneBlue]

FYI when I tried it locally, I got the following output:

Please create a default Kali WSL user. The username does not need to match your Windows username.
For more information visit: https://aka.ms/wslusers
Enter new UNIX username: blue
logger: socket /dev/log: No such file or directory
logging to syslog failed: command line logger --id=139 --tag=adduser --priority=user.info  -- Adding user `blue' ... returned error: 256
logger: socket /dev/log: No such file or directory
logging to syslog failed: command line logger --id=139 --tag=adduser --priority=user.info  -- Adding new group `blue' (1000) ... returned error: 256
logger: socket /dev/log: No such file or directory
logging to syslog failed: command line logger --id=139 --tag=adduser --priority=user.info  -- Adding new user `blue' (1000) with group `blue (1000)' ... returned error: 256
logger: socket /dev/log: No such file or directory
logging to syslog failed: command line logger --id=139 --tag=adduser --priority=user.info  -- Creating home directory `/home/blue' ... returned error: 256
logger: socket /dev/log: No such file or directory
logging to syslog failed: command line logger --id=139 --tag=adduser --priority=user.info  -- Copying files from `/etc/skel' ... returned error: 256

Looking through dmesg, I can see the following logline:

Legacy cgroup v1 support selected. This is no longer supported. Will proceed anyway after 30s. . This is most likely what's causing the systemd delay that you originally saw.

Let me see if this can be solved from the WSL side.

[OneBlue]

Looks like we can solve this on the WSL via: SYSTEMD_CGROUP_ENABLE_LEGACY_FORCE=1.

In the meantime, I'd recommend adding the logic to wait to systemd to the OOBE, so it doesn't print the above the error. I refined my earlier suggestion to make the output a bit cleaner:

echo 'Waiting for systemd to start...'
timeout 25 bash -c 'while ! systemctl is-system-running 2> /dev/null | grep -E "running|degraded > /dev/null"; do sleep 1; done' || echo "Warning: timed out waiting for systemd to start"

(that way the user won't get Failed to connect to bus: No such file or directory on stderr when waiting for systemd)

[github-actions]

Thank you for your contribution to WSL.
The following fatal errors have been found in this pull request:

• kali/kali-linux: URL https://kali.download/wsl-images/current/kali-linux-2024.4-wsl-rootfs-amd64.wsl Sha256 does not match. Expected: 251ae5b9a05697da301fa5158d316f838e8130fef152df65016c6e17febfaa54, actual: 7beaaa0a03beb533761c4638654bcc21721c5248b8fc1fd3223375c71297f969
• kali/kali-linux: URL https://kali.download/wsl-images/current/kali-linux-2024.4-wsl-rootfs-arm64.wsl Sha256 does not match. Expected: 1ac937dd49c621063272524cb1b14ac4f1631fbbfe3df16685ad0924cb2708cf, actual: 65fc698ae6ee5da3bca281b4e241e92e42771541121bd018ffdd78f43c5a2651

The following suggestions have been found in this pull request:

• kali/kali-linux: Found discouraged system unit: /usr/lib/systemd/system/sysinit.target.wants/systemd-tmpfiles-setup.service
• kali/kali-linux: Found discouraged system unit: /usr/lib/systemd/system/sysinit.target.wants/systemd-tmpfiles-setup-dev.service
• kali/kali-linux: Found discouraged system unit: /usr/lib/systemd/system/sysinit.target.wants/systemd-tmpfiles-setup-dev-early.service
• kali/kali-linux: Found discouraged system unit: /usr/lib/systemd/system/local-fs.target.wants/tmp.mount
• kali/kali-linux: Found discouraged system unit: /etc/systemd/system/network-online.target.wants/networking.service
• kali/kali-linux: Found discouraged system unit: /usr/lib/systemd/system/sysinit.target.wants/systemd-tmpfiles-setup.service
• kali/kali-linux: Found discouraged system unit: /usr/lib/systemd/system/sysinit.target.wants/systemd-tmpfiles-setup-dev.service
• kali/kali-linux: Found discouraged system unit: /usr/lib/systemd/system/sysinit.target.wants/systemd-tmpfiles-setup-dev-early.service
• kali/kali-linux: Found discouraged system unit: /usr/lib/systemd/system/local-fs.target.wants/tmp.mount
• kali/kali-linux: Found discouraged system unit: /etc/systemd/system/network-online.target.wants/networking.service

[Gamb1ts]

Yeah that was the same issue I was seeing previously. With the latest pre-release WSL installed I was no longer having the issue FWIW.

I have re-added the systemd wait and re-built the images. The checksums have been updated but the link is the same. The site is heavily cached so may need to clear it.

[github-actions]

Thank you for your contribution to WSL.
No fatal errors have been found.
The following suggestions have been found in this pull request:

• kali/kali-linux: Found discouraged system unit: /usr/lib/systemd/system/sysinit.target.wants/systemd-tmpfiles-setup.service
• kali/kali-linux: Found discouraged system unit: /usr/lib/systemd/system/sysinit.target.wants/systemd-tmpfiles-setup-dev.service
• kali/kali-linux: Found discouraged system unit: /usr/lib/systemd/system/sysinit.target.wants/systemd-tmpfiles-setup-dev-early.service
• kali/kali-linux: Found discouraged system unit: /usr/lib/systemd/system/local-fs.target.wants/tmp.mount
• kali/kali-linux: Found discouraged system unit: /etc/systemd/system/network-online.target.wants/networking.service
• kali/kali-linux: Found discouraged system unit: /usr/lib/systemd/system/sysinit.target.wants/systemd-tmpfiles-setup.service
• kali/kali-linux: Found discouraged system unit: /usr/lib/systemd/system/sysinit.target.wants/systemd-tmpfiles-setup-dev.service
• kali/kali-linux: Found discouraged system unit: /usr/lib/systemd/system/sysinit.target.wants/systemd-tmpfiles-setup-dev-early.service
• kali/kali-linux: Found discouraged system unit: /usr/lib/systemd/system/local-fs.target.wants/tmp.mount
• kali/kali-linux: Found discouraged system unit: /etc/systemd/system/network-online.target.wants/networking.service

[OneBlue]

Thank you @Gamb1ts. I restarted the pipeline, and the hashes match now.

Although I still see the systemd wait logic being commented /usr/lib/wsl/wsl-oobe (and I validated the distribution hash, so I don't think I got a cached file).

[Gamb1ts]

I will rebuild the image and verify locally it is back in

[Gamb1ts]

Re-built and verified the oobe has the systemd wait

[github-actions]

Thank you for your contribution to WSL.
No fatal errors have been found.
No suggestions have been found.

[OneBlue]

Thank you @Gamb1ts. Just tried it out, the OOBE works perfectly now.

Feel free to merge whenever ready.