Support shorthand ambient module declarations #8945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -53,7 +53,8 @@ namespace ts { | |||
| return state; | |||
| } | |||
| else if (node.kind === SyntaxKind.ModuleDeclaration) { | |||
| return getModuleInstanceState((<ModuleDeclaration>node).body); | |||
| const body = (<ModuleDeclaration>node).body; | |||
| return body ? getModuleInstanceState(body) : ModuleInstanceState.NonInstantiated; | |||
There was a problem hiding this comment.
should always be instantiated if there is no body present.
ghost
force-pushed
the
shorthand_ambient_module
branch
from
e6a306c to
7e9cb46
Compare
ghost
mentioned this pull request
|
please add a test for:
|
|
also a test for goto def in the language service. and find all refs. |
|
other than that looks good. thanks! |
added 6 commits
June 9, 2016 11:43
do not think so. |
|
👍 |
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Half of #6615