6974 add lib implementation #7715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
March 28, 2016 13:49
Separate ES6 library feature-by-feature into smaller files Break ES6 library Remove unused ES6 Rename core to es5 Update building library files in JakeFile separate symbol into its own file separate well-known symbol into its own file remove iterable and symbol component from es6.string.d.ts remove iterable and symbol components from es6.collection.d.ts remove symbol components from es6.math.d.ts remove iterable and symbol components from es6.object.d.ts remove iterable and symbol components from es6.promise.d.ts remove iterable and symbol component from es6.reflect.d.ts remove iterable and symbol components from es6.proxy.d.ts split regexp into its own file remove unused file rename es7 array-include d.ts file Include new lib files into compilation Move symbol.iterable to symbol.wellknown Move functions/methods that use propertyKey back to its original interface Rename dome.es6 to dom.iterable Take dependency on dom.generated.d.ts Rename importcore.d.ts to importes5.d.ts Add es6.d.ts and es7.d.ts that contain /// references to their associated sub-features files Update library compilation Fix harness broken from renaming generated library files Remove intl.d.ts Remove preset lib files Use lib.full.es6.d.ts instead of lib.es6.d.ts Add intl.d.ts to es5.d.ts Remove unused RegexpConstructor interface Separate generator into its own file Update Jakefile Remove iterable-iterator dependence Use lower case for lib filename Include no-default comment Remove newline on top of the file
Add --lib compiler tests and baselines Remove old compiler baselines
| let getGlobalESSymbolType: () => ObjectType; | ||
| let getGlobalIterableType: () => GenericType; | ||
| let getGlobalIteratorType: () => GenericType; | ||
| let getGlobalIterableIteratorType: () => GenericType; |
There was a problem hiding this comment.
What exactly is the reason these are lazy again?
There was a problem hiding this comment.
Because we don't want to give an error even when you don't use any of these feature. For example, if you code only use es6-array features and you specify --lib es2015.array you should not get an error of "can't find 'Symbol' or 'Iterator'": Being lazy allows us to do that
There was a problem hiding this comment.
Sounds great! Can you leave that comment above these declarations?
added 7 commits
March 28, 2016 16:24
This was referenced Mar 29, 2016
Closed
| const newLine = getNewLineCharacter(options); | ||
|
|
||
| return { | ||
| getSourceFile, | ||
| getDefaultLibLocation, | ||
| getDefaultLibFileName: options => combinePaths(getDirectoryPath(normalizePath(sys.getExecutingFilePath())), getDefaultLibFileName(options)), |
There was a problem hiding this comment.
i would change this to be:
combinePaths(getDefaultLibLocation(), getDefaultLibFileName(options)),
``
|
👍 |
added 8 commits
March 29, 2016 22:51
…ft/TypeScript into 6974AddLibImplementation # Conflicts: # src/harness/harness.ts
added 2 commits
March 30, 2016 14:03
This was referenced Apr 4, 2016
|
@yuit would you be opposed to publishing individual definitions to DefinitelyTyped? We could use it on angular2 to be compatible with new versions of RxJS that require CC @alexeagle |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extract only implementation of the PR #7452 (which include symbol baselines that make it hard to review). Symbol baselines will be updated in a separate PR which will merge in here once both are approved to be merged into master branch.