Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

this can be nullish #59761

Merged
merged 2 commits into from
Aug 26, 2024
Merged

this can be nullish #59761

merged 2 commits into from
Aug 26, 2024

Conversation

RyanCavanaugh
Copy link
Member

this keyword wasn't categorized as possibly nullish, but it is.

Fixes #59755

@typescript-bot typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Aug 26, 2024
@RyanCavanaugh RyanCavanaugh merged commit 64931f7 into microsoft:main Aug 26, 2024
32 checks passed
@RyanCavanaugh
Copy link
Member Author

@typescript-bot cherry-pick this to release-5.6

@typescript-bot
Copy link
Collaborator

typescript-bot commented Aug 26, 2024

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
cherry-pick this to release-5.6 ✅ Started ✅ Results

@typescript-bot
Copy link
Collaborator

Hey, @RyanCavanaugh! I've created #59762 for you.

DanielRosenwasser pushed a commit that referenced this pull request Aug 27, 2024
@RyanCavanaugh RyanCavanaugh deleted the fix59755 branch August 27, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Milestone Bug PRs that fix a bug with a specific milestone
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5.6.1-rc Incorrectly assumes "this" is not nullish even when declared as such
3 participants